Received-SPF: pass (google.com: domain of linux-kernel+bounces-125566-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Klymenko, Anatoliy" <Anatoliy.Klymenko@amd.com>
To: Conor Dooley <conor@kernel.org>
CC: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Laurent Pinchart
	<laurent.pinchart@ideasonboard.com>, Maarten Lankhorst
	<maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>, "Simek, Michal" <michal.simek@amd.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong
	<neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>, Jonas Karlman
	<jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, Rob Herring
	<robh+dt@kernel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>, Tomi Valkeinen
	<tomi.valkeinen@ideasonboard.com>, "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "linux-media@vger.kernel.org"
	<linux-media@vger.kernel.org>
Subject: RE: [PATCH v3 8/9] dt-bindings: xlnx: Add VTC and TPG bindings
Thread-Topic: [PATCH v3 8/9] dt-bindings: xlnx: Add VTC and TPG bindings
Thread-Index:
 AQHae9CWOJYT8G1vaUajPKAdUatgu7FDRIUAgADPWeCAAQwKAIAIv8BAgAEJYoCAAKRcwA==
Date: Sat, 30 Mar 2024 02:02:15 +0000
Message-ID:
 <MW4PR12MB7165E47719C72CD5CEB68218E6392@MW4PR12MB7165.namprd12.prod.outlook.com>
References: <20240321-dp-live-fmt-v3-0-d5090d796b7e@amd.com>
 <20240321-dp-live-fmt-v3-8-d5090d796b7e@amd.com>
 <a82d525c-737a-4ac4-9d71-e88f4ba69ea1@linaro.org>
 <MW4PR12MB7165889CE7F27A3F0B29DC7EE6312@MW4PR12MB7165.namprd12.prod.outlook.com>
 <c0d70ba9-34ef-4121-834d-4d107f03d7f0@linaro.org>
 <MW4PR12MB716570A3676218F0C6375E37E63A2@MW4PR12MB7165.namprd12.prod.outlook.com>
 <20240329-overture-tank-d20888f2cb6e@spud>
In-Reply-To: <20240329-overture-tank-d20888f2cb6e@spud>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?PCdvyZBcoJwxbz6H/JuA1UcBsBO5CCm4pg57WINkuMNoERhDiT9n5QOeGp7u?=
 =?us-ascii?Q?7u0V39JfFncoQAo7j+G8Zs+jpsBW/LA0WqCz2ekBpvJMCPWjqcP6bnGsuvji?=
 =?us-ascii?Q?RMhVutwYuH2ak7d6UyZYQ+Rj7qoIGtSdlu79XYYcd7YSn8dtRQrN2Ycj0ncN?=
 =?us-ascii?Q?2c1tdgSuulVzkZK0mbQVLT/PE+2ZtBGEABtIVnJcuc+HYFHMBwhy6K2gPKh9?=
 =?us-ascii?Q?GBFGKdF5LqSCs1Cpc3FZifFBub8LpwRd3Nvcf8qHrRx2p5npRy5LFGcia6sf?=
 =?us-ascii?Q?kbssyj7KbYqoQh36ZphS7a8u5g0JR5S2sBrZWPGVvlG7IU6MNcigZg1pFbF/?=
 =?us-ascii?Q?u+OjC3vkoOe7NpJX8irCgGWFSUQZZhXKuh4Wpj7N2t8ccdwSplcUWn+j4G5Y?=
 =?us-ascii?Q?x/VlnhOFf9eiFq2KZGfqob1dKgaYGzF970cN2DvTQFOgJXT+b652qrDrDkcA?=
 =?us-ascii?Q?JRgjgJQX74wARSCt+0Dw3dkxuHMb7Q4NBy8GHQclQJBIMdPq8rZ7o6/qyIo2?=
 =?us-ascii?Q?tTAb5MjDUhbotsADAzyf+i8Iw0NCRRi1BWmhLXbQ2ZTKUEX+hJ2x44N+1jIn?=
 =?us-ascii?Q?0YuC9BwISnCuoJitVgpvM6DFUnJ+VBKCnOPTQN+yBntHnSdslviMEwPVjXrT?=
 =?us-ascii?Q?ijzekrzfjOeYn/LaEaHovUP1L85fG+Ix+Uf+k2/wkzRJAKKOjToLG81Vvrea?=
 =?us-ascii?Q?Rg38CQYO77oZzaR3vQqqWM8F/pb5YtAY6s5IH007naEuEogpDCHcF0PgJlBI?=
 =?us-ascii?Q?w4zIAZXfXD6GDdyDpJDGDNS8L8pXIh1MdM9b1QCr0TyAsAaij9as4EIqThel?=
 =?us-ascii?Q?2OZyLWQvOFEmsZBg87gZaONTr8JMk7Ej3x2IX0TvtronQLPXzmaaqJsyjiRo?=
 =?us-ascii?Q?/KBxsX0/Xkl9vuIssT0SZaVz1wOpcYExUrJyzHiax5a/+QFZs0n94B/wsOhK?=
 =?us-ascii?Q?B/k18KL88jxpLsxK+sDnz3VSRSHHXjjTZiG+mW6CvefVpG7OvMnFC0szH7Xg?=
 =?us-ascii?Q?8Jc924BlkYzuumnGek/L3nHX2AVKCFz+3WQvKw6XEBjvJLuzT9xRW9tOBD1M?=
 =?us-ascii?Q?ryiJMeMrHZLqnpXbPz88HHLgEfIO/o2LIJtyUU+LnqkCte2jrFXtrfnUPbXC?=
 =?us-ascii?Q?S1QvjvcsXpLXGlAw/GPV7MOe3n+xmRoaFo8JnCZeOrw8FC3+z1PdnTnAQB3w?=
 =?us-ascii?Q?GWctnBJCWIULIqTKf6z2jEHsDq4/b8FaIQcqxo+dxaO/W/N7f6bON0XpatAR?=
 =?us-ascii?Q?ivT6MLGJwdvTQw96t+d1ukIgBMenppNFZT0b4BtVo4QwaFhbjxQVLZxi+2UE?=
 =?us-ascii?Q?rOhHRI85YeV/Nqg92hrXlzM4qGgQiQ9eEfvjzGrWKjCJoeThAB2o+CQb0HA1?=
 =?us-ascii?Q?/sxkFJ7y57hcEMHOZaSWrb0SnW01aG/ME32gaoayTmpZVZbMaMjJ1lM8URnt?=
 =?us-ascii?Q?DyU/Qy2oTHqYht9EoQ2wJEOYVhbn1wJHgAbxn8L6o7ndXe2pt2Y44FTWnyt1?=
 =?us-ascii?Q?82aQ4YXhuG6iZJ26325aXCy/zT7D7ia7A+Zs0umGmh4KekFxotkdQ4PaY905?=
 =?us-ascii?Q?GFsVyas4yBEPC45YMqQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7165.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c45a82d-3a99-4d84-ffbe-08dc505d6bf0
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2024 02:02:15.2277
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: a22Zv405TSk+Pa75bdaXjgDdNP6dLL+RGijPGg+UM3Ak/haHbxBFGxSka1bxWInOzAHrUwB6WrFgcpMWcb3ALw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4068


> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: Friday, March 29, 2024 8:47 AM
> To: Klymenko, Anatoliy <Anatoliy.Klymenko@amd.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Laurent Pinchar=
t
> <laurent.pinchart@ideasonboard.com>; Maarten Lankhorst
> <maarten.lankhorst@linux.intel.com>; Maxime Ripard
> <mripard@kernel.org>; Thomas Zimmermann <tzimmermann@suse.de>;
> David Airlie <airlied@gmail.com>; Daniel Vetter <daniel@ffwll.ch>; Simek,
> Michal <michal.simek@amd.com>; Andrzej Hajda
> <andrzej.hajda@intel.com>; Neil Armstrong <neil.armstrong@linaro.org>;
> Robert Foss <rfoss@kernel.org>; Jonas Karlman <jonas@kwiboo.se>; Jernej
> Skrabec <jernej.skrabec@gmail.com>; Rob Herring <robh+dt@kernel.org>;
> Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
> <conor+dt@kernel.org>; Mauro Carvalho Chehab <mchehab@kernel.org>;
> Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>; dri-
> devel@lists.freedesktop.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-
> media@vger.kernel.org
> Subject: Re: [PATCH v3 8/9] dt-bindings: xlnx: Add VTC and TPG bindings
>=20
> On Fri, Mar 29, 2024 at 12:38:33AM +0000, Klymenko, Anatoliy wrote:
> > Thank you for the feedback.
> > > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > Subject: Re: [PATCH v3 8/9] dt-bindings: xlnx: Add VTC and TPG bindin=
gs
> > > On 22/03/2024 20:12, Klymenko, Anatoliy wrote:
> > > >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > >> On 21/03/2024 21:43, Anatoliy Klymenko wrote:
> > > >>> diff --git a/include/dt-bindings/media/media-bus-format.h
> > > >>> b/include/dt-
> > > >> bindings/media/media-bus-format.h
> > > >>> new file mode 100644
> > > >>> index 000000000000..60fc6e11dabc
> > > >>> --- /dev/null
> > > >>> +++ b/include/dt-bindings/media/media-bus-format.h
> > > >>> @@ -0,0 +1,177 @@
> > > >>> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
> > > >>> +/*
> > > >>> + * Media Bus API header
> > > >>> + *
> > > >>> + * Copyright (C) 2009, Guennadi Liakhovetski
> > > >>> +<g.liakhovetski@gmx.de>
> > > >>> + *
> > > >>> + * This program is free software; you can redistribute it and/or
> > > >>> +modify
> > > >>> + * it under the terms of the GNU General Public License version =
2
> > > >>> +as
> > > >>> + * published by the Free Software Foundation.
> > > >>
> > > >> That's not true. Your SPDX tells something entirely different.
> > > >>
> > > >
> > > > Thank you - I'll see how to fix it.
> > > >
> > > >> Anyway, you did not explain why you need to copy anything anywhere=
.
> > > >>
> > > >> Specifically, random hex values *are not bindings*.
> > > >>
> > > >
> > > > The same media bus format values are being used by the reference
> > > > driver in patch #9. And, as far as I know, we cannot use headers fr=
om
> > > > Linux API headers directly (at least I
> > >
> > > I don't understand what does it mean. You can use in your driver
> whatever
> > > headers you wish, I don't care about them.
> > >
> > >
> > > noticed the same pattern in ../dt-bindings/sdtv-standarts.h for insta=
nce).
> > > What would be the best approach to reusing the same defines on DT and
> > > driver sides from your point of view? Symlink maybe?
> > > >
> > >
> > > Wrap your messages to match mailing list discussion style. There are =
no
> > > defines used in DT. If there are, show me them in *THIS* or other
> > > *upstreamed* (being upstreamed) patchset.
> > >
> >
> > Sorry, I didn't explain properly what I'm trying to achieve. I need to
> > create a DT node property that represents video signal format, one of
> > MEDIA_BUS_FMT_* from include/uapi/linux/media-bus-format.h. It would
> be
> > nice to reuse the same symbolic values in the device tree. What is the
> > best approach here? Should I create a separate header in
> > include/dt-bindings with the same or similar (to avoid multiple
> > definition errors) defines, or is it better to create a symlink to
> > media-bus-format.h like include/dt-bindings/linux-event-codes.h?
>=20
> Isn't there already a property for this, described in
> Documentation/devicetree/bindings/media/xilinx/video.txt
> ?

Those properties are very similar, indeed but not exactly the same. The
one you noticed maps Xilinx video data format on AXI4-Stream transport
that covers color space and chroma subsampling only. The rest of the
signal attributes are either conventional or left out. MEDIA_BUS_FMT_*
collection is more specific and embeds additional information about
video signals, like bits per component and component ordering.