Received-SPF: pass (google.com: domain of linux-kernel+bounces-125581-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240329235812.18917-1-frederic@kernel.org>
In-Reply-To: <20240329235812.18917-1-frederic@kernel.org>
From: Ian Rogers <irogers@google.com>
Date: Fri, 29 Mar 2024 20:23:49 -0700
Message-ID: <CAP-5=fVwT1FPTps=i=hG2O0sWr9DH92VSt66Co=Rhf9dyZX7ag@mail.gmail.com>
Subject: Re: [PATCH 0/4] perf: Fix leaked events when sigtrap = 1
To: Frederic Weisbecker <frederic@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Peter Zijlstra <peterz@infradead.org>, 
	Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, Namhyung Kim <namhyung@kernel.org>, 
	Mark Rutland <mark.rutland@arm.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 29, 2024 at 4:58=E2=80=AFPM Frederic Weisbecker <frederic@kerne=
l.org> wrote:
>
> While looking at task_work users I just noticed that perf doesn't flush
> its own upon event exiting. This looks especially problematic with child
> events. Please have a thourough look at the last patch, I may easily
> have missed something within the maze.
>
> Frederic Weisbecker (4):
>   task_work: s/task_work_cancel()/task_work_cancel_func()/
>   task_work: Introduce task_work_cancel() again
>   perf: Fix event leak upon exit
>   perf: Fix event leak upon exec and file release
>
>  include/linux/perf_event.h |  1 +
>  include/linux/task_work.h  |  3 ++-
>  kernel/events/core.c       | 40 +++++++++++++++++++++++++++++++-------
>  kernel/irq/manage.c        |  2 +-
>  kernel/task_work.c         | 34 +++++++++++++++++++++++++++-----
>  security/keys/keyctl.c     |  2 +-
>  6 files changed, 67 insertions(+), 15 deletions(-)

Thanks for this! I wonder if this relates to fuzzing failures like:
https://lore.kernel.org/linux-perf-users/CAP-5=3DfUa+-Tj2b_hxk96Qg5=3DQu7jY=
HgHREbsmBa2ZmuF-X9QaA@mail.gmail.com/
"[ 2519.138665] unexpected event refcount: 2; ptr=3D000000009c56b097"

Thanks,
Ian

> --
> 2.44.0
>