Received-SPF: pass (google.com: domain of linux-kernel+bounces-125667-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-333-gbfea15422e-fm-20240327.001-gbfea1542
Precedence: bulk
MIME-Version: 1.0
Message-Id: <5e956d59-65f5-405c-8fc1-8faf68f1f02d@app.fastmail.com>
In-Reply-To: <20240330-sparc64-warnings-v1-10-37201023ee2f@ravnborg.org>
References: <20240330-sparc64-warnings-v1-0-37201023ee2f@ravnborg.org>
 <20240330-sparc64-warnings-v1-10-37201023ee2f@ravnborg.org>
Date: Sat, 30 Mar 2024 11:16:02 +0100
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Sam Ravnborg" <sam@ravnborg.org>,
 "Andreas Larsson" <andreas@gaisler.com>,
 "David S . Miller" <davem@davemloft.net>, sparclinux@vger.kernel.org
Cc: "Nick Bowler" <nbowler@draconx.ca>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/10] sparc64: Fix prototype warnings for vdso
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 30, 2024, at 10:57, Sam Ravnborg via B4 Relay wrote:
> From: Sam Ravnborg <sam@ravnborg.org>
>
> Fix the following warnings:
> arch/sparc/vdso/vclock_gettime.c:254:1: error: no previous prototype=20
> for =E2=80=98__vdso_clock_gettime=E2=80=99
> arch/sparc/vdso/vclock_gettime.c:282:1: error: no previous prototype=20
> for =E2=80=98__vdso_clock_gettime_stick=E2=80=99
> arch/sparc/vdso/vclock_gettime.c:307:1: error: no previous prototype=20
> for =E2=80=98__vdso_gettimeofday=E2=80=99
> arch/sparc/vdso/vclock_gettime.c:343:1: error: no previous prototype=20
> for =E2=80=98__vdso_gettimeofday_stick=E2=80=99
> arch/sparc/vdso/vdso32/../vclock_gettime.c:254:1: error: no previous=20
> prototype for =E2=80=98__vdso_clock_gettime=E2=80=99
> arch/sparc/vdso/vdso32/../vclock_gettime.c:282:1: error: no previous=20
> prototype for =E2=80=98__vdso_clock_gettime_stick=E2=80=99
> arch/sparc/vdso/vdso32/../vclock_gettime.c:307:1: error: no previous=20
> prototype for =E2=80=98__vdso_gettimeofday=E2=80=99
> arch/sparc/vdso/vdso32/../vclock_gettime.c:343:1: error: no previous=20
> prototype for =E2=80=98__vdso_gettimeofday_stick=E2=80=99
>
> The warnings were fixed by adding the proper prototypes to asm/vdso.h.
> The better fix would be to convert sparc to be y2038 compliant so the
> generic variant of vdso.h could be used.

I would prefer leaving the warning here until it is fixed
properly, or possibly removing the broken compat vdso
support. The other patches look fine though.

      Arnd