Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp462865lqz; Sat, 30 Mar 2024 04:32:45 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXw/ukAXP6kwbx/ZlODi1E57na5OKBXT3/5a96AMXlhZtvh9PamxD5sEudIExSHls46rJPUGwVFISKbeQ10YmcXqvI3eVPu+svt2CWCiA== X-Google-Smtp-Source: AGHT+IEUaC1LcM8v4KoTEEh89CNP2EY1g97oMozZm/hf3cy3/ncMcpZT29/PrRiTPrT9kP0vMcuE X-Received: by 2002:a17:907:9702:b0:a4e:39ed:2afd with SMTP id jg2-20020a170907970200b00a4e39ed2afdmr2617986ejc.21.1711798365148; Sat, 30 Mar 2024 04:32:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711798365; cv=pass; d=google.com; s=arc-20160816; b=Gd+mTzECc3mPW69vM3TqzC7hBOCfhYpEmFGsAmPG1QnGP6MHWt4rkVKMGN7aatq6MV L5L+3HXiKGAY/WG8utPbUzVn1SzGM6PrvaSD8LxfEst4O891e7vVxBtmeYjcxbMm14vp IdOsjaC5OAaaCWdCcEu1w/TEba204Z3nsCVNLn5IynnAnBhagNkxG9nVG4oGrWRZm/qT DnFQgksoJ4baq06mY/gjd/4Oti+jOcqNPoEP4irDqbKUlSstw1PUnyeoP7jfuXWUJZiQ gbfxibhDy9F+HiClIPz9k+RKjSKfAe9ibGSixvnhh7R5pVG5Km2Q1+t4gfgr2voIYSt0 yZwA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=ExUXrTD223tXybDLDyrKC0GoudjtX3ivRD1n/3oKum4=; fh=WHWgkFYcPWggSdj4ojdGXbasEwsUTxHYKIIZchdljyk=; b=pw+CDl9YISBkRW3GTabiW91djHn++vF2HavzUpoR1a27HmRw1hgRpj9+u58A/qxmH9 o+KPwXI4r8HpZB9hnFifJmxLUfNLzXWYUlIxCO8UOgug4iUS1CNAG4IK0XqsaLtIDiXg oce8pAj4X41TFEBsA9A9+4SZdyFBFVg54tYN3ArfL4D4e2bYJTMcHonvaySu8wx0fob7 1Mbciqkd8V20KC6Ivn8SJFXXGe4KHzj99vSXp9sutzJWD0dxafhXKMFx1SwCGW4ImFT9 ZpnkPSr+VmvguAWH5mvxG8PSYpMXXkR1IJcMd6eiGeT9UUZujzbgG5cR+ExRrZTengdr 8TSw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=u8z7K6AG; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-125701-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-125701-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id z2-20020a1709063ac200b00a45811c5fa8si2649463ejd.222.2024.03.30.04.32.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Mar 2024 04:32:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-125701-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=u8z7K6AG; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-125701-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-125701-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B2ECA1F223D8 for ; Sat, 30 Mar 2024 11:32:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2574B2C861; Sat, 30 Mar 2024 11:32:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="u8z7K6AG" Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D44C2C68A for ; Sat, 30 Mar 2024 11:32:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711798344; cv=none; b=lWgI7IjUVkNhMfn2eAdbiUsQCtW20zaFN2PHMMmxyntW0Y6jY9ZN8U0c3oJxqFEwA0XxtQJrpjf4pRydqVD5B3lRYm2fzUoPQOSNtu8xqNiJmcz1UMtlezw+AQaRChigvc5SMzphPKT2nzTU6T6iyYdaIxYxTbVYIuW6i5UFtI0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711798344; c=relaxed/simple; bh=SCB34xXRysolROT1e0/g2zjuIVTPAdaBlQmpSA/32G8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GVbi79UjZDQwipK85M/YxdVQGp89bXgelJCXpKS6UNxrJh3Mufow8BPZvfPCccIgbSYkVrtFuwjgyDNpjcMoWyR4KrsC6KnEctz1KD8unjgRSqrgN/+riHwWwU7smUyOQDaRdf1Ub68hH1liLNwkJ5Q2VnhHkcl0Ejn9K72M/WA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=u8z7K6AG; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-34100f4f9a2so1875503f8f.2 for ; Sat, 30 Mar 2024 04:32:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711798340; x=1712403140; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=ExUXrTD223tXybDLDyrKC0GoudjtX3ivRD1n/3oKum4=; b=u8z7K6AGI70CpD7ndxkx1htcBe3T11D54w5mFmkDmu5NZFBTNQiubBg7S/2U5t3pF0 9kW0hAuNiyGElujR5sWpftctHU+BfJKQZFiKES9FavJOuBVVp3Ywfg2oMCrTmgkRo0GZ eBBfO/9YkUI0TPIfeqN2anCm/e+DFZ1YNhDhMM7/LVj7Y7ZcRPSZI0uASVNqx6Vls2oa viR8qUug1POIP4fB0SmjX702t9lXHahVr6SO1YgxY+CLVncMCqd6UeXTMQjy5NlVPPQA qLwJIsQcIooiwBsvl7DlvR2h9mkvAou5hQITU9KANGbfAptuXfqCj5yrwfBfg2Xk7O89 OWGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711798340; x=1712403140; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ExUXrTD223tXybDLDyrKC0GoudjtX3ivRD1n/3oKum4=; b=OR1kpplqIk8DAX3QpEVBT3TlH9gpjOMsZ7gl9ycTf3XoV2Uf0sRrYpxKDdW6KvlgLP uD2y3Zixzt/itx9l4VUCVlljalwADuPj0Dc498PIIMO2tWmIlxAE+JwtutZLxr1sQzS+ gHqp69bEkwd71jlTxOFaIE9ID6pP3wIosg4ezeKJfWxrMuMFYVEtAccNJrfqV6yuTORr YZs5IaxsbRVwB89JajIgMSyoH7Lfp2z6+e9YdmfdoQss83RD66rJFULH8o7Z42ry0pEy UBVxreKe2e9IjMnbq/fSS1dgM+aD5cIr8TGNAEON3wtEeLqFwS5aig4nmOMZz/uIwtZb 7crw== X-Forwarded-Encrypted: i=1; AJvYcCVmmGO0vUggRtS1kIb27KMwh97uIVRv+SQEFFHG3PLV0Uz4YS+yGXPVTWhNqR8qyM1XA7rtWus59zN6jxbckXbcXWsZ+8BvRLouuyww X-Gm-Message-State: AOJu0YxlrUWS/A4mRr+QCP8cD6VIcQXqXUOfYLTkiGhcozHwjVIHM3Uy nPKfdFV+OqOTjKLyHUIUn6ufHODVwB/IZ5ulGmBwi6dE9uSclPr2rjSEy184cEktt++3VJV9qw2 F X-Received: by 2002:adf:ec84:0:b0:33e:d244:9c62 with SMTP id z4-20020adfec84000000b0033ed2449c62mr2515319wrn.68.1711798340511; Sat, 30 Mar 2024 04:32:20 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id s7-20020adfecc7000000b0033e239040d8sm6239107wro.84.2024.03.30.04.32.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Mar 2024 04:32:19 -0700 (PDT) Message-ID: <52f49ae7-e15a-4aaf-b66d-42895e8352de@linaro.org> Date: Sat, 30 Mar 2024 12:32:18 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] spi: cadence: Add new bindings documentation for Cadence XSPI To: Witold Sadowski , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org Cc: broonie@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, pthombar@cadence.com References: <20240329194849.25554-1-wsadowski@marvell.com> <20240329194849.25554-2-wsadowski@marvell.com> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240329194849.25554-2-wsadowski@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 29/03/2024 20:48, Witold Sadowski wrote: > Add new bindings: > - mrvl,xspi-nor compatible string > Compatible string to enable Marvell XSPI modification > - Multiple PHY configuration registers > - base for xfer register set > > Signed-off-by: Witold Sadowski Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. > --- > .../devicetree/bindings/spi/cdns,xspi.yaml | 84 ++++++++++++++++++- > 1 file changed, 83 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml > index eb0f92468185..d1fde8d4e9b8 100644 > --- a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml > +++ b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml > @@ -20,23 +20,74 @@ allOf: > > properties: > compatible: > - const: cdns,xspi-nor > + - const: cdns,xspi-nor > + - const: mrvl,xspi-nor It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. There is a lot of things happening here, but I won't perform review if the code was never tested. Sorry, please test before sending. Best regards, Krzysztof