Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp546981lqz; Sat, 30 Mar 2024 07:53:36 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUCYJ7Re5sqgFve7cnPgPducjABGsbGdlOvH8bUnTgSN8DlYBcILX9E/BXdD+upxomTP32/bqlyApbSFYWNXoWMK6E2NQbIcodOXEo32Q== X-Google-Smtp-Source: AGHT+IEK5lSQ4TvoHMLIlTlAha8TL0QHFcYxrCvzBdh0H07Otb4YU0V4+Pw7YeEou8WtCMx4+axw X-Received: by 2002:a50:c047:0:b0:568:c6a2:f411 with SMTP id u7-20020a50c047000000b00568c6a2f411mr3631012edd.32.1711810416299; Sat, 30 Mar 2024 07:53:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711810416; cv=pass; d=google.com; s=arc-20160816; b=lT5OJzC2NUX4OxnmwmoCKn+C/Wte0mhwgLVdHuzvCitLRyzb0kSZUihpOibcl5gqI8 igVoUJBC56HhpeSy3lWvVxDFD1qIWAYUYhV5lUZuxxgWdVUOPuYPb4m8iCe1zSV2eWLI Creb+6SvnYx0+koz5OszL/X+MAQOUkKZqvBTvSZ/4zKB+TpV62YqBFBMy3eR4Gd9+OM9 GIutpSzQVsfw+SsDF9KOjAXaDuMXB8SLVrnMpvk56Y7dlSaS3Ifykxdv0o2+dfIuKNOs Bad5SMlW34gvabwSkwx9dZuRmDPcnnXvzDastmHMXyBbZSdcz+gtF80mDdK2RQCMUY9w odwA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=caGVOX2RZ69c4hjscPFCuCKDrFK7z35V6qvgjgO6mvs=; fh=EIDyYCD643PSDPWJn1DAwzXG9uVAN9zutgG0ofe7kGI=; b=qwHGrwg9VAGn0JMnJjpGSDMeCdzIhj2Jxae4Jr1vzVpmxau/og2rJlgDAXkN+vqBGz fXRSw+OxTaKtYtkivYs7alzdI4BB/0NfDQi1dgCyr1njWpbNlf97UQKuedA7t0RYoGg2 QpKp7Z/f3Bt4ooqs0DLynvlaxwcExuEYfRPqImXsLqG4bnvZVvpJsg1iJnPuHU1fTfvU PT4Yd85V3AcEGclQyKNjkZInmixioNHM2PHuuaJ6+KAzdQZNqVrwIGfCSvg0jC6pHKQC oenkUyjcgfVS4HG7JknisOhybN6B49qxLk4x/B5GUn1BfjVIfUjgyvStuKFmgSNnizW+ gbQw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=AgKIFxWL; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-125749-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-125749-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id ek13-20020a056402370d00b0056c5395c966si2705889edb.216.2024.03.30.07.53.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Mar 2024 07:53:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-125749-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=AgKIFxWL; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-125749-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-125749-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B402C1F21E3B for ; Sat, 30 Mar 2024 14:53:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F2F0338DDB; Sat, 30 Mar 2024 14:53:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="AgKIFxWL" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD8311C0DEF; Sat, 30 Mar 2024 14:53:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711810403; cv=none; b=VrO6J8Hi+SBymX6+G5k3Ud8x7blzHf4q7Un8U6HDTfCcAzT4feZ1IAepX0YzqrNRbWaj6sVRlwcJW0hQh2XaqpefkR4Sl2gkocyv4v1p3KRon1liM9mPgLHk8XrtVDkI9/lTyxhV5mKiovFXgO/D2P2uamXtEBKUKCzDezwG5NM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711810403; c=relaxed/simple; bh=gJx0oB7ZzuoCNKkwsr1UzGLJ3CRfFELmHureG9uOYGw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oDelDfSdHTx21mIJ0hem715uqMg/JEbBvu+QI/n4j2Dk5mc8GbK+VtSdOJISO50a39BBZcXcTZecoAszKR55fvrHsgPXRjIkkmjNpNVTs/51Np0JtRcq77T52D8q+mY13M2OFNo9qBat6UJf/PFGufjBrguPYjOpPuK3LA1Ni/8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=AgKIFxWL; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=caGVOX2RZ69c4hjscPFCuCKDrFK7z35V6qvgjgO6mvs=; b=AgKIFxWLgU4PMlGPkeuWts4Sdx C1uk2GClcr5WI35QPJ/c+zppgblTWKdov5NwQ4Y/rlf4kRO+pXEefeYiuH/9vvqcMMhtsW5bKoOSc ptiP23T99yvkYQ4yFYT1LkW6GjFn1aaNnXMQ/2LbdTSWKkldN1777vtFbSTbTQ5A4V60=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rqa4f-00Bj1W-9i; Sat, 30 Mar 2024 15:52:49 +0100 Date: Sat, 30 Mar 2024 15:52:49 +0100 From: Andrew Lunn To: Kory Maincent Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Luis Chamberlain , Russ Weight , Greg Kroah-Hartman , "Rafael J. Wysocki" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Oleksij Rempel , Mark Brown , Frank Rowand , Heiner Kallweit , Russell King , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, Dent Project Subject: Re: [PATCH net-next v6 17/17] net: pse-pd: Add TI TPS23881 PSE controller driver Message-ID: <8186fea6-c1f4-403b-b717-83c1dd3ad826@lunn.ch> References: <20240326-feature_poe-v6-0-c1011b6ea1cb@bootlin.com> <20240326-feature_poe-v6-17-c1011b6ea1cb@bootlin.com> <6bbc6b86-3947-4679-ac0b-fde50129d0f6@lunn.ch> <20240329155657.7939ac4b@kmaincent-XPS-13-7390> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240329155657.7939ac4b@kmaincent-XPS-13-7390> On Fri, Mar 29, 2024 at 03:56:57PM +0100, Kory Maincent wrote: > On Thu, 28 Mar 2024 17:24:17 +0100 > Andrew Lunn wrote: > > > > +static int tps23881_flash_fw_part(struct i2c_client *client, > > > + const char *fw_name, > > > + const struct tps23881_fw_conf *fw_conf) > > > > Does the device actually have flash? Or is this just downloading to > > SRAM? > > It is downloading to SRAM. So maybe rename these functions. Andrew