Received-SPF: pass (google.com: domain of linux-kernel+bounces-125750-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sat, 30 Mar 2024 15:55:42 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Naveen Mamindlapalli <naveenm@marvell.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	Woojung Huh <woojung.huh@microchip.com>,
	Arun Ramadoss <arun.ramadoss@microchip.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
	David Ahern <dsahern@kernel.org>, Simon Horman <horms@kernel.org>,
	Willem de Bruijn <willemb@google.com>,
	=?iso-8859-1?Q?S=F8ren?= Andersen <san@skov.dk>
Subject: Re: [PATCH net-next v1 5/9] net: dsa: microchip: add support for
 different DCB app configurations
Message-ID: <4380faf1-9911-4188-9982-a7060e143394@lunn.ch>
References: <20240328160518.2396238-1-o.rempel@pengutronix.de>
 <20240328160518.2396238-6-o.rempel@pengutronix.de>
 <SJ2PR18MB56358EDD37EA961C7004CB27A23A2@SJ2PR18MB5635.namprd18.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <SJ2PR18MB56358EDD37EA961C7004CB27A23A2@SJ2PR18MB5635.namprd18.prod.outlook.com>

On Fri, Mar 29, 2024 at 09:29:32AM +0000, Naveen Mamindlapalli wrote:
> 
> > +int ksz_init_global_dscp_map(struct ksz_device *dev) {
> > +	int reg, per_reg, ret, dscp;
> > +	u8 data = 0;
> > +	u8 mask;
> > +
> > +	/* On KSZ9xxx variants, DSCP remapping is disabled by default.
> > +	 * Enable to have, predictable and reproducible behavior across
> > +	 * different devices.
> > +	 */
> > +	if (!is_ksz8(dev)) {
> > +		ret = ksz_rmw8(dev, KSZ9477_REG_SW_MAC_TOS_CTRL,
> > +			       KSZ9477_SW_TOS_DSCP_REMAP,
> > +			       KSZ9477_SW_TOS_DSCP_REMAP);
> > +		if (ret)
> > +			return ret;
> > +	}
> > +
> > +	ksz_get_dscp_prio_reg(dev, &reg, &per_reg, &mask);
> > +
> > +	for (dscp = 0; dscp < DSCP_MAX; dscp++) {
> > +		int ipv, shift;
> > +
> > +		/* Map DSCP to Traffic Type, which is corresponding to the
> > +		 * Internal Priority Value (IPV) in the switch.
> > +		 */
> > +		if (!is_ksz8(dev)) {
> > +			ipv = ietf_dscp_to_ieee8021q_tt(dscp);
> > +		} else {
> > +			ipv =
> > ieee8021q_tt_to_tc(ietf_dscp_to_ieee8021q_tt(dscp),
> > +						 dev->info->num_tx_queues);
> > +		}
> 
> No need for braces for single statement.

Please trim the email when replying. It is very easy to miss comments
when it is 99% quoted text with a couple of one-liners mixed in.

     Andrew