Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp614637lqz; Sat, 30 Mar 2024 10:42:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVUIDM8UKgQErKq1iuQtpTBUeOQXzNOLtea6bzFuNGZfoi09dETpLTVxqbRQZIEQWgozFM6mtGLqcuMSm9pL9HzXLKwy640v99SHBMt9A== X-Google-Smtp-Source: AGHT+IECY6+nYtaaGVQ4OdW7GpObwStYo8Ubg3YwE6has6SmhOoXGleus7ytO08xlmfgjlHaXqTC X-Received: by 2002:a50:d750:0:b0:566:f5d6:4b4 with SMTP id i16-20020a50d750000000b00566f5d604b4mr3264786edj.12.1711820547239; Sat, 30 Mar 2024 10:42:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711820547; cv=pass; d=google.com; s=arc-20160816; b=r8kPsescQg52eIarWDse2adVjdrkmf/iXIdomd62hjBAIu5olAh2dVwOnIatAjVpIP psi0iY9wZsuTN7V18mqSESUmH/CGiBxYSowIFBe4/Zm6lwoc9h27EcKTATPXO4q7aydB 3bDTngE224cdJLt6bYT5RHKJvT7SnKCNqnZRrU1XkAqABkdyyr4Si4XLJl2pUcAJsuO9 5D8KuFvdQpIq4K+WkoODBT7JXzbgndCLCdYcDoBDhlmm9UK5+oTMVYViE5fmBU4bp6xQ DYhg98nHQP8Z06p7R3imjI1ezi8etY++UMVsJVL3JGIU5HUfvZz6TuUQ0nCCwTePS1MC La5w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=lR35U1VOKNo+qXyf+JFRn0nMvSnOjECaN2wOLlcW09I=; fh=UHL4jEZwCxeMBBC3LuS7Twvz9V1QYVsYPUTufYQGG+U=; b=beInHvkC4H0tbIgeHYt5x6TJI+qhQZPcunkJd6KwQV2KS6jYjFF0IVJn3+X6SJcpmv d2hOcBbNvIIgqpDqP7oOMZcmjH4zqHTQpSOMyRTROReyzmbQMvs3RDUaR9xcpf958S7H CxLvnkOaYR5I/7lq6O+cUIwifAlxa6zMDZEh3YIf25HyV89mWO+OZDzfENNoyYwcgE5v ZA7ng51AJ+xkuUzV7Z+Vg6t//8nEWwZ+axmo8/4NW/3qtGiyPxXCltrRmU75j/5j6PfD EBpdO18xqyODnVVO5GS+dCaLFvVmLy4tGL5aNJrgza62CweYfmbPKchXwV9lbkauLMOa MMeQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="lhdU/+3Z"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-125795-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-125795-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id c2-20020a50d642000000b0056c36bb851esi3039305edj.314.2024.03.30.10.42.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Mar 2024 10:42:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-125795-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="lhdU/+3Z"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-125795-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-125795-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CA93B1F228DB for ; Sat, 30 Mar 2024 17:42:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BE50A3C6BA; Sat, 30 Mar 2024 17:42:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lhdU/+3Z" Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB8563BBC8 for ; Sat, 30 Mar 2024 17:42:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711820538; cv=none; b=mdupbM9NUU1xdvyfqrnTcdqjXou46MR4S7taxUP3tHKd3yDuhe5vgSiuY9GQK+z/itpYHUQ9CdbtERMIHCFDv5bDBq6MkenTTFwWmMiExkrDYIM7eFuvvEJQSKBACugdVYVdDGwCWsGsi1SE8xYZ7ik+LTMyjuIPw9w4h3W4eHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711820538; c=relaxed/simple; bh=Hen8PBpcINdNSOETmg/71zXMc6uXhIQgB0n1Ao46iQY=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=ookAq4/oq/bgXs35nYHVIHNeXahfuUmb53iasqDo1bKXIboA9KgegiIubbVdGBtfJ/SyCCdUQIXWoz7SIRY0a7jYO2HPy60KAj6DozMdefL0RwRYTc9b07Gnir4+/RveR9wYiVtRQN5LKt0+apNRgoeoJ0DwU+Ym3glCqMO/si0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lhdU/+3Z; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4155c1727ceso2159325e9.1 for ; Sat, 30 Mar 2024 10:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711820534; x=1712425334; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=lR35U1VOKNo+qXyf+JFRn0nMvSnOjECaN2wOLlcW09I=; b=lhdU/+3Z5fLCkB1uNOWamqWgQR4vB9b8+y6vMfYoIhgivIr50UqYKMttCIxiYMla0Q 4aIAOEux7a672dg8suhQAVjjV7Ls1LffGvgUOLfq+5uNziQHS3dxmc07tKbS8b2/UoZJ h0LTxslSXRoUA6QtC7syLYWIKZQzwgCOTwftwyn42A1oKxbp04SKvQ/ArWgW5K7NPmIn Wo/xvgnyNx0DtjZjhj0DNcN1s+Yw1IGhywavXt3bOXU8DSeELzJ252WX8QevtQbkom1w Gt3z2mveryqyZGzB9Z/EKNWgjh6RrbucKuuILn0w738ijLc1HQbx+tzckwyGQcEXUCuZ KZ2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711820534; x=1712425334; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lR35U1VOKNo+qXyf+JFRn0nMvSnOjECaN2wOLlcW09I=; b=vjFZi5F8BOBib7qPY7Tw9ibCTY7tbLaSNpJEn4AtVNeXai7vjbrdFjb6M3kOz84R57 1DbosrDkRVFnO0YOi44tIX1PXd2CAIubN7HGyhBT3aafEzK6Dq57MvNmRNHw/7LsjRQr gp7tk9WtIkbZMqqKQP1eMeIcOei2muFNVzpSRYHGjk3wd+PjCmZ6Sb3A1XBUkRoSddq+ 8ddbmpGsDxAnn6hJsUByR2ZmpF6FeGtMbDLeD5pd7jLMXA7axcNvdQuuprCGtWrTPDh/ lc+TTwSQVAR++AZoOlvzmeqb1oZbISHycx19cY+KakoysFDj+gO9zf4YoFKTpzrrBVcE TvCw== X-Forwarded-Encrypted: i=1; AJvYcCVFHM3C6souLMgEETBqnSaggPf0djM9qfmcEwry8/ph13QTUpf+BiUby/NEJjXQnibVuA40SMCqb3iWkyTagzz8va+4VWA37J89roRy X-Gm-Message-State: AOJu0Yynav2ilDigo5VsBUROgLTVv6gLLV1Hresis3vKYc4cHgtk5e71 P5tWglkoCoidaN8ozufLqIzgVvIahrvWH9KCC5EhU0Ry8cgOXF9DW0vyaE/yIrA= X-Received: by 2002:a05:600c:3502:b0:414:8e7:cd60 with SMTP id h2-20020a05600c350200b0041408e7cd60mr4238845wmq.8.1711820534042; Sat, 30 Mar 2024 10:42:14 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id u15-20020a05600c00cf00b00414041032casm8567709wmm.1.2024.03.30.10.42.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Mar 2024 10:42:13 -0700 (PDT) Message-ID: <261f2995-b279-48bc-b9d4-023a8a705857@linaro.org> Date: Sat, 30 Mar 2024 18:42:11 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/2] spi: dt-bindings: add Siflower Quad SPI controller To: Qingfang Deng , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Qingfang Deng , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240329015147.1481349-1-dqfext@gmail.com> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240329015147.1481349-1-dqfext@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 29/03/2024 02:51, Qingfang Deng wrote: > From: Qingfang Deng > > Add YAML devicetree bindings for Siflower Quad SPI controller. Describe the hardware. What is this Siflower? > > Signed-off-by: Qingfang Deng > --- > .../bindings/spi/siflower,qspi.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/siflower,qspi.yaml > > diff --git a/Documentation/devicetree/bindings/spi/siflower,qspi.yaml b/Documentation/devicetree/bindings/spi/siflower,qspi.yaml > new file mode 100644 > index 000000000000..c2dbe82affc2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/siflower,qspi.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/siflower,qspi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Siflower Quad Serial Peripheral Interface (QSPI) > + > +maintainers: > + - Qingfang Deng > + > +allOf: > + - $ref: spi-controller.yaml# > + > +properties: > + compatible: > + const: siflower,qspi Except that this was not tested, aren't you adding it for some SoC? If so, then you miss here SoC part. Best regards, Krzysztof