Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp708321lqz; Sat, 30 Mar 2024 16:01:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUGqpwcqc7lat6TnvTQfk4Ya/c6Qelp/JnfBEAaCjMzE01nmOX/OAuXsQs28UmGGWyH10eod/ptNUC8uTkXakoFRGbvFDk4AtpY5N2TYw== X-Google-Smtp-Source: AGHT+IGa9AsHMlnrj1Zkq44Mc4pqm7c+7OmefqwEhcMODamLTCbrQA99bCtDQlWV6acIU30OI+Qo X-Received: by 2002:ac2:4293:0:b0:515:d517:dd62 with SMTP id m19-20020ac24293000000b00515d517dd62mr1906960lfh.9.1711839712000; Sat, 30 Mar 2024 16:01:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711839711; cv=pass; d=google.com; s=arc-20160816; b=I2fPKWZSN79UkeTxlV2EDfxCKFaK8bLqxLhav3pWBAtDHQqz48g/yxehDmcL8F8rds KDqyC5toXwnCVOVrZVt9dNuHB6HbdFM91PskC5+RpwgPG1BV7SABvBhA3rsEnqDHAWj2 MmXFT1rmrjjSRmu2/boCKUEruWQyPL4bWAtvw/eDtVFr32o5kEUGXwKTEgBkw8jIpvti b4u7MSCadaTKMGwXkljlyn5KRiGYIAKtHqxT8WIZ94LHlDubnSX0akySEq3PzAleRYCE LAEMjDBoVhk4qj3OJGHJwjr3eEB5rWXvsbIKECeyOGKr2PI63bVEMRWqaZJ/k7hcuP76 JFtA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from; bh=iBbwReDST2KucJmPPk4RCGGZjZ1RgAhjVGr3Qkxgpsw=; fh=ULPVIfA27JkIPO05pwNRNOUBDY+hEmL5HX4HYTblS8g=; b=HjtWgHtIIvh+feMqniN3FtLuiHU+W2rNV7FBPGZ42xLzluIgGEmhE9H2nr/8Omvy0B nFAIIU1Y9RtWnx5GLZXvKxsV6vuDphxnS8qiS30BO7WqD/kQIKyY5OpkfGb4TN/+cM+M oJEeZwiNMoHIdxDawNJAHOcvPYioFEenull4ERSJZkhvqtX4IYJGUqt1useCt1hR52eY QD1xOViv3c2XprYdrjj+TA9wJIugrmkxquys3ktax1gN0TbGzadl0uqspAKIwGgivNPk XbC+A+/aNO3QPOEDGieLoUsXtHQlLpfQ6QXUxJCh4X0XnheZABgnnIrEpOsPMhyrVs5r o1og==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-125906-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-125906-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id g5-20020a170906594500b00a4e30aeb125si2173392ejr.558.2024.03.30.16.01.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Mar 2024 16:01:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-125906-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-125906-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-125906-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B36E11F21B65 for ; Sat, 30 Mar 2024 23:01:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 854484D11D; Sat, 30 Mar 2024 23:01:43 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ABC742AA0; Sat, 30 Mar 2024 23:01:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711839703; cv=none; b=mNZeKHIJISYF0qfhDypFumDWJ4iiACaPMl+3H7nzNTE/JeJ54Z5jBjRdzjcCWap4dpt1cEI1WQQ16H3fZbI2I88Sz/ZC30NuRZooGODn31G3048hYchvp3IP+fsBvICg61nnO5N/acUnR0SumInw7nqWdylBXFYjLiWRxZC+UVQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711839703; c=relaxed/simple; bh=s2fZIERPWen68T7ai0Hbcm9HxnhK2N1NdJbuq3jQgm0=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=a7M5UJgkz9CGZA/Vr2hDTdu6L/VIyzs7xqMWxGy+1/OYz3qH3JP7iRcsz31bw1P3GsP0NhkWd8YPRfD4b/fLoXudEEF32XBqom59lnNLxNpsJ9L1FxkT0I7LkEM2g3ne/go9OnpOANJkPq4rnmJZWeSzZ6JpENdOd/BHwJo+A/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B2C3C433C7; Sat, 30 Mar 2024 23:01:42 +0000 (UTC) Received: by mercury (Postfix, from userid 1000) id B7FE310608D9; Sun, 31 Mar 2024 00:01:39 +0100 (CET) From: Sebastian Reichel To: Sebastian Reichel , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Hans de Goede In-Reply-To: <20240329-power-supply-simplify-v1-1-416f1002739f@weissschuh.net> References: <20240329-power-supply-simplify-v1-1-416f1002739f@weissschuh.net> Subject: Re: [PATCH] power: supply: core: simplify charge_behaviour formatting Message-Id: <171183969971.480547.16599196216072730255.b4-ty@collabora.com> Date: Sun, 31 Mar 2024 00:01:39 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.13.0 On Fri, 29 Mar 2024 09:18:29 +0100, Thomas Weißschuh wrote: > The function power_supply_show_charge_behaviour() is not needed and can > be removed completely. > Removing the function also saves a spurious read of the property from > the driver on each call. > > The convulted logic was a leftover from an earlier patch revision. > Some restructuring made this cleanup possible. > > [...] Applied, thanks! [1/1] power: supply: core: simplify charge_behaviour formatting commit: 91b623cda43e449a49177ba99b6723f551a4bfbe Best regards, -- Sebastian Reichel