Received-SPF: pass (google.com: domain of linux-kernel+bounces-126097-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <dbe8ea1a6a3b599a00eeb8ba0254fde785a500b9.camel@perches.com>
Subject: Re: [PATCH v4 2/2] scripts: checkpatch: check unused parameters for
 function-like macro
From: Joe Perches <joe@perches.com>
To: Mac Xu <mac.xxn@outlook.com>, Barry Song <21cnbao@gmail.com>, 
	"akpm@linux-foundation.org"
	 <akpm@linux-foundation.org>, "linux-doc@vger.kernel.org"
	 <linux-doc@vger.kernel.org>
Cc: "apw@canonical.com" <apw@canonical.com>, "broonie@kernel.org"
 <broonie@kernel.org>, "chenhuacai@loongson.cn" <chenhuacai@loongson.cn>, 
 "chris@zankel.net" <chris@zankel.net>, "corbet@lwn.net" <corbet@lwn.net>, 
 "dwaipayanray1@gmail.com" <dwaipayanray1@gmail.com>,
 "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "linux@roeck-us.net" <linux@roeck-us.net>,  "lukas.bulwahn@gmail.com"
 <lukas.bulwahn@gmail.com>, "sfr@canb.auug.org.au" <sfr@canb.auug.org.au>, 
 "v-songbaohua@oppo.com" <v-songbaohua@oppo.com>,
 "workflows@vger.kernel.org" <workflows@vger.kernel.org>,  Max Filippov
 <jcmvbkbc@gmail.com>
Date: Sun, 31 Mar 2024 08:54:00 -0700
In-Reply-To: <MN0PR20MB4717810B82175CC594A9F285F3382@MN0PR20MB4717.namprd20.prod.outlook.com>
References: <20240328022136.5789-1-21cnbao@gmail.com>
	 <20240328022136.5789-3-21cnbao@gmail.com>
	 <ef2c96e40bcf777535c9ff2405e4dc5b3138b27e.camel@perches.com>
	 <MN0PR20MB4717810B82175CC594A9F285F3382@MN0PR20MB4717.namprd20.prod.outlook.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Sun, 2024-03-31 at 13:46 +0000, Mac Xu wrote:
> > On Thu, 2024-03-28 at 15:21 +1300, Barry Song wrote:
> > > From: Xining Xu <mac.xxn@outlook.com>
> > >=20
> > > If function-like macros do not utilize a parameter, it might result i=
n a
> > > build warning.  In our coding style guidelines, we advocate for utili=
zing
> > > static inline functions to replace such macros.  This patch verifies
> > > compliance with the new rule.
> > []
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>=20
[]
> > It seems this logic is a bit redundant to existing
> > code and might be better added in the block that starts
> >=20
> > (line 6026)
> > # check if any macro arguments are reused (ignore '...' and 'type')
> >=20
> > as that already does each param in a #define and
> > ignores ... and type
>=20
> Hi Joe,
>=20
> Thank you for your comments with insights, as you said, code block of lin=
e 6026 is a better place to=20
> place this new logic, as it already handles the logic I'd wanted like ext=
racting, splitting and trimming=20
> the arguments, excluding the trailing comments etc.
>=20
> By placing the logic in the new place, code duplicates are reduced.
>=20
> Here's my new code (inserted from line 6044):
> +# check if this is an unused argument
> +        if ($define_stmt !~ /\b$arg\b/) {
> +                WARN("UNUSED_ARG_IN_MACRO",

Perhaps
					WARN("MACRO_ARG_UNUSED",
			...

to better match the others above it in the block:

					CHK("MACRO_ARG_REUSE",
and
					CHK("MACRO_ARG_PRECEDENCE",

Other than that trivial bit, seems ok.