Received-SPF: pass (google.com: domain of linux-kernel+bounces-126098-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Sun, 31 Mar 2024 23:53:12 +0800
From: Yujie Liu <yujie.liu@intel.com>
To: "Paul E. McKenney" <paulmck@kernel.org>
CC: kernel test robot <lkp@intel.com>, <oe-kbuild-all@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [paulmck-rcu:dev.2024.03.27b 64/69]
 arch/xtensa/include/asm/cmpxchg.h:77:25: error: implicit declaration of
 function 'cmpxchg_emu_u8'
Message-ID: <ZgmG6BR6TtejfQcC@yujie-X299>
References: <202403292321.T55etywH-lkp@intel.com>
 <0303151f-c12e-4350-804a-11e3b734df91@paulmck-laptop>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <0303151f-c12e-4350-804a-11e3b734df91@paulmck-laptop>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?j+zWunrOjWW0diaC7z7xokloZ6vLh+xSMPr1sWkZHaPDofISB5W9udjFJ9H7?=
 =?us-ascii?Q?vBQTrbD5XLgkF54WUNE8EH6d7uI9A5dUcAcSr7RpoAo3M1GxHtldz40vCW9N?=
 =?us-ascii?Q?T5XHMF8gkhfaX/2Ye0node+MOMlaz4T40cM3Jgd9Q1PPOmEX4cEu3ednYF0F?=
 =?us-ascii?Q?SyoDN3bMFgAGfEZmhDEbiS9aFCtFwTr7IyphA2oxtkWF4LKgZizLCk1Ppj2T?=
 =?us-ascii?Q?b5J3YKl0Q0rtMLR3k5ybq3US42UJCCZ6Py8YG2l6IWPga9roTJPvvNr6MQFO?=
 =?us-ascii?Q?qoXflJGtqBy7jCrkOaYSe8r57TgYvM+GwTw4DhhyBY2RZeTPyIrud76l5BOy?=
 =?us-ascii?Q?a7zkKnZI9a/B9nzlPIaDhJerIGQ4BMlA8wIj2QElNrjoonPotQMBDWyh0eJh?=
 =?us-ascii?Q?zRomchNoQRUh9j9hXEPuEkmhTbFGRbtNCT27C7aNHsyJqUSCXwd3NpzyYRyK?=
 =?us-ascii?Q?EjRsGAgiNdJcB+s08ghzFaa3flKQ/WR5+tsHPHV2agFriw3gEo6hsRAXV7tu?=
 =?us-ascii?Q?bcz4g0OE+3E53fZvyrkGZHwxfROsBj0VIPm2Fwt1l5jWv7MhCTZUWdLYTPZ6?=
 =?us-ascii?Q?ahmRFjZf867zMo2V3z8z+Z0gKYfKguGKen7sWIbyjFhMwhikmecCY7/iUnjR?=
 =?us-ascii?Q?sHBf7n6pTtohFTc25fqpERzK/OilRlGuqzObLNkwVlfVVm/esymaSh/I1dxO?=
 =?us-ascii?Q?cEg623Tnc0j5fxuLinOjGopLKDMHYNPTBqUNGvWKgTOcQBbTcG8KPSSFhcnW?=
 =?us-ascii?Q?IUFKL1LBaX7Svn/t9T/QwBbEkzvcEiJcdl12VkXn7I4oPVrC9hyRuuk8Da+l?=
 =?us-ascii?Q?cod2AKGK8FtOjDrqnbN9Qx8Q9lZJw2Eq6b8QuVrEKgEAnftbA5BZNlmdxKJ9?=
 =?us-ascii?Q?6CaNRvV8+I48tF//cUyBkYa4K4H5+48p/pJEfPQOehCFQHns5sOe/FiQ5q34?=
 =?us-ascii?Q?NcyIJHWGIi/KdBMuRlLu/LN9H8M0FAwuuHKX4mE1TzyHetYnIBN7q1kOeNgG?=
 =?us-ascii?Q?cpAM7oYEwChASCpCcmIAasjnPXrsYhP0Ofb+Ff74vdsalgVm8W4kFoQpb6R1?=
 =?us-ascii?Q?BMg7n8LVC+vP9hsGBXfzV/g84yPPFB95zt8LDTLKd8zyD17jEsI8kY7r6ls2?=
 =?us-ascii?Q?gqQTbxBgmyuYaxM/H5M60pgc58AiSCmWUNbnpxgKSxRlPEwxG6h+IBMZ0DlB?=
 =?us-ascii?Q?zJsmhSVWPKPPcvwBAHNrFtuKjIUGn2LHX7bsEnRvNRyBe4y4+NoNNW1t2YvX?=
 =?us-ascii?Q?0N+HH1PdKOrFBKDGHSRvmVLUeRiTGQlYYTCXUY6u7cM1T8l7lpEsnwKD0aQZ?=
 =?us-ascii?Q?b87qDQ4dA/zwnpkQCgY0OQ9dCMK0tfPLCRgSFOMOHtjsg2nQlUzvWOz7Gn0E?=
 =?us-ascii?Q?jU6C16G5m6zZUhnq4ewWukhHdqy7ydfDJyEBkY0mB53oY841R1dcx8MRFT0w?=
 =?us-ascii?Q?uP0kJSujZyNM2b8YF3Ltc/ho17CEUaqbxVHqPtoP5+ccuNn4QXu/34VwD87n?=
 =?us-ascii?Q?IohPlMqOh5Npfd8RfMnHgkd0Jfc7oaEP8CbntiwaGFkRGoITypfGPfBYbwO0?=
 =?us-ascii?Q?hbqFBsn83vI3DPZDelmZ0JZrxy7eOxiAzXATRcUZ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a004cdd-acec-413e-105c-08dc519b9982
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2024 15:59:52.0947
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3GxpdaDxVorGvrLWFyvJOsd8Y8n1Xt817xox0H6jMItY0IO1IMz0Gt6flgyMDaABOEPSfIzcn0GJtCFqdBMJdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4677
X-OriginatorOrg: intel.com

On Fri, Mar 29, 2024 at 11:48:37AM -0700, Paul E. McKenney wrote:
> On Fri, Mar 29, 2024 at 11:08:04PM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2024.03.27b
> > head:   786fab3085d764055a78edb54023420920344333
> > commit: b3b1a154281fc97efc4c1d5818a83c29c228dbd5 [64/69] xtensa: Emulate one-byte and two-byte cmpxchg
> > config: xtensa-allnoconfig (https://download.01.org/0day-ci/archive/20240329/202403292321.T55etywH-lkp@intel.com/config)
> > compiler: xtensa-linux-gcc (GCC) 13.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240329/202403292321.T55etywH-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202403292321.T55etywH-lkp@intel.com/
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    In file included from arch/xtensa/include/asm/atomic.h:19,
> >                     from include/linux/atomic.h:7,
> >                     from include/asm-generic/bitops/atomic.h:5,
> >                     from arch/xtensa/include/asm/bitops.h:192,
> >                     from include/linux/bitops.h:68,
> >                     from include/linux/log2.h:12,
> >                     from kernel/bounds.c:13:
> >    arch/xtensa/include/asm/cmpxchg.h: In function '__cmpxchg':
> > >> arch/xtensa/include/asm/cmpxchg.h:77:25: error: implicit declaration of function 'cmpxchg_emu_u8' [-Werror=implicit-function-declaration]
> >       77 |         case 1:  return cmpxchg_emu_u8((volatile u8 *)ptr, old, new);
> >          |                         ^~~~~~~~~~~~~~
> 
> Good catch!  Does the diff at the end fix this?

The error is fixed by the diff at the end.

Tested-by: Yujie Liu <yujie.liu@intel.com>

> 
> 							Thanx, Paul
> 
> > >> arch/xtensa/include/asm/cmpxchg.h:78:25: error: implicit declaration of function 'cmpxchg_emu_u16' [-Werror=implicit-function-declaration]
> >       78 |         case 2:  return cmpxchg_emu_u16((volatile u16 *)ptr, old, new);
> >          |                         ^~~~~~~~~~~~~~~
> >    cc1: some warnings being treated as errors
> >    make[3]: *** [scripts/Makefile.build:117: kernel/bounds.s] Error 1
> >    make[3]: Target 'prepare' not remade because of errors.
> >    make[2]: *** [Makefile:1197: prepare0] Error 2
> >    make[2]: Target 'prepare' not remade because of errors.
> >    make[1]: *** [Makefile:240: __sub-make] Error 2
> >    make[1]: Target 'prepare' not remade because of errors.
> >    make: *** [Makefile:240: __sub-make] Error 2
> >    make: Target 'prepare' not remade because of errors.
> > 
> > 
> > vim +/cmpxchg_emu_u8 +77 arch/xtensa/include/asm/cmpxchg.h
> > 
> >     72	
> >     73	static __inline__ unsigned long
> >     74	__cmpxchg(volatile void *ptr, unsigned long old, unsigned long new, int size)
> >     75	{
> >     76		switch (size) {
> >   > 77		case 1:  return cmpxchg_emu_u8((volatile u8 *)ptr, old, new);
> >   > 78		case 2:  return cmpxchg_emu_u16((volatile u16 *)ptr, old, new);
> >     79		case 4:  return __cmpxchg_u32(ptr, old, new);
> >     80		default: __cmpxchg_called_with_bad_pointer();
> >     81			 return old;
> >     82		}
> >     83	}
> >     84	
> > 
> > -- 
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
> 
> commit 663161aaa5c3286dcfc9ba2cd9e12170f9354ea7
> Author: Paul E. McKenney <paulmck@kernel.org>
> Date:   Fri Mar 29 11:47:13 2024 -0700
> 
>     squash! xtensa: Emulate one-byte and two-byte cmpxchg
>     
>     [ paulmck: Apply kernel test robot feedback. ]
>     
>     Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> 
> diff --git a/arch/xtensa/include/asm/cmpxchg.h b/arch/xtensa/include/asm/cmpxchg.h
> index bcce915a98e21..a0f9a2070209b 100644
> --- a/arch/xtensa/include/asm/cmpxchg.h
> +++ b/arch/xtensa/include/asm/cmpxchg.h
> @@ -15,6 +15,7 @@
>  
>  #include <linux/bits.h>
>  #include <linux/stringify.h>
> +#include <linux/cmpxchg-emu.h>
>  
>  /*
>   * cmpxchg
>