Received-SPF: pass (google.com: domain of linux-kernel+bounces-126134-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 1 Apr 2024 00:06:26 +0800
From: Yujie Liu <yujie.liu@intel.com>
To: "Paul E. McKenney" <paulmck@kernel.org>
CC: kernel test robot <lkp@intel.com>, <oe-kbuild-all@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [paulmck-rcu:dev.2024.03.27b 61/69] lib/cmpxchg-emu.c:24:11:
 warning: no previous prototype for 'cmpxchg_emu_u8'
Message-ID: <ZgmKAil/a3+av1E8@yujie-X299>
References: <202403300508.Xz7XNp71-lkp@intel.com>
 <e4b7ecac-719e-40f5-80b5-7a1c63e72b33@paulmck-laptop>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <e4b7ecac-719e-40f5-80b5-7a1c63e72b33@paulmck-laptop>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FroNJKV8UMkTe25UWjEwx/t8Egvz5clnrR1Yea4I59atea41nkYa1xDt/L/0?=
 =?us-ascii?Q?Qrvlo9BhHZtCs7Rpz5Z/xzaWR5ModuXDMSEpnsVYLkLzbHVUA+ozXxnc4cXs?=
 =?us-ascii?Q?S1SB4f+WjrQGeW388I/P0rx/HpYXoHOqIqBI89urRjuUC0/r7wkv4gbzPi5X?=
 =?us-ascii?Q?voC7myyoJImv+RcyPLOKchaynMjokHmVlhH4Lcv37G0zJcCyc7uQyDvyh7MZ?=
 =?us-ascii?Q?y8fPWNwWU61NTRWFZU4cP/eAhADTk7IG5GH/F92/8YIj0fAjw5vr6eOV+9Vk?=
 =?us-ascii?Q?YQUldObzRQqIlucWDOzN8Bdzy9c1ABNyyS+CZ1bB2W54lglv3rmVJiwwxz5H?=
 =?us-ascii?Q?mYNXr7GpaL0kNn3q/xji9kVdVAEH3Sulug4H0Ge3jzXX3ex24O0r0Rl2gfP2?=
 =?us-ascii?Q?u+r0C2oaketCMvNVTfwxnKCGfyM3ZgEIuXgJc9npiIfauFma3fu5sJRprI4d?=
 =?us-ascii?Q?ML6DBKWkvDYl6yAfXEb/UgQO64y5YxFzHmCg3tylh6sLd6vCUfJtSBdKidbL?=
 =?us-ascii?Q?zLyqC7eXe6WHyUEMmrUZ/sB4c72C0AAqsL1Mm4pqh/OD+swZYZoj82kltnI9?=
 =?us-ascii?Q?YMRMeC8o95fc8qzlTWTxsEUCSF43uJ5JzM8TMwVJdTwLeM8d8Y2kivVujNW0?=
 =?us-ascii?Q?rlcwza00tfPJB3ECjjuAL1j+N3gi4/NNy7ad9Oo5aSry7VfyUVpTjKNYk5EE?=
 =?us-ascii?Q?SCz9QoGE9Jmz5BNbGbf3n5To8gPzGxYToxXXIctrL3hnBPvhBGQHs1xKWzbY?=
 =?us-ascii?Q?3C+4Nw8AUyQPHl3L2clENBHgxOI7gvkBJZdmLc0PXCaCa6sNyLhBdkMmYI9V?=
 =?us-ascii?Q?rjQ6MmSM8j+7AAk+obij/uJoXmkjhaeMHID2hPz8zR/UGd6p0uGr+Xp+dNAf?=
 =?us-ascii?Q?KUAAIp5sy9+IqqRDRoQWWktFmiBYCSEIyn6pjQcDNwIiLFqCT7XqDtsH9Lhj?=
 =?us-ascii?Q?ofALF3VUjFDTtjQn781O4Xf/RItsxbTrL7kma/cvQ0iKzF0Y+rAALoOCFKS9?=
 =?us-ascii?Q?IDqr8MMicPA5ZSPcFlr/+TJg1fctIsZrmi778EqSylhz92yV//5Jdu53h7YK?=
 =?us-ascii?Q?zIBH4+IV6Gi8Fomc3hQVl0LW/u67h44qFLkZBanYqc82PSNUx1jVHPqdXeGp?=
 =?us-ascii?Q?sFfWz0z/o8NxFnG3TQhP99E9nGP+yEK/cqSRPfGo2totOM7gDNfb4CcpgB9J?=
 =?us-ascii?Q?yG554z/ElGPvKcgQZv8Ee68Irhh6eSoauVv3V5uhnbpIFasyKNprneyKz/Mz?=
 =?us-ascii?Q?tXLFT1GNdh9j6b78s8Qn8WyhJaAtPxOWgPd3zUbR+CoktfLeV8v01Ib8qsJW?=
 =?us-ascii?Q?qHWtb5dL7WkcN1XM5rkrFJKyYlULYBoNqG7XibBma2jXzVHdelHCMTpiXfry?=
 =?us-ascii?Q?vwOgYem6pyz892gvbTpF7+TPQ6R4U/ykzgmxgCeDNGINdJYP3qtEJYKhs17D?=
 =?us-ascii?Q?4igYCuLt/s6kDja9SaNcH1kifR0Ys2ikgjWPctUB/Gm0Lnm2Cj+N3SfRkxqk?=
 =?us-ascii?Q?HvpeuSvTVFquwDG6w2/8k7rGrCZlFdzrKg9JoRFn84LxAgFOo/5qO2Pj4wrY?=
 =?us-ascii?Q?7AQUmJhc8Byhko/gMh5gnn3lWODncIiZwihLqNgi?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 56eedc98-eb07-446a-5211-08dc519d7332
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2024 16:13:06.5866
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PzsVzvsKxMXqfe+W0VXw3pRJ4noXqpPNU/2Dy4fV6yCK/iBoTKuRo5pMvuiyDn40qVglG2gf58QomQaIDLqAxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8476
X-OriginatorOrg: intel.com

On Fri, Mar 29, 2024 at 04:08:10PM -0700, Paul E. McKenney wrote:
> On Sat, Mar 30, 2024 at 05:26:12AM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2024.03.27b
> > head:   786fab3085d764055a78edb54023420920344333
> > commit: b48ffed4c636b96d2be7a93806870772ce34961f [61/69] csky: Emulate one-byte and two-byte cmpxchg
> > config: csky-allnoconfig (https://download.01.org/0day-ci/archive/20240330/202403300508.Xz7XNp71-lkp@intel.com/config)
> > compiler: csky-linux-gcc (GCC) 13.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240330/202403300508.Xz7XNp71-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202403300508.Xz7XNp71-lkp@intel.com/
> > 
> > All warnings (new ones prefixed by >>):
> > 
> > >> lib/cmpxchg-emu.c:24:11: warning: no previous prototype for 'cmpxchg_emu_u8' [-Wmissing-prototypes]
> >       24 | uintptr_t cmpxchg_emu_u8(volatile u8 *p, uintptr_t old, uintptr_t new)
> >          |           ^~~~~~~~~~~~~~
> > >> lib/cmpxchg-emu.c:51:11: warning: no previous prototype for 'cmpxchg_emu_u16' [-Wmissing-prototypes]
> >       51 | uintptr_t cmpxchg_emu_u16(volatile u16 *p, uintptr_t old, uintptr_t new)
> >          |           ^~~~~~~~~~~~~~~
> 
> Again, good catch, and thank you for the testing!  Does the patch at the
> end of this email fix things for you?

The warning is fixed by the patch at the end of the mail.

Tested-by: Yujie Liu <yujie.liu@intel.com>

> 
> 							Thanx, Paul
> 
> > vim +/cmpxchg_emu_u8 +24 lib/cmpxchg-emu.c
> > 
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  22  
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  23  /* Emulate one-byte cmpxchg() in terms of 4-byte cmpxchg. */
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17 @24  uintptr_t cmpxchg_emu_u8(volatile u8 *p, uintptr_t old, uintptr_t new)
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  25  {
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  26  	u32 *p32 = (u32 *)(((uintptr_t)p) & ~0x3);
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  27  	int i = ((uintptr_t)p) & 0x3;
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  28  	union u8_32 old32;
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  29  	union u8_32 new32;
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  30  	u32 ret;
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  31  
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  32  	old32.w = READ_ONCE(*p32);
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  33  	do {
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  34  		if (old32.b[i] != old)
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  35  			return old32.b[i];
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  36  		new32.w = old32.w;
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  37  		new32.b[i] = new;
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  38  		instrument_atomic_read_write(p, 1);
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  39  		ret = data_race(cmpxchg(p32, old32.w, new32.w));
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  40  	} while (ret != old32.w);
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  41  	return old;
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  42  }
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  43  EXPORT_SYMBOL_GPL(cmpxchg_emu_u8);
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  44  
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  45  union u16_32 {
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  46  	u16 h[2];
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  47  	u32 w;
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  48  };
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  49  
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17  50  /* Emulate two-byte cmpxchg() in terms of 4-byte cmpxchg. */
> > 0bbce967f3ecfc Paul E. McKenney 2024-03-17 @51  uintptr_t cmpxchg_emu_u16(volatile u16 *p, uintptr_t old, uintptr_t new)
> > 
> > :::::: The code at line 24 was first introduced by commit
> > :::::: 0bbce967f3ecfc6da1e7e8756b0d398e791b8dee lib: Add one-byte and two-byte cmpxchg() emulation functions
> > 
> > :::::: TO: Paul E. McKenney <paulmck@kernel.org>
> > :::::: CC: Paul E. McKenney <paulmck@kernel.org>
> > 
> > -- 
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
> 
> commit a326496eb88936b291adea830c2e59e74ca1d373
> Author: Paul E. McKenney <paulmck@kernel.org>
> Date:   Fri Mar 29 16:06:45 2024 -0700
> 
>     squash! lib: Add one-byte and two-byte cmpxchg() emulation functions
>     
>     [ paulmck: Apply kernel test robot feedback. ]
>     
>     Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> 
> diff --git a/lib/cmpxchg-emu.c b/lib/cmpxchg-emu.c
> index abdd451767220..a88c4f3c88430 100644
> --- a/lib/cmpxchg-emu.c
> +++ b/lib/cmpxchg-emu.c
> @@ -14,6 +14,7 @@
>  #include <linux/panic.h>
>  #include <linux/bug.h>
>  #include <asm-generic/rwonce.h>
> +#include <linux/cmpxchg-emu.h>
>  
>  union u8_32 {
>  	u8 b[4];
>