Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp1054960lqz; Sun, 31 Mar 2024 11:23:20 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVwJZUUBSZPxzeZE0ObTs1WmiPVYh1Dzo9ORrxLliZ9A11D96KhjHHreVaYMKT4VWvahCuov3JtRPoZYEdOtMs0xdjUPPMVyGsWML3NVA== X-Google-Smtp-Source: AGHT+IHRrQ1gOtVPv4amdJT/t+dMnqr8Tu3RlplXOl8+6XfbqvAcjtVhoPJJtT41+WCSKzZGAt/F X-Received: by 2002:ac2:5a5a:0:b0:515:a62a:8e3d with SMTP id r26-20020ac25a5a000000b00515a62a8e3dmr4424347lfn.11.1711909400777; Sun, 31 Mar 2024 11:23:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711909400; cv=pass; d=google.com; s=arc-20160816; b=ToZJSvqUcfYy1epIrtuz+ijbdQArrPt7cVr9STqnLw/2YB154VQoJkUzZ1MvACghcl MLA6NWU1L5oALSBG/I9ACHBjd/1viwknTC0r2NhM4uVudKdC3ldNMFBvlIEN9jez8ogA wz285k/R/VfULTlkqHL6TMYrLrOcbzyoQGkVVPrpPZKGbBXC2q0tfjSWZe0TgS3g6J2v gTwjnKDoM4eJvf0+OKuoOUID4TTV3EXoKw2PVQ3EZSU67sUf37EPHU/fDEzAdBpylYmS ENgN7ppfMm5wp/5DnhbdpbLWDAgbNHPKgvJMFeXoyjIDBdPnD57XjE1rh9gw218GYof3 se2g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:dkim-signature:message-id; bh=z7wRlXzH8Qg7MRMYfnkHVzDjrc+zYR1Im/3e5jSkqlo=; fh=m7iNMX5XTfvCpA5moibkq1i3j1vIwr/4L+XiIGx77ho=; b=cxO54TlsWQxaRrDVfIwvbEf7uusIUx+cfG6gjTXLtOd4yk34Zw4COHzQFu2ASc27uz fITiIOrTekVSKmVbg9Yz/JPnNCD0uLT9LI824iXllw2kNWiSqY38K65akgrEgiVZ5+XV bbrhtsyviRw7kGhVp/QHuT+xPpvZ/Ai1sOcMfM4+USZEqgSXveC6MZpaul+O65U76xF9 xlQw50BSy07k4A/+f1/c7YHcZKzhdY4HH96WPzmgFKR+j4PKudmyhvkqvO8qoE7pMDoX AG4q1GMZBjr8Z4P3dIXwOxxZ36QupD4Y+N5wBbyrXw5obwSQKT/lOuTrqYgHoX1HQZEE AMqQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kl.wtf header.s=key1 header.b=aUurXb28; arc=pass (i=1 spf=pass spfdomain=kl.wtf dkim=pass dkdomain=kl.wtf dmarc=pass fromdomain=kl.wtf); spf=pass (google.com: domain of linux-kernel+bounces-126346-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-126346-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=kl.wtf Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id q1-20020a056402248100b0056c53db1006si3643396eda.67.2024.03.31.11.23.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 Mar 2024 11:23:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-126346-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kl.wtf header.s=key1 header.b=aUurXb28; arc=pass (i=1 spf=pass spfdomain=kl.wtf dkim=pass dkdomain=kl.wtf dmarc=pass fromdomain=kl.wtf); spf=pass (google.com: domain of linux-kernel+bounces-126346-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-126346-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=kl.wtf Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 7C4F61F23DC4 for ; Sun, 31 Mar 2024 18:23:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 578B4145B2C; Sun, 31 Mar 2024 18:23:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kl.wtf header.i=@kl.wtf header.b="aUurXb28" Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 199DD145350 for ; Sun, 31 Mar 2024 18:23:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711909392; cv=none; b=I0hUgOGMGJeGqWsL1cGqX2WrLO7vR6iD3DdtJZwnXAZvhQ5PD2jmLKC4m+1JAcPGWxaM70Nj29RW+VQCYBjwgjAVAn016d/xOYthZkRgwq9drOkPyZepbgL02kEQQEYT91Vhwk1QNbr/cbCTPIMDAsxAM49OeWdx+LN4wsNBN24= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711909392; c=relaxed/simple; bh=/Szu4y/TJfsv6oreafiiKkyjVcOjHo0V9DLU872ZZVk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MVrGnX3vgyvI2If0wYqtELD2+ilm+T/XfOv3Jrb0GZEi/kaVaI6f2MwK1sCK2bBVIl6nxzX96ZRNuSl3JsccqoCD+n6Jd1QbsgCidAIg+1Xp5DYMNBlGOoZ+14hsoWMgXmtfPohPpcvCvdlkNSMZq5HBugIRiS/vfnLq8JDURd0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=kl.wtf; spf=pass smtp.mailfrom=kl.wtf; dkim=pass (2048-bit key) header.d=kl.wtf header.i=@kl.wtf header.b=aUurXb28; arc=none smtp.client-ip=95.215.58.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=kl.wtf Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kl.wtf Message-ID: <4fe2450a-51ca-4161-9006-1325c2a16c07@kl.wtf> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kl.wtf; s=key1; t=1711909387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z7wRlXzH8Qg7MRMYfnkHVzDjrc+zYR1Im/3e5jSkqlo=; b=aUurXb28LAngzLnQxRXGi+jOh7Zv+SUJc51h3qolL13q94pYE5VYpznT2MPDDS4BfrIBPp lYmbobVb42wSI0YbbIxgLgsCJ0i9helTz8xOWKXrkSD5nB/wjsUKIHPv0TNguWQS28cZ68 WNGHabxkyBdI38ZxgYQl7CUPebwGPpCdeZDWsLMF6DqYs+zaJ+mLjD+SwtqlItLDUVQrP8 JrH/eZXEHR0tgO5hVzCgsEceE+lJDi0RKVpql+bIJ5C8IEyZ23Ii9rTg14px+O/EalhZs4 CeCENG3gRUvIiqUp+79AAiigFrgS8k+x5tHQzUfuJToyGMdDFSJZGn/VM+/pGw== Date: Sun, 31 Mar 2024 20:23:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] HID: i2c-hid: Revert to await reset ACK before reading report descriptor To: Jiri Kosina , Benjamin Tissoires Cc: Douglas Anderson , Hans de Goede , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240331132332.6694-1-kl@kl.wtf> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kenny Levinsen In-Reply-To: <20240331132332.6694-1-kl@kl.wtf> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 3/31/24 3:23 PM, Kenny Levinsen wrote: > diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c > index 2df1ab3c31cc..be5d661dde41 100644 > --- a/drivers/hid/i2c-hid/i2c-hid-core.c > +++ b/drivers/hid/i2c-hid/i2c-hid-core.c > @@ -737,7 +737,9 @@ static int i2c_hid_parse(struct hid_device *hid) > ret = i2c_hid_start_hwreset(ihid); > if (ret) > msleep(1000); > + ret = i2c_hid_finish_hwreset(ihid); Ah, missed the check to only call i2c_hid_finish_hwreset if i2c_hid_start_hwreset succeeded, v2 incoming.