Received-SPF: pass (google.com: domain of linux-kernel+bounces-126369-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sun, 31 Mar 2024 22:28:27 +0200
From: Borislav Petkov <bp@alien8.de>
To: Mahmoud Younes <m.younesbadr@gmail.com>
Cc: dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org,
	luto@kernel.org
Subject: Re: [PATCH] kaslr: x86: fixes log message nokaslr
Message-ID: <20240331202827.GAZgnHayn794X_Ubs4@fat_crate.local>
References: <20240331200546.869343-1-m.younesbadr@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240331200546.869343-1-m.younesbadr@gmail.com>

On Sun, Mar 31, 2024 at 10:05:46PM +0200, Mahmoud Younes wrote:
> Unknown kernel command line parameters nokaslr message will be printed
> to kernel log buffer if nokaslr option exists in boot command line.
> nokaslr gets consumed earlier and this message becomes confusing.
> impact is that user gets confused whether kaslr is enabled or not.

Well, my dmesg has here:

---
..
trampoline_32bit: 0x0000000000000000


KASLR disabled: 'nokaslr' on cmdline.


Decompressing Linux... Parsing ELF... No relocation needed... done.
..
---

so the notification for the user is there.

> Signed-off-by: Mahmoud Younes <m.younesbadr@gmail.com>
> ---
>  arch/x86/mm/kaslr.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/x86/mm/kaslr.c b/arch/x86/mm/kaslr.c
> index 37db264866b6..a62cb0675e22 100644
> --- a/arch/x86/mm/kaslr.c
> +++ b/arch/x86/mm/kaslr.c
> @@ -179,3 +179,9 @@ void __meminit init_trampoline_kaslr(void)
>  			__pgd(_KERNPG_TABLE | __pa(pud_page_tramp));
>  	}
>  }
> +
> +static int __init parse_nokaslr(char *_)
> +{
> +	return 0;
> +}
> +early_param("nokaslr", parse_nokaslr);

This piece of code without any comments explaining why it is there is
not less confusing to whoever stares at it.

I'd prefer if print_unknown_bootoptions() would filter out those options
which are parsed earlier and not warn about them instead of having such
dummy stubs.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette