Received-SPF: pass (google.com: domain of linux-kernel+bounces-126385-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Mac Xu <mac.xxn@outlook.com>
To: Joe Perches <joe@perches.com>, Barry Song <21cnbao@gmail.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
CC: "apw@canonical.com" <apw@canonical.com>, "broonie@kernel.org"
	<broonie@kernel.org>, "chenhuacai@loongson.cn" <chenhuacai@loongson.cn>,
	"chris@zankel.net" <chris@zankel.net>, "corbet@lwn.net" <corbet@lwn.net>,
	"dwaipayanray1@gmail.com" <dwaipayanray1@gmail.com>,
	"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux@roeck-us.net" <linux@roeck-us.net>, "lukas.bulwahn@gmail.com"
	<lukas.bulwahn@gmail.com>, "sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
	"v-songbaohua@oppo.com" <v-songbaohua@oppo.com>, "workflows@vger.kernel.org"
	<workflows@vger.kernel.org>, Max Filippov <jcmvbkbc@gmail.com>
Subject: Re: [PATCH v4 2/2] scripts: checkpatch: check unused parameters for
 function-like macro
Thread-Topic: [PATCH v4 2/2] scripts: checkpatch: check unused parameters for
 function-like macro
Thread-Index: AQHagLa6dUAj6irLP0SxfpZRpU9V17FM60mAgAT23VWAACO3AIAAfOPE
Date: Sun, 31 Mar 2024 23:21:44 +0000
Message-ID:
 <MN0PR20MB471701E2FEB9DBCDCDCD9D44F3382@MN0PR20MB4717.namprd20.prod.outlook.com>
References: <20240328022136.5789-1-21cnbao@gmail.com>
	 <20240328022136.5789-3-21cnbao@gmail.com>
	 <ef2c96e40bcf777535c9ff2405e4dc5b3138b27e.camel@perches.com>
	 <MN0PR20MB4717810B82175CC594A9F285F3382@MN0PR20MB4717.namprd20.prod.outlook.com>
 <dbe8ea1a6a3b599a00eeb8ba0254fde785a500b9.camel@perches.com>
In-Reply-To: <dbe8ea1a6a3b599a00eeb8ba0254fde785a500b9.camel@perches.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels:
x-tmn: [JoQvYRRq1gC3nL8hEzEhe432+ZkdA/nT]
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: MN0PR20MB4717:EE_|MW4PR20MB4504:EE_
x-ms-office365-filtering-correlation-id: 327be0c5-1776-4ab2-8f28-08dc51d95487
x-ms-exchange-slblob-mailprops:
 02NmSoc12DedRvKN5/4QiK8NHQIQU0k8kQ7VOs77cDKlBCz3//c2Zm/ofZtqNkbk30DD3WAFDUYBSmoVfr5Si9TqQ6y9bm2xsL8qaeSjp0HZcRi8+6eT1yc7+urqMw0/kKTbe+4Zf6Fn/+4lMzoOxBRWrCUMj1eMDHuvgITPAR9/nefBJ7C21/PxEpUjJpza05GNLlTqIjKbmwZPM/w0AKplPa6lfk3lGdHcCB6tbL89gmjhEYevNGYXhl8pqPbAPaPaTENHe4DQjlGCcuqlATUFf9bm1muAHum3SJ7IcOy2rXd71dPEy7Eg8DCjj3ciLVB69BjPpTAqCY5IAb483ssnXFyxLZwrOH1cdQ5BnQwSxAQrJfDoz6m9g1QF2gyRD3+lfdJlvw5dMPMhMlq87pbm1Kd8xJ7aSaYCjQL+t2Qe1jxffBRr7NQSPu/psfpg8ZlN7JgibMdfbYYpkIyUkKYcyV7gYKNA9WTyIjC4c6JBWuEc7GFJyyeXH18XCLP7RkuiESo4lRg75a01c5vNTnzNV8qW0bpTp14/ABA6Lvb6uQuIF47W2YcnK5D5TAQlJ7QVvI5NtofXcVPpprsPdM/MuLPL2bGuIbz8pBUN6ecQ4Jh7Y/3jdZQIPs74E7saZVTDQet6cL4CHnI4U5tBfhFT6D8hcVJN6JrbfYndlI/4PqDnyitCNUyjC4ju9mHN+NlXaeXKqKDL0y2fxqbFIW7hAV+hgfVks+B5hF0xGI8AzYK4AfVBo98iUpstp+Hz
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 JWK/AGNFXoKHJBOAnMGpTw6uvAeON4V832zGTbNkzAfQOmNuweMHFZK/T19LQN2RtNsk+kg4C2rLO7Te1SnFJD7r7zPY5OuAfkv8WqzKxMM/itZ6S41K43+aPj6VUJ041vCOqhdsCV7Uq32diZDeHWyaQSAx9U/z8vEKwLpnyjg79aKd45LCDKO9dxR04wITdku11B4O1VHpfFBROJpECECZ2fndQGQ4TTeQXiLDbHbnvobYqTDfaAgF1SV9N4+4MrQHEAH/QyXSMQM/du7IAga9ZmbojkZK4jUFjgBPzoeYlV+WstluqNRg4u67UDgEViR0SFkU+4ztJOd+RM55whMUZgdM04DJHeoAO2J6thsttdTa/0QYL+T/fqvWCHcAJrDwh5Oqf0IDgvByWf8fiOtjXrO684RhdxfgcgjGnehfaCIBVC03o9qSl4LxUARj33qRhrOKccb+0lBJFo5XYOxntXgBx2UT9Bft8H4Z6RcawRqSOP1FAtEOT8fSdZy08ZQix81NqCLKOvo3yGT7a/wkxDCfZvtJ0g1pji+gAy1wrwrDXHC5/R0lWzhMV/OZ
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?iso-8859-1?Q?sbEZvsXBQ/Ri+RKwv6SkrgAq5HvmpbQIqb+B2ODMXdIW34guOLRhhNZw5x?=
 =?iso-8859-1?Q?ZpmO7/qYctaN3cz9A36TLjrVjA1kNavuyhchucv6Z0GY8OFN8qB2SONYf+?=
 =?iso-8859-1?Q?DAgo6jrEji1swcXdqxmeROXZOpNgWAfqXDF0Y7OSFiD0hKsGN8WYpzYyHv?=
 =?iso-8859-1?Q?pX/5V0gQ6WU8swacDjo019qnpz8F4vwBi4bsDE5oQgSvm+1RMg/2izV/6R?=
 =?iso-8859-1?Q?CbqVM9osKFoQmDI2Wqkebaac/w98XgFr85K2vjo/C46Fkvj/D/TaiC2ucf?=
 =?iso-8859-1?Q?W3DsWq8SDfOCtW1Hl3j1hUV267DFTT8f/zqcVJyhg3XXmKyGT+BnpZ0DHJ?=
 =?iso-8859-1?Q?zFd+gs66MaCP+/GLCimaETmNg+u1fd6TSba45csJIqzsCWiwspdzFAVxFj?=
 =?iso-8859-1?Q?Xe3GJdm9LPnx7s10HvsRftGs8K6QSXFr5CvGVmIyibh64N+O5DpB/mr8QS?=
 =?iso-8859-1?Q?fFZcUYKDg/HeT5co6+z0GogZhVFzzVXhYweRiEluNAY3BUy6MXvmNe9cJL?=
 =?iso-8859-1?Q?iC51wS3esyY2b2HAgqML7ahWi3pkdd7ORJdgnUhLe0hggtJPxXbZp2rD4C?=
 =?iso-8859-1?Q?2yv14vC+w5/H/9vwsZm2DV3joaXOHL84TLRg8btLszWxUdqN7nfmIQI89g?=
 =?iso-8859-1?Q?jccH66meSMwMjsOTSoDMOEzxtEsVMQfHpEMYVGr4AGtTmFSLJ4SFrZaj5f?=
 =?iso-8859-1?Q?SWKl9+XgKsEyEEMQyfGNcOKPOJAOuaT1uDP2tHh/GIHhkiEpDxAkGS873i?=
 =?iso-8859-1?Q?3MWkJLLIeDA1+O/O3MWS2AasEAAjsqKGpaCqHp51aNOEVxegwyE2t3Cq+U?=
 =?iso-8859-1?Q?zPiHrDHgVwoBZetyg8q2xH/2FrRCrwAQJrTcgDRHmmS8MFAfYNBl3Z8VXU?=
 =?iso-8859-1?Q?sVvxgaAjfA/BBGGI8B3iETWUERoc7WbroOwAjRHtwQwS8aQtsH2i2Ss/l5?=
 =?iso-8859-1?Q?s8xV1uHZsLjHg6i99Q80TDoKOiMgqXqTOTL21Qbg/HgJZZ/Zhuqy2tOvTO?=
 =?iso-8859-1?Q?JdYU8sThwQHpkGSzMmoTtbKyJryyogujxr2wrG5Ygtnc4wXoFrT+xhFrRZ?=
 =?iso-8859-1?Q?G1oguvSGO35nyrc0nDJNeIu8lCpLku1Q2hnwA9nXBkO1tGcReFhCAwZcxk?=
 =?iso-8859-1?Q?wWEYm79wgVeNktB+dYbLcgGnL/9H4VFn1V8Tdwu5uW/NOLjesKWyCXSnZJ?=
 =?iso-8859-1?Q?sTvr0BXVmxC/Em/MH38WWvcIpnFW7H565FaLBAEUGh8evt8NNoiJUitxkO?=
 =?iso-8859-1?Q?auObj1D24KpSiRWCfsHg=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN0PR20MB4717.namprd20.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 327be0c5-1776-4ab2-8f28-08dc51d95487
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Mar 2024 23:21:44.7280
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR20MB4504

=0A=
> On Sun, 2024-03-31 at 13:46 +0000, Mac Xu wrote:=0A=
> > > On Thu, 2024-03-28 at 15:21 +1300, Barry Song wrote:=0A=
> > > > From: Xining Xu <mac.xxn@outlook.com>=0A=
> > > >=0A=
> > > > If function-like macros do not utilize a parameter, it might result=
 in a=0A=
> > > > build warning.  In our coding style guidelines, we advocate for uti=
lizing=0A=
> > > > static inline functions to replace such macros.  This patch verifie=
s=0A=
> > > > compliance with the new rule.=0A=
> > > []=0A=
> > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl=0A=
> >=0A=
> []=0A=
> > > It seems this logic is a bit redundant to existing=0A=
> > > code and might be better added in the block that starts=0A=
> > >=0A=
> > > (line 6026)=0A=
> > > # check if any macro arguments are reused (ignore '...' and 'type')=
=0A=
> > >=0A=
> > > as that already does each param in a #define and=0A=
> > > ignores ... and type=0A=
> >=0A=
> > Hi Joe,=0A=
> >=0A=
> > Thank you for your comments with insights, as you said, code block of l=
ine 6026 is a better place to=0A=
> > place this new logic, as it already handles the logic I'd wanted like e=
xtracting, splitting and trimming=0A=
> > the arguments, excluding the trailing comments etc.=0A=
> >=0A=
> > By placing the logic in the new place, code duplicates are reduced.=0A=
> >=0A=
> > Here's my new code (inserted from line 6044):=0A=
> > +# check if this is an unused argument=0A=
> > +        if ($define_stmt !~ /\b$arg\b/) {=0A=
> > +                WARN("UNUSED_ARG_IN_MACRO",=0A=
> Perhaps=0A=
>                                         WARN("MACRO_ARG_UNUSED",=0A=
>                         ...=0A=
> =0A=
> to better match the others above it in the block:=0A=
> =0A=
>                                         CHK("MACRO_ARG_REUSE",=0A=
> and=0A=
>                                         CHK("MACRO_ARG_PRECEDENCE",=0A=
> =0A=
> Other than that trivial bit, seems ok.=0A=
=0A=
Sure, updated, thank you!=0A=
=0A=
+# check if this is an unused argument=0A=
+if ($define_stmt !~ /\b$arg\b/) {=0A=
+	WARN("MACRO_ARG_UNUSED",=0A=
+		"Argument '$arg' is not used in function-like macro\n" . "$herectx");=0A=
+}=0A=
=0A=
Regards,=0A=
Xining=0A=