Received-SPF: pass (google.com: domain of linux-kernel+bounces-126416-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <f5bb12d8602a03d28b2a8aeaffd8f74f001d692d.camel@perches.com>
Subject: Re: [PATCH v5 2/2] scripts: checkpatch: check unused parameters for
 function-like macro
From: Joe Perches <joe@perches.com>
To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, 
	linux-doc@vger.kernel.org, workflows@vger.kernel.org
Cc: apw@canonical.com, broonie@kernel.org, chenhuacai@loongson.cn, 
 chris@zankel.net, corbet@lwn.net, dwaipayanray1@gmail.com, 
 herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org,
 linux@roeck-us.net,  lukas.bulwahn@gmail.com, mac.xxn@outlook.com,
 sfr@canb.auug.org.au,  v-songbaohua@oppo.com, Max Filippov
 <jcmvbkbc@gmail.com>, Jeff Johnson <quic_jjohnson@quicinc.com>, Charlemagne
 Lasse <charlemagnelasse@gmail.com>
Date: Sun, 31 Mar 2024 19:37:09 -0700
In-Reply-To: <20240401012120.6052-3-21cnbao@gmail.com>
References: <20240401012120.6052-1-21cnbao@gmail.com>
	 <20240401012120.6052-3-21cnbao@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-04-01 at 14:21 +1300, Barry Song wrote:
> From: Xining Xu <mac.xxn@outlook.com>
>=20
> If function-like macros do not utilize a parameter, it might result in a
> build warning.  In our coding style guidelines, we advocate for utilizing
> static inline functions to replace such macros.  This patch verifies
> compliance with the new rule.
>=20
> For a macro such as the one below,
>=20
>  #define test(a) do { } while (0)
>=20
> The test result is as follows.
>=20
>  ERROR: Parameter 'a' is not used in function-like macro, please use stat=
ic
>  inline instead
>  #21: FILE: mm/init-mm.c:20:
>  +#define test(a) do { } while (0)

This is no longer true.
Please update the ERROR->WARN and message as below

Ideally, this would have an update to
Documentation/dev-tools/checkpatch.rst

to describe the new --verbose message type

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -6040,6 +6040,12 @@ sub process {
>  					CHK("MACRO_ARG_PRECEDENCE",
>  					    "Macro argument '$arg' may be better as '($arg)' to avoid prece=
dence issues\n" . "$herectx");
>  				}
> +
> +# check if this is an unused argument
> +				if ($define_stmt !~ /\b$arg\b/) {
> +					WARN("MACRO_ARG_UNUSED",
> +						"Argument '$arg' is not used in function-like macro\n" . "$herectx=
");
> +				}