Received-SPF: pass (google.com: domain of linux-kernel+bounces-126479-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <0687994c-82b9-4395-8777-f15b101650e8@vivo.com>
Date: Mon, 1 Apr 2024 14:52:02 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] dmabuf: fix dmabuf file poll uaf issue
To: "T.J. Mercier" <tjmercier@google.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>,
 =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
 linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
 linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
 opensource.kernel@vivo.com
References: <20240327022903.776-1-justinjiang@vivo.com>
 <CABdmKX1swVO1=6cs+CW_g2g4g7woB5-Ks1gBzCA+iLcvpLmkvQ@mail.gmail.com>
From: zhiguojiang <justinjiang@vivo.com>
In-Reply-To: <CABdmKX1swVO1=6cs+CW_g2g4g7woB5-Ks1gBzCA+iLcvpLmkvQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OEtGVHduL2IzOTUrQWNkV1dhL1F2aVpnOWFIbm0wTTh3LzdIaEUzNGJRRjlF?=
 =?utf-8?B?cmtGUnUwWWh4QjhtdlhXbWNkeWYxd3FHdVcyam05Z0svaWRGUGlpcC94aUI0?=
 =?utf-8?B?UXhFaXM0ZjVSVXdEdFZzd2xOamRQZjE2MW4rcHFWaHJxWE42Z2M2VTY5aHlq?=
 =?utf-8?B?Z0Y2UVI3dmk5WkNHSW93czJ1NG51TE5RMkFPQTIvOHl4U2krM0hTNWljU3lE?=
 =?utf-8?B?NlBlUjJhMVIvWVJJcTBVS1hhYUZkODY0Rzc3bDB0eldNN1QycUFVYUdHOU5S?=
 =?utf-8?B?Z1BxU1pONWNUTWRkZmc5a1YwNWI0d1p0VnlXcjU2a0NNalBSbFJKSm5JN2FY?=
 =?utf-8?B?TjBOcFhtSVVoS0Y1bWswdU0vblBqUUZ6MkhFZUllOHJZOTZrTkMwNlFycUcy?=
 =?utf-8?B?Vi93eFB2SURYK3VGVW40OG0yTjhQL05yZm1VRUExSnJLeFcxYytaVS9Nb2VJ?=
 =?utf-8?B?N1IzemtNRU5TcjJVckpwZEt3Q3hWQkZIZWQzM25ETEtwMC9UWkdVOEZVTWVR?=
 =?utf-8?B?Q2M5ZTRZdXNMaGp1WHM4RkwrSWxsVUxaZ1Jid3hZNGZqYlRhWS9QV2pySWZh?=
 =?utf-8?B?Q0F1L2Z6UTlidHh0d2d6OFhtYWtmUWw1YTJVMk1NdWlidGtUdk5ZbjFuRGZN?=
 =?utf-8?B?MjQwUTBVWUE3NHM5c3FGeGxKOFFWWERkaDNDaElyS3BVS2krQStMaE1XL1ow?=
 =?utf-8?B?VDl5cHV2bWFtNmJ1NktqTUpZZENhUnppQUxVdEVYQ0NqUVZKT3JjVnhNbjAr?=
 =?utf-8?B?QXlYeEZuU09tM3pxZzU1VG85aHM2Nmt5dkpRODc4Nko1VVN2dy9hck1VVlpO?=
 =?utf-8?B?LzBEVnhteUdVeXpyZEJ1UFRwdnh6MUZ1b1RSM0Z6aU02YW9OaU1kVXlhNWNF?=
 =?utf-8?B?R3R5ZHhzWG9OUmlySllIUnhJdVlTaGx2K0lJeDYvaGRzRG91eXp0TDN1M2d3?=
 =?utf-8?B?NHJ3Q2JubVdXYW13Qk9QQzdDUFVUUEtxbEpGWFZJT2l1YlRxL1dLMlQ5MFJQ?=
 =?utf-8?B?QWZjNzZJMy9ON3A4aDVhNlNDSERpNGo5c0pZR24zZWxhMC93ZTJRNnlaa2w0?=
 =?utf-8?B?Zm5LeXk0eTFnRW9uay9XSjdRdzloODMyM3RwTkpEeEt4T2hUZjNWVVZnM0Va?=
 =?utf-8?B?ZDNhcjF6ckVicnpDc2hLdnFwZVNiaktqc0VjU0tmQStjK2xVdTYvUGpQcHlW?=
 =?utf-8?B?RDFucUsvT25SS3BKM3BLTWNUd3FIQnFpa2Fva0hZa1YyTElXblJoRGRqRk1J?=
 =?utf-8?B?R1kreFVTRmVOakhub1dMVmt1TXBIQmIwSGNQRnpTOW0yR3pLbE9ycXdXL1V6?=
 =?utf-8?B?TWM0ZjJ0aXpQMEZQb3NSVTkxWEpZbHZ0U2hheGxiYktxQ0haMGhubE9VNVFX?=
 =?utf-8?B?NEdScnl4eTQxWFU0NDhXTkNJQ01yQnFmZFZnUlpTMVZQUk9JdUNyYXFGOGlU?=
 =?utf-8?B?YlFvZFh3bzVzVFBUdkxLeWo4dkI1OVVzVEJJY1Y0a1R1YXd1ckRjZWZyR09o?=
 =?utf-8?B?RjZiek52SktUTkM4ZTk1WGNjajhkNDNCSUxkT2c0RWJhUHMxTUZZRXRzYUxq?=
 =?utf-8?B?TkFoQzBnSU9uTGpneHJoaTdFbHJ3OGQ1UmpSbFJ5SmxWRGtVKzY3RjRET2JR?=
 =?utf-8?B?YkU1MFR3Q1FWRnROUElDK21WODJQYWV6aU1BYWZaZVkycmdFeVd6cnoxT1pm?=
 =?utf-8?B?aGF3OERlWVNNVnV0QVpJcVFRWURUUkQxOGYwR0dQRG12Y2JqY3hLNkZZYzF5?=
 =?utf-8?B?Znd6K3ZqOTBSbDRxeTJreDlkVkxGeTNmRUhrMzBQSkYrNkJCaTZ0SksyNjdl?=
 =?utf-8?B?ZVl3VUV3eE4vQ0JMTEM0bC9MRDhvQUppRTgxQjE2b0tOaks5WFBrV2dzRlFN?=
 =?utf-8?B?NTluZVNZMzMwMURKMGFzcUd0Qm96NFY5bVZTK01wSnpxUWRZRmtsSGRVUCtw?=
 =?utf-8?B?azBJc0luRk9Fbk5aaW9xaktzaW9PUlRMQU42WGJyaFZPSDAwSGxncG5jOXY4?=
 =?utf-8?B?RllBZUhsZnlxOURlRFhaZDJjblV6akRCS25Kd0xUekdiZjVjcm5kYm84bXRM?=
 =?utf-8?B?d2lRNExka3VacHpnMnlIaExpM2Z2OEdsRXVuVmx6UkdpTTk1VzB6SllEM1hU?=
 =?utf-8?Q?EOWWzvcOjszGLlHP7g4RErdEZ?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fffa798-2f7d-4efd-a521-08dc52183d5b
X-MS-Exchange-CrossTenant-AuthSource: JH0PR06MB6849.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 06:52:04.3860
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RDGKKq7/2inqWCIzA3ATBMjbuUR8aXn+1oKnJ1VDxZQX7nq6KKifc6DAxadwDohl6GelS+BYbehY0bas3HmJ9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB5624

Hi T.J.,

> What is the most recent kernel version you've seen the bug on?
The latest kernel version of the issue we discovered is kernel-6.1.25, and
kernel-5.15 also reported this issue.
> You are closing the dmabuf fd from another thread while it is still
> part of the epoll interest list?
Yes, we found that threads related to android.display modules performed
an operation to close this dmabuf fd while it was still part of the 
epoll interest
list,  but the specific threads were random. So I think this is also 
issue with
the logic of kernel dmabuf code.

Thanks,
Zhiguo


在 2024/3/30 7:36, T.J. Mercier 写道:
> [你通常不会收到来自 tjmercier@google.com 的电子邮件。请访问 https://aka.ms/LearnAboutSenderIdentification，以了解这一点为什么很重要]
>
> On Tue, Mar 26, 2024 at 7:29 PM Zhiguo Jiang <justinjiang@vivo.com> wrote:
>> The issue is a UAF issue of dmabuf file fd. Throght debugging, we found
>> that the dmabuf file fd is added to the epoll event listener list, and
>> when it is released, it is not removed from the epoll list, which leads
>> to the UAF(Use-After-Free) issue.
>>
>> The UAF issue can be solved by checking dmabuf file->f_count value and
>> skipping the poll operation for the closed dmabuf file in the
>> dma_buf_poll(). We have tested this solved patch multiple times and
>> have not reproduced the uaf issue.
>>
> Hi Zhiguo,
>
> What is the most recent kernel version you've seen the bug on?
>
> You are closing the dmabuf fd from another thread while it is still
> part of the epoll interest list?
>
> Thanks,
> T.J.