Received-SPF: pass (google.com: domain of linux-kernel+bounces-126518-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 1 Apr 2024 16:22:00 +0800
From: Chao Gao <chao.gao@intel.com>
To: <isaku.yamahata@intel.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	<erdemaktas@google.com>, Sean Christopherson <seanjc@google.com>, Sagi Shahar
	<sagis@google.com>, Kai Huang <kai.huang@intel.com>, <chen.bo@intel.com>,
	<hang.yuan@intel.com>, <tina.zhang@intel.com>
Subject: Re: [PATCH v19 102/130] KVM: TDX: handle EXCEPTION_NMI and
 EXTERNAL_INTERRUPT
Message-ID: <ZgpuqJW365ZfuJao@chao-email>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <3ac413f1d4adbac7db88a2cade97ded3b076c540.1708933498.git.isaku.yamahata@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <3ac413f1d4adbac7db88a2cade97ded3b076c540.1708933498.git.isaku.yamahata@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eezuW0uoRHEp62hFKREP+bsF6Zfy5G9K+PqMJKe28PCMp7TEXkSVHYTWaH0G?=
 =?us-ascii?Q?/MfOILWWC1a2+2hCiKwMf+54GROLsmn6fuDiUzm6B5npmzMy7anBl2kvSnPZ?=
 =?us-ascii?Q?MY5f8ChBbtm8FKYcWoqA9XQ+X8Bb+9JNX+X13IZWZcn/ZN5Hzfeb899dDjM8?=
 =?us-ascii?Q?JFGNZsx6vPL3FUHfxV6K+eP9YglorIxQObRQJGBQ8C2wABjxXl4Mq7csjUIu?=
 =?us-ascii?Q?urIXmRhtlGzV/BRlI2H24WGL+0lQvUXutIdEcftpgYAgIx8+92RNMTC07iyM?=
 =?us-ascii?Q?50w5hvp9d4bZIg1E8lsvqkuvmvNvPdPC2SsLOvyVRbli08boYK9cjt/SeTAD?=
 =?us-ascii?Q?8UPhCehGxfJOjmduD1foHzMwU3fTviCjQWuzvyxs9vlWOwQaPaYlRhfRT/Ed?=
 =?us-ascii?Q?b0IkDZ4af1GQkuHUDkrv+7WfLuhhmPQ7pj/PxumrNtoQo4PI2tgPO0y4RGAC?=
 =?us-ascii?Q?APsNS2WAuYVPaYZQ0wgTIaJmOhQQ0Jlr0DxZiauz3FDPowKZuDKtXRrrsuow?=
 =?us-ascii?Q?2ZaDGNBIhx/6ivQN6LkCd4lbhVOhGOg5GJetGkCOBTQMSqF2WFrnB0TeiYTo?=
 =?us-ascii?Q?t1hzytZ8rZAN9kETVDTDBRX0qZ5jLiJixAjrEXdj1+9vJc3MXUosglW+RYPE?=
 =?us-ascii?Q?tRVJSqdDa6F8p4bmzPKQ+YJkc+oSKu5c+Cn8U+LdhSXQKhfJY/jmkmgEvODs?=
 =?us-ascii?Q?b2lz5/mzrnlFkBRMjMWvo4iMQ4tipAFbDn2VgZNAOOG/GufObpxRuLX+QvU4?=
 =?us-ascii?Q?bEWXFCvBaUHAWP4cNmdnggUgatPLbkbgTyqL0k6aA0TlwUyaqDhCL70hSgYU?=
 =?us-ascii?Q?QSUYpZLmIKJbMSlF2lqBfIBEtqpqppFUL385hnFMSIBYS1IJLS+omU7e6jOj?=
 =?us-ascii?Q?tVB5V0qdTJJPwys2NO+lqDPtuY5Os34b7rv67MGhvfallEhhLUViyTGSIGmj?=
 =?us-ascii?Q?Ufap6l9DfTB21i+e0VAkYJ8Lb/XPRimuauLGJcEiJe/lE9D/KU+7If/AAaqw?=
 =?us-ascii?Q?G0mezJEqrcFleURUJslmAQ9msjpjkopnNpfUh4RAoPwQuCitpdJ8UItBRobn?=
 =?us-ascii?Q?sZtir5az8kr/RI9l+nA4zorj/lFkGNGioSOiD8xcbFYO0LEew45jz4k+76m1?=
 =?us-ascii?Q?C6VaOHqxjWT0WpW2dUt6MaCNkNlWcSVe7tomoFT4cnPddIQJk9BRnFCrEOqj?=
 =?us-ascii?Q?4aayUxIn0hltc13Syi/ngARDaz9pz0T/JZp5Z7ONRxRVaFUriChV8VLQe8D2?=
 =?us-ascii?Q?2yJOhFoOCiDi2U49/dGJKQNm8raKcqVb/+eZFPlrJLiBYmr0dS8NKvKXTa3h?=
 =?us-ascii?Q?OXWTxBmQPorVlSSyNWLltDBZE+NfJJUpiN25lloXOM0YM3r6CaDPRkJimX8i?=
 =?us-ascii?Q?kkCATyCsAteHyfQ7aGKj04gAJl1WCHiIjKuMAervO/0CVjqLmpJmxYgO0mpx?=
 =?us-ascii?Q?qEIYRWxLtczg67gLOzI5eMwdH1twF7yzu/a8fHkELt6pVjOBwZ9hEIRU9qFE?=
 =?us-ascii?Q?y57wxz0S+fVR7h89hBpjgKOUnP/zovVKEh+NFFwvmJs405x7Yvw4O58Qw87k?=
 =?us-ascii?Q?ROCfO6sml+rbx+7TnCInod9ivymqB/Hnw+UdWwb4?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e5f46247-37ff-4581-b676-08dc5224d32f
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 08:22:09.6635
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KRMauA317m+25dHC3nm0uf1Pgm+YT46lV+7zu/+SAAsQFTN7N6KrV83BgQ8z2zQ5Y/P+zjS74d5oakKfVXYcdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8086
X-OriginatorOrg: intel.com

On Mon, Feb 26, 2024 at 12:26:44AM -0800, isaku.yamahata@intel.com wrote:
>From: Isaku Yamahata <isaku.yamahata@intel.com>
>
>Because guest TD state is protected, exceptions in guest TDs can't be
>intercepted.  TDX VMM doesn't need to handle exceptions.
>tdx_handle_exit_irqoff() handles NMI and machine check.  Ignore NMI and

tdx_handle_exit_irqoff() doesn't handle NMIs.

>machine check and continue guest TD execution.
>
>For external interrupt, increment stats same to the VMX case.
>
>Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
>Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>---
> arch/x86/kvm/vmx/tdx.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
>diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c
>index 0db80fa020d2..bdd74682b474 100644
>--- a/arch/x86/kvm/vmx/tdx.c
>+++ b/arch/x86/kvm/vmx/tdx.c
>@@ -918,6 +918,25 @@ void tdx_handle_exit_irqoff(struct kvm_vcpu *vcpu)
> 		vmx_handle_exception_irqoff(vcpu, tdexit_intr_info(vcpu));
> }
> 
>+static int tdx_handle_exception(struct kvm_vcpu *vcpu)
>+{
>+	u32 intr_info = tdexit_intr_info(vcpu);
>+
>+	if (is_nmi(intr_info) || is_machine_check(intr_info))
>+		return 1;

Add a comment in code as well.

>+
>+	kvm_pr_unimpl("unexpected exception 0x%x(exit_reason 0x%llx qual 0x%lx)\n",
>+		intr_info,
>+		to_tdx(vcpu)->exit_reason.full, tdexit_exit_qual(vcpu));
>+	return -EFAULT;

-EFAULT looks incorrect.

>+}
>+
>+static int tdx_handle_external_interrupt(struct kvm_vcpu *vcpu)
>+{
>+	++vcpu->stat.irq_exits;
>+	return 1;
>+}
>+
> static int tdx_handle_triple_fault(struct kvm_vcpu *vcpu)
> {
> 	vcpu->run->exit_reason = KVM_EXIT_SHUTDOWN;
>@@ -1390,6 +1409,10 @@ int tdx_handle_exit(struct kvm_vcpu *vcpu, fastpath_t fastpath)
> 	WARN_ON_ONCE(fastpath != EXIT_FASTPATH_NONE);
> 
> 	switch (exit_reason.basic) {
>+	case EXIT_REASON_EXCEPTION_NMI:
>+		return tdx_handle_exception(vcpu);
>+	case EXIT_REASON_EXTERNAL_INTERRUPT:
>+		return tdx_handle_external_interrupt(vcpu);
> 	case EXIT_REASON_EPT_VIOLATION:
> 		return tdx_handle_ept_violation(vcpu);
> 	case EXIT_REASON_EPT_MISCONFIG:
>-- 
>2.25.1
>
>