Received-SPF: pass (google.com: domain of linux-kernel+bounces-126558-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 1 Apr 2024 11:37:36 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Ajay Kaher <ajay.kaher@broadcom.com>
Cc: Kuntal Nayak <kuntal.nayak@broadcom.com>, stable@vger.kernel.org,
	jslaby@suse.com, linux-kernel@vger.kernel.org,
	alexey.makhalov@broadcom.com, vasavi.sirnapalli@broadcom.com,
	Yangxi Xiang <xyangxi5@gmail.com>, stable <stable@kernel.org>,
	Florian Fainelli <florian.fainelli@broadcom.com>
Subject: Re: [PATCH v4.19-v5.4] vt: fix memory overlapping when deleting
 chars in the buffer
Message-ID: <2024040149-countable-ecosystem-ee44@gregkh>
References: <20240329191208.88821-1-kuntal.nayak@broadcom.com>
 <2024033014-deception-cartoon-7470@gregkh>
 <CAD2QZ9aJtFpXWYRVmgJRjad6qXXECvi+-J++QAR2t4opa6cdUA@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAD2QZ9aJtFpXWYRVmgJRjad6qXXECvi+-J++QAR2t4opa6cdUA@mail.gmail.com>

On Mon, Apr 01, 2024 at 02:51:55PM +0530, Ajay Kaher wrote:
> On Sat, Mar 30, 2024 at 2:37 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Fri, Mar 29, 2024 at 12:12:08PM -0700, Kuntal Nayak wrote:
> > > From: Yangxi Xiang <xyangxi5@gmail.com>
> > >
> > > [ upstream commit 39cdb68c64d8 ]
> >
> > Please use the full git id in the future, it makes it easier and our
> > tools want it that way so that we can tell the difference between a
> > "Fixes:" tag and an actual backport.  I'll go queue this up now, thanks!
> >
> 
> Thanks Greg for accepting the patch.
> 
> ./scripts/checkpatch.pl confuse developers, as it gives error/warning
> if we use full git id.

No need to run checkpatch on backports, as the changelog text should not
be an issue.

> Example:
> ERROR: Please use git commit description style 'commit <12+ chars of
> sha1> ("<title line>")' - ie: 'commit e26d3009efda ("netfilter:
> nf_tables: disallow timeout for anonymous sets")'
> #6:
> commit e26d3009efda338f19016df4175f354a9bd0a4ab upstream.
> 
> Or shall we have something ./scripts/checkpatchstable.pl or
> ./scripts/checkpatch.pl stable (pass argument)?

Nah, it's never come up before now, I don't think people actually run
it, and I know I've never done so or even noticed, so all is fine.

thanks,

greg k-h