Received-SPF: pass (google.com: domain of linux-kernel+bounces-126566-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <8d8d3f54-4ae2-432e-9ac2-d3431436115e@ti.com>
Date: Mon, 1 Apr 2024 15:12:24 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v4 1/3] net: ethernet: ti: am65-cpts: Enable PTP
 RX HW timestamp using CPTS FIFO
Content-Language: en-US
To: Jakub Kicinski <kuba@kernel.org>
CC: Dan Carpenter <dan.carpenter@linaro.org>,
        Siddharth Vadapalli
	<s-vadapalli@ti.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        "Heiner
 Kallweit" <hkallweit1@gmail.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Andrew Lunn <andrew@lunn.ch>, Roger Quadros <rogerq@kernel.org>,
        "Richard
 Cochran" <richardcochran@gmail.com>,
        Paolo Abeni <pabeni@redhat.com>, "Eric
 Dumazet" <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
References: <20240327054234.1906957-1-c-vankar@ti.com>
 <20240329150116.67da2b07@kernel.org>
From: Chintan Vankar <c-vankar@ti.com>
In-Reply-To: <20240329150116.67da2b07@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 30/03/24 03:31, Jakub Kicinski wrote:
> On Wed, 27 Mar 2024 11:12:32 +0530 Chintan Vankar wrote:
>> CPTS module supports capturing timestamp for every packet it receives,
>> add a new function named "am65_cpts_find_rx_ts()" to get the timestamp
>> of received packets from CPTS FIFO.
>>
>> Add another function named "am65_cpts_rx_timestamp()" which internally
>> calls "am65_cpts_find_rx_ts()" function and timestamps the received
>> PTP packets.
> 
> Maybe i'm unusually tied today but reading this patch without reading
> the next one makes no sense. I mean, you say:
> 
>    CPTS module supports capturing timestamp for every packet it
>    receives...
> 
> How is that relevant here.

Yes, I got your point it is not relevant here, I will update commit
message in next version.

> 
> When you post v5 please make sure to include a cover letter, explaining
> the overall goal and impact of the series.
> 
>> +			list_del_init(&event->list);
>> +			list_add(&event->list, &cpts->pool);
> 
> list_move() ?

Thanks for suggestion, I will update these function calls.