Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp1395716lqz; Mon, 1 Apr 2024 05:19:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVsOv4RB7szEDdvX5Py1pe41MVWmi51Ofp2NmyGJM5S5elFucAOld2Ts+Lx8yYkIhmoBa0fL6pv6XJMSmZtZTKnVXohsgdZrcx3GZk0hQ== X-Google-Smtp-Source: AGHT+IF6t3kLfDPscjKbXM3ZVP3nYnFvd2849XrPcg4NtAwmvRCvHeFiQ1okvERzihHrvUwC1JdW X-Received: by 2002:a25:5f0a:0:b0:dce:2e9:a637 with SMTP id t10-20020a255f0a000000b00dce02e9a637mr3922826ybb.20.1711973986822; Mon, 01 Apr 2024 05:19:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711973986; cv=pass; d=google.com; s=arc-20160816; b=halDXtnSXWok2vyiAe7sjZsxvgevwwU2WCf4Y+IGaWMD2ft6xj8qg+7kcVGqrizOBh 0LcETda53TZIE4A+91YuTfT0ber/R2HSi+r8hFzPA9O4+20RF0/OIBqkIechDyLVh4uX x4jpwG/k0HScGRJ0ddltQ8eUMBvQLvKnzo4PmIoWxnSVR2pZNSrO4oKNTAV5gfnXBMyP U+9dkdf7IoB5nKOkpJ8RX2oxwdSN99yWMzYVFpZ2F2PGuJV5XWYNh9w0g/O+iD6lBPeb tG8LMx61lY1Q4gEFc1XS9mftRI9JkBckAzt1kR1wTrsX6ydQ+WVE4H9HbBHuGRgeyd77 GNKw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=brDWkTGNGaA3tTbZ9XBpZpakQ95RGRo0YIq8XeERRcA=; fh=Dn9bP7blD7hI5+fDFRfmOh4iE6nW3B2jZW1ce4WjHG8=; b=pUChWIcuwPh+ppCWqJc2kziob7++cX0Xhr+dnL8SAFO2wzgtCa/6bE226kTp+QRX0h Y6moGUozQrad4Kv1ORbfDP/A0SyHi1BR8Dnj2fTWYSvc6ctFeWj9alHCjg+tnfnowwFC 98jxv1nN9jFuTGLc9tT6xthBmVQLI6WOav+3qX++kGdA9j1Ma/q+CcFdflGcHp/rxMbZ LQOSl9sjFPjY+Y4oHgMRo4wfRqGpG7PU0SHqLevsmdVivEuxHt0BwVgo/xC+Pa0F03ik 9PFKd212dRvPWoPlc36Lg5/oeUyx+mnIXeURJvPUxO1zVosEJpjpWBn1+dtxbTAjvm70 ucfw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gqwbhnnH; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-126644-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-126644-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id x16-20020a05620a0ed000b00789cc5f44acsi9249682qkm.373.2024.04.01.05.19.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 05:19:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-126644-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gqwbhnnH; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-126644-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-126644-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8AA871C20DDC for ; Mon, 1 Apr 2024 12:19:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C86E1381D5; Mon, 1 Apr 2024 12:19:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gqwbhnnH" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBFA537144; Mon, 1 Apr 2024 12:19:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711973980; cv=none; b=Wk2WMUHvUaQgEAV7ZTKtAeZx4nmArXbT3oxaSz5iNjBc7CRJAM53r2eCPJ0WPO4+JtrsUs5XwDgJFDZGrsFGBMstteClZI358+Dk7oYotYIh3salXjLh8LlfDbMFDj4yReyRebeeT7LyhJwbM837IzKwySirUHcPSeeq7i99YBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711973980; c=relaxed/simple; bh=X1mhUSfY/UmiQnf7P2IuWSUfMdU420ZMt4UGK6V3MtM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=qmw1hrK7jbyV7A1F9OTJNP6UiGmz75y+uPoIU2y8UlMm7CVAgfK6kd6TlqzRoe+kyLwQ/euG24Q8GcgTH5OtgAiKKN4y5L0jNEG+ILmaT0IdC4BNGKTLQr5fzciSpjKHMbGz/iAt6XaXqwMfOUUJpz6TIGBzkSPzsA6Wfdj/15A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gqwbhnnH; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68D95C433F1; Mon, 1 Apr 2024 12:19:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711973979; bh=X1mhUSfY/UmiQnf7P2IuWSUfMdU420ZMt4UGK6V3MtM=; h=From:To:Cc:Subject:Date:From; b=gqwbhnnH49escZvZsVPEfbsABxbKhYwEflWpgtKQJdsO4fB/g/EziMyMgBL8aXhky V/mtoOaCA++UTwIo3LpwFdEgVnOqhBmE04b8dQOsDYtY0wJ3I2uWWw33PZYjgvWFK8 63Vq+jtzJm9U0jATGuMqIOHS0TD2cnggWi9gkDLxhr6avvDjoB7n0CyV4aMrGEq9qj 4yUFZd8GSehqJ3lhiQIjCzGlqsEy2xZd5keV+XmJBPaO+q7hBVObuIJralTSnX/70v r4s4/owgArKoRopSIPM49JaagAJNUEvlk/r4zc6arSUp9xkWJsx+PrKtspbmNUMobV qrwzb/DID03wQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=valley-girl.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rrGdV-000HqT-1d; Mon, 01 Apr 2024 13:19:37 +0100 From: Marc Zyngier To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Arnd Bergmann , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas Subject: [PATCH] PCI: apple: Fix dependency on 16kB pages Date: Mon, 1 Apr 2024 13:19:33 +0100 Message-Id: <20240401121933.600977-1-maz@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false While d3e5bab923d3 consolidated the various definitions for page sizes, it ended up breaking the Apple PCIe driver, which still depends on ARM64_PAGE_SHIFT. Switch over to HAVE_PAGE_SIZE_16KB to make the driver selectable again. Cc: Arnd Bergmann Cc: Lorenzo Pieralisi Cc: "Krzysztof WilczyƄski" Cc: Rob Herring Cc: Bjorn Helgaas Fixes: d3e5bab923d3 ("arch: simplify architecture specific page size configuration") Signed-off-by: Marc Zyngier --- drivers/pci/controller/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig index efb5043f106a..fbcf1ff522b8 100644 --- a/drivers/pci/controller/Kconfig +++ b/drivers/pci/controller/Kconfig @@ -39,7 +39,7 @@ config PCIE_APPLE depends on ARCH_APPLE || COMPILE_TEST depends on OF depends on PCI_MSI - depends on ARM64_PAGE_SHIFT = 14 || COMPILE_TEST + depends on HAVE_PAGE_SIZE_16KB || COMPILE_TEST select PCI_HOST_COMMON help Say Y here if you want to enable PCIe controller support on Apple -- 2.39.2