Received-SPF: pass (google.com: domain of linux-kernel+bounces-126653-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 01 Apr 2024 13:29:22 +0100
Message-ID: <86cyr9z2ot.wl-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: linux-pci@vger.kernel.org,	linux-kernel@vger.kernel.org,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,	Krzysztof =?UTF-8?B?V2lsY3p5?=
 =?UTF-8?B?xYRza2k=?= <kw@linux.com>,	"Rob Herring" <robh@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [PATCH] PCI: apple: Fix dependency on 16kB pages
In-Reply-To: <3c9523b7-9bba-4fe2-97a1-893e8505e054@app.fastmail.com>
References: <20240401121933.600977-1-maz@kernel.org>
	<3c9523b7-9bba-4fe2-97a1-893e8505e054@app.fastmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Mon, 01 Apr 2024 13:23:27 +0100,
"Arnd Bergmann" <arnd@arndb.de> wrote:
>=20
> On Mon, Apr 1, 2024, at 14:19, Marc Zyngier wrote:
> > While d3e5bab923d3 consolidated the various definitions for page sizes,
> > it ended up breaking the Apple PCIe driver, which still depends on
> > ARM64_PAGE_SHIFT. Switch over to HAVE_PAGE_SIZE_16KB to make the driver
> > selectable again.
> >
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
> > Cc: "Krzysztof Wilczy=C5=84ski" <kw@linux.com>
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Fixes: d3e5bab923d3 ("arch: simplify architecture specific page size=20
> > configuration")
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
>=20
> The dependency only exists in the asahi kernel with commit
> db5709e83c11 ("PCI: apple: Add depends on ARM64_PAGE_SHIFT =3D 14")
> and is not present upstream.

You are absolutely right, and I should have checked where this
dependency was coming from.

Apologies for the noise.

	M.

--=20
Without deviation from the norm, progress is not possible.