Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp1409633lqz; Mon, 1 Apr 2024 05:48:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUZTMGrdYDqt7sTteqKAOaXENq5ApgMtmWU9I80CTEPTLvVA+9c/lnrG6q8zFNbpacI75IVsvtinKTocVirdjrXfMIXGCMBFjfqBWRi3A== X-Google-Smtp-Source: AGHT+IEINIKo7oH5m4Mfndy6EgdoiJV/KwACjIniIqtVfPiPt2sICN51cMfirYdt9/iNU9tnvH2C X-Received: by 2002:a17:902:e849:b0:1e0:b871:53f5 with SMTP id t9-20020a170902e84900b001e0b87153f5mr12629969plg.20.1711975708596; Mon, 01 Apr 2024 05:48:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711975708; cv=pass; d=google.com; s=arc-20160816; b=t3iL49pUCYtYQb4KRVsVUBdTIOlJYKnN4dmY9DOt0xfTErHv35p9HFpbaT7HZgkTgM B4S5+kyoN43FxcxgMbo+lGWCaG6byr7NXaZaY2xSS1tasbO/QtM5VGdz6kE0NA4KhUto R0mFryqvCGJ9XzoeW5Fz4LZpnV9ReBW0JA6xMpkGU9tmFTY8FlrwODTMs0B8Jwohb571 72DnxAw4xnSgZ3HTwk6sc0sYwT9HbTfAdfKbIO4hhpjQQY3Gg8MPLBjNfayLFBXjEXwC IkKd//8uSfwq7zBKG5ypDktqw+xP2brWzKg3luFvWJnyJ5onnd8MmkoDX/kiZTgnlSxy Z+ZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from; bh=hfhE/Tfp18XYwmZZlr3h66AGnNfAJrzJ/tr29jqYcf4=; fh=AtB5zqu1HeeUf1NCSeiXIqo4TTXOtgASwFoT1X8Kd70=; b=ntgDtILui6fL/sLUbj3mppVFOLD/z0IZxUyOh7ubC8L1aTsMZPjTYH3FKlvN0ZPnz+ 8WS3wykf8feOg+0XwBN86ex0VdTYpznAw+PYZ/sWCt5geO9p7TrXomB488WxWq/cBHr9 Z/xUxyMBxZPGm7P3ISa2DsEAz3tr9hE2d6eJwT3dASM3TfoLYhPtoGZDo6f12gdkojYc SKZVd/b1eWsvBp5T7oOa1YVV3UGqBdp9hgB3k6F4bb3WG3s1j+yg9D75ieQwvVevAvHa LogPVvT0IeZtJrz6ZA3jssXci8XSkWqbO2hjc+0YzXa3BJ3HrsCQaGoODWpp/CwBBsJ3 ltCA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-126661-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-126661-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id b8-20020a170903228800b001e0a7c2cc80si9434256plh.153.2024.04.01.05.48.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 05:48:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-126661-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-126661-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-126661-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9370DB208B8 for ; Mon, 1 Apr 2024 12:48:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 18E6D3E497; Mon, 1 Apr 2024 12:48:14 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90919219F9; Mon, 1 Apr 2024 12:48:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711975693; cv=none; b=gSDWUblcEzSu9fUlx1di/vhRwau8Jid2Dql6o2P+RTjlFSyE2wev+VZiR3/kgGcH7QLQta3HNg1+5UfjNEP8VCu3zvIGwH36WFe9ketMrhywkszBIFnkHsKuieJc38Tg8N2XvbPYXtS+FZV998vxokkGF/woUBQFDqZgmK7vkZo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711975693; c=relaxed/simple; bh=2BFcbcdVntnlGcJuBtVOzuZjIQk1ui17aXdZS5wM33M=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=qnzhumR+z2R4p6E3uhsIkmRr2jI25EzS4Rp4PqMopOn8Unn6mHBnYcuL4Y1Hyi03RDSbkI7TxsB04n0SumaCPAaumS97gBPv+jkNwSaEt/YLjUUp+l3hdis8XN1+RSDk1DM1CXHt2Ve6zIEZeySZSk6T69EmI6AME6eHT2Uh9Rs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAE8EC433C7; Mon, 1 Apr 2024 12:48:12 +0000 (UTC) Received: by mercury (Postfix, from userid 1000) id 62A2410608D9; Mon, 1 Apr 2024 14:48:10 +0200 (CEST) From: Sebastian Reichel To: =?utf-8?q?Pali_Roh=C3=A1r?= , Sebastian Reichel , Andrew Davis Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20240325203129.150030-1-afd@ti.com> References: <20240325203129.150030-1-afd@ti.com> Subject: Re: [PATCH 1/6] power: supply: bq27xxx: Move temperature reading out of update loop Message-Id: <171197569037.595938.587169149835280734.b4-ty@collabora.com> Date: Mon, 01 Apr 2024 14:48:10 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13.0 On Mon, 25 Mar 2024 15:31:24 -0500, Andrew Davis wrote: > Most of the functions that read values return a status and put the value > itself in an a function parameter. Update temperature reading to match. > > As temp is not checked for changes as part of the update loop, remove > the read of the temperature from the periodic update loop. This saves > I2C/1W bandwidth. It also means we do not have to cache it, fresh > values are read when requested. > > [...] Applied, thanks! [1/6] power: supply: bq27xxx: Move temperature reading out of update loop commit: c32c617de8076d8fb2a16a4a2f3b5da5f3df398d [2/6] power: supply: bq27xxx: Move time reading out of update loop commit: 651a620aa4d49f5647e21e55fc71bb049bc03389 [3/6] power: supply: bq27xxx: Move charge reading out of update loop commit: 8d846335204f25a2247e5e88e39e1604b6ecc133 [4/6] power: supply: bq27xxx: Move energy reading out of update loop commit: 39cf1c4cd03254218a23ef955bd534e19328f618 [5/6] power: supply: bq27xxx: Move cycle count reading out of update loop commit: 656489ac90f25f92190a1dd5c4e5c5293bd70323 [6/6] power: supply: bq27xxx: Move health reading out of update loop commit: 50f0ff7c8cc4c1d10fabc4b3b3f3b9e942b08187 Best regards, -- Sebastian Reichel