Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp1458138lqz; Mon, 1 Apr 2024 07:06:40 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVwUVrMpHnF/1Mrnb4dMSxbpu1Fx10OXfX+A/PErepS5RFYnIQIM5+f048b6jSbVdNz5+lVocTxPLiJ0adnkWyWuvgkqSfOfAWgyjeMmg== X-Google-Smtp-Source: AGHT+IFBg7CGWJLgcLmxxzHKExpyeV/TJSXQIHAvW8NKpBqqphQKh7Rnf4fN2Cr92BhhPW0qxcIL X-Received: by 2002:a05:6e02:1a6b:b0:368:d01c:d8d4 with SMTP id w11-20020a056e021a6b00b00368d01cd8d4mr11189767ilv.31.1711980400745; Mon, 01 Apr 2024 07:06:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711980400; cv=pass; d=google.com; s=arc-20160816; b=dT48xguF93yjI5vf1CNkw+XTUyfsAq3fvq7VJ8mHnHBVHG94QEQUsgSY0VzT8UWcK+ Uo5FSrswn+RK3sPrpJ/hPics9VsCxdXwkHeTW/K8o8ZpP6AGuXHvVhtKcppjWS0PsKfn 4Lonh2aD96kVF5WAYrIiony89ZfLkZb6ZxtDAK2tK4yCOv8yQD/6KcbKBeH+u3jH4/MM 8++ZHx7XW7BMwfqfbMpdXTuCMUiGOpgKHKDM7MkV/7cOZUPJmAw1NGxqBY+DVTSaCmrA mq4mTPUMdQvtJllZdZ+ESlIYG5vmUYkRZyY+ow4jsUG9LI3c2GohCdWTAnfxJVTEze7p AQ1A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :content-transfer-encoding:content-language:accept-language :message-id:date:thread-index:thread-topic:subject:cc:to:from; bh=GGUK1Npp8kgsVWFnmRMXyxkGaZA35gMzVcnLs6UZXdU=; fh=PbhXyTcIq6qxNqXx5fIBdBPgKQ0xc/N5MLUSHdprIPA=; b=Ml+EJ420bcQVG66csXn9l4NPWUw8hQGtfzPbpn/+vrWkfr7IhDv0tSYhG0S08YluMH tTcosBpBbSux5lN2B+LK9rDgmkxsGtVZBDWVo0Ulm2AZZFJPICPW7pbjH5raNoOEOjaZ i7RCMP9G0h3lqjVv32+a4Eo87Z3jKbk9GrnyEOIhsohAn9ROZkZtM2OAVUakeFTUs3qd 1lgjwqwId8xb/qhuJH8+KzcojivMrE/dVW2OK9A3fLVNnzDKxktQtxShVLt4JUXDtmP5 cAC57h4+7BfRifz4gOMr/WThNKcO7fdB9wx1AVUuMGq4+scd5FYshHX8WCUki4R32Bp9 d/SA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=honor.com); spf=pass (google.com: domain of linux-kernel+bounces-126699-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-126699-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id o25-20020a635a19000000b005dcc036c679si7031623pgb.677.2024.04.01.07.06.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 07:06:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-126699-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=honor.com); spf=pass (google.com: domain of linux-kernel+bounces-126699-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-126699-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 5501EB213EB for ; Mon, 1 Apr 2024 14:06:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D8E27405EB; Mon, 1 Apr 2024 14:06:17 +0000 (UTC) Received: from mta20.hihonor.com (mta20.honor.com [81.70.206.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FCE93FE52 for ; Mon, 1 Apr 2024 14:06:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=81.70.206.69 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711980377; cv=none; b=neOsBQvrvqQuugqNH/O4+saqbe6/9Bsy2pGYEEy7IzMwQeV5i7LGIRUxiCqiSxWwY3mjPsLVeN9OFVNk/Xbf3+e2Pyq+5HfY+eGWkDH7PiiTzW72jpkdSBwqTIt+R9W761HKhkaX3BIGxVqGjGj4ajXUARJEuDk+6Y+m4v4fEDc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711980377; c=relaxed/simple; bh=7Vn77MQaepkLiapMpfLmvvEmNQBRU3d+1tEdA4VbGUA=; h=From:To:CC:Subject:Date:Message-ID:Content-Type:MIME-Version; b=E7vU5pO19qKH1gdoikB4BgZGOOVb5o9Owi/3Qhs4CHUGWoFPrL1F+GXiS//QZe0rTL+evTMDmpDfOfLUphuFb9vkP7p22gefFZ8ia3uPaPuMhcVryb8HrTdgrGAJ24opBo5/cje3g6SQWxelaUIUjY+KSwuFf07DOFkrw/Ag1nI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=honor.com; spf=pass smtp.mailfrom=honor.com; arc=none smtp.client-ip=81.70.206.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=honor.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=honor.com Received: from w011.hihonor.com (unknown [10.68.20.122]) by mta20.hihonor.com (SkyGuard) with ESMTPS id 4V7XQf2SNQzYxDsy; Mon, 1 Apr 2024 21:48:10 +0800 (CST) Received: from a006.hihonor.com (10.68.23.242) by w011.hihonor.com (10.68.20.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.25; Mon, 1 Apr 2024 21:48:20 +0800 Received: from a011.hihonor.com (10.68.31.243) by a006.hihonor.com (10.68.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.25; Mon, 1 Apr 2024 21:48:20 +0800 Received: from a011.hihonor.com ([fe80::78ac:4faf:25dd:3496]) by a011.hihonor.com ([fe80::78ac:4faf:25dd:3496%7]) with mapi id 15.02.1258.025; Mon, 1 Apr 2024 21:48:20 +0800 From: wangzijie To: "jaegeuk@kernel.org" , "chao@kernel.org" CC: "linux-f2fs-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , "wangbintian(BintianWang)" Subject: [PATCH] [f2fs-dev] f2fs: use f2fs_get_node_page when write inline data Thread-Topic: [PATCH] [f2fs-dev] f2fs: use f2fs_get_node_page when write inline data Thread-Index: AdqEOdZMrsI3iA2JQyKLGLQGeOfhFw== Date: Mon, 1 Apr 2024 13:48:20 +0000 Message-ID: <2073e8995f5444aeaf7133b87ec07de8@honor.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Zijie Wang Date: Mon, 1 Apr 2024 21:24:08 +0800 Subject: [PATCH] [f2fs-dev] f2fs: use f2fs_get_node_page when write inline = data We just need inode page when write inline data, use f2fs_get_node_page() to get it instead of using dnode_of_data, which can eliminate unnecessary struct use. Signed-off-by: Zijie Wang --- fs/f2fs/inline.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c index ac00423f117b..6e20d8e7affc 100644 --- a/fs/f2fs/inline.c +++ b/fs/f2fs/inline.c @@ -242,33 +242,32 @@ int f2fs_convert_inline_inode(struct inode *inode) =20 int f2fs_write_inline_data(struct inode *inode, struct page *page) { - struct dnode_of_data dn; - int err; + struct f2fs_sb_info *sbi =3D F2FS_I_SB(inode); + struct page *ipage; =20 - set_new_dnode(&dn, inode, NULL, NULL, 0); - err =3D f2fs_get_dnode_of_data(&dn, 0, LOOKUP_NODE); - if (err) - return err; + ipage =3D f2fs_get_node_page(sbi, inode->i_ino); + if (IS_ERR(ipage)) + return PTR_ERR(ipage); =20 if (!f2fs_has_inline_data(inode)) { - f2fs_put_dnode(&dn); + f2fs_put_page(ipage, 1); return -EAGAIN; } =20 f2fs_bug_on(F2FS_I_SB(inode), page->index); =20 - f2fs_wait_on_page_writeback(dn.inode_page, NODE, true, true); - memcpy_from_page(inline_data_addr(inode, dn.inode_page), + f2fs_wait_on_page_writeback(ipage, NODE, true, true); + memcpy_from_page(inline_data_addr(inode, ipage), page, 0, MAX_INLINE_DATA(inode)); - set_page_dirty(dn.inode_page); + set_page_dirty(ipage); =20 f2fs_clear_page_cache_dirty_tag(page); =20 set_inode_flag(inode, FI_APPEND_WRITE); set_inode_flag(inode, FI_DATA_EXIST); =20 - clear_page_private_inline(dn.inode_page); - f2fs_put_dnode(&dn); + clear_page_private_inline(ipage); + f2fs_put_page(ipage, 1); return 0; } =20 --=20 2.25.1