Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp1486306lqz; Mon, 1 Apr 2024 07:50:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUrr7hd0ck+tCg/ZSIL0j5z5n78dQxsdGuvjuDvOFPib6gMRlhoTowat2YLUgwZRrhmLBDpHDp3BeWAAv5BDQxYtFp2nM8bfeamHRR5Yg== X-Google-Smtp-Source: AGHT+IHmu0jlxJHUzUTTegAvyiIXs3rOH2cXLWzBSoeXyCXZkTDfEoyab0RdM+o7c1X8lyhIgZqO X-Received: by 2002:a2e:a7c3:0:b0:2d6:b0b5:bb12 with SMTP id x3-20020a2ea7c3000000b002d6b0b5bb12mr7326248ljp.18.1711983015286; Mon, 01 Apr 2024 07:50:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711983015; cv=pass; d=google.com; s=arc-20160816; b=RN5T5kVqncX9fSLjCRMMQZv02orarc3lXkDUsUHYfK+tyijOkOnDSo3RdtBHxGoyws JSgJI6MaMkeZcvWv4JmABh5LVAtBU06D/gXL5kTMHpDAMRFylAgp4hbSZO1Tyoh/lyo+ 54h+W+O2DBrniru2Ge8TeG1BWOcQeFGwQ9xYNdn4llFojtfLNpgQbI/bmiOFQggQ5Tn/ 5kvqmlHsHJjOB5vFMHAFFzOkfC6pBO4xIaA7oDjQz625GCcBpWmuTa0UPlaUcsukN0gm yZJZFRFeTRzF5Rzi8nIJDGNiP+/7z/HQ6HThnwb5EAggwPtIevbJjTC5MNcRy/ZxZW/N FnCA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=2ADAS1NZuvWvO3SSZaOVm/ouFnP43s4Y4g/ntRX2tN8=; fh=L5xHiWtsqzTjLQwxQcIDOOiddCtg52wieVOv3hHf31M=; b=0qYY3rKFdKAj1T14xfYss7JnPFOuQ7bC/A1V2a2jyWKVVWygZKX8kHctgM3h+SCLNH JPQUVFxZgnO+NJF0aDBzdnxwzdRf98y4asqN39QiNC4vRFhU7NuspJtiqBpc9fBBx5rh xlXWdQBRDTZbZXjuwqv+9AnRBccR386BzKkFkeYDAkkpad2GnT7DOsP5zxSqBjLwY1WY ABsjsQMBoxRSwHQTbo44Etag+VgpSAyIWsrEk1dHkm2UhxiviOUWvUPLc/+aW9QSNFMS Qw/5ZfYUFTrr1CQjldD/S4y235pGR66wMEORlP4Q/XYJ5r41TbYPWkEYboe001b6gpLN qkIg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YXfpB+RM; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-126758-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-126758-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id f5-20020a50d545000000b0056c4be743c3si4571693edj.44.2024.04.01.07.50.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 07:50:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-126758-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YXfpB+RM; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-126758-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-126758-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 0480B1F22489 for ; Mon, 1 Apr 2024 14:50:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 22F71446B2; Mon, 1 Apr 2024 14:50:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YXfpB+RM" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49A0841A8F; Mon, 1 Apr 2024 14:50:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711983005; cv=none; b=tL7RcWp2Qi5/IDH5QTyGr/v7LGl21W1Ajqjl0To5+xQ5RAzQXuDtxHcN3oRBRmaR7gpm/O74Th0fUDxfb+j8n1bJ86TktslMVXdKLRL/YkigLjeA70sCqRPVGkPFeSL+4aT1OWeYJ4Cpp+gCpNLDMhkD0agjqAvRZv+jHdPJ9F4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711983005; c=relaxed/simple; bh=g1p0JxSTbPiaXdqzfHvytWBMEFzWaRM2oDNw0BLXbDM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=beXWKQ6hYDNItyeDK1Oleujs/yyaTPkX1Cx2EfUMWNBEO0zTktJoHOuZvrIVyuUcl96Ybe1KaqI0aCYn2Z6Bn6bm/mCfeUVRmIIWozZJ/6x+WNPenZUIE5Yj3Wa4iV73K3cjf5sigVp6+ad8qSrEFdY0PSpOG9ym2ikoNm0JmhA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YXfpB+RM; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F511C433F1; Mon, 1 Apr 2024 14:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711983004; bh=g1p0JxSTbPiaXdqzfHvytWBMEFzWaRM2oDNw0BLXbDM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YXfpB+RM11goqpxKtttYlK6UvF9aR8UcwfJ4cL5CtJWzh7EV9VkLbYkeXKv58ziQx H+MhTNW9PM2SEKhLM09Karx5kuEXeY00ZvvARbkyE+mlNJQx8dDymrm21yHBGFX9Up GK1bfM8GqdBdcFsaWeSZqHWEOP9mJUdSuiCQgiNBoQG6NILTSZMFLj5DTALdriUAGP sQsp3wtgC9kEQKoQuLi2U93MsH6AxDtLigxnWZLMIfIRv98bvveO02cOL3SXassvcX 1JOFyGATYyHSifK9907WxBQZVyRRXl6VV4GuaOXcen3H6CcT7M4AtNnBWlklaSlrel GjbaFKno2ZtJw== Date: Mon, 1 Apr 2024 07:50:03 -0700 From: Jakub Kicinski To: Leon Romanovsky Cc: David Ahern , Greg Kroah-Hartman , Jason Gunthorpe , Christoph Hellwig , Saeed Mahameed , Arnd Bergmann , Jiri Pirko , Leonid Bloch , Itay Avraham , Saeed Mahameed , Aron Silverton , linux-kernel@vger.kernel.org, "netdev@vger.kernel.org" , Andy Gospodarek , Junxian Huang Subject: Re: [PATCH V4 0/5] mlx5 ConnectX control misc driver Message-ID: <20240401075003.70f5cb4b@kernel.org> In-Reply-To: <20240401123003.GC73174@unreal> References: <20240214175735.GG1088888@nvidia.com> <20240304160237.GA2909161@nvidia.com> <9cc7127f-8674-43bc-b4d7-b1c4c2d96fed@kernel.org> <2024032248-ardently-ribcage-a495@gregkh> <510c1b6b-1738-4baa-bdba-54d478633598@kernel.org> <20240322135826.1c4655e2@kernel.org> <20240322154027.5555780a@kernel.org> <1cd2a70c-17b8-4421-b70b-3c0199a84a6a@kernel.org> <20240401123003.GC73174@unreal> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 1 Apr 2024 15:30:03 +0300 Leon Romanovsky wrote: > > The proposal is an attempt at a common interface and common tooling to a > > degree but independent of any specific subsystem of which many are > > supported by the device. > > > > Your responses continue to align with the notion that because the device > > can spit out ethernet frames, all diagnostics, debugging, configuration, > > etc. MUST go through networking APIs. > > > > You seem unwilling to acknowledge that devices can work for various use > > cases without a netdev driver, and thus aspects of managing that device > > should be done outside of a netdev driver. > > HNS driver is a good example of such device. It has nothing to do with > netdev and needs common and reliable way to configure FW. Sorry, I have a completely different reading of that thread. Thanks for bringing it up, tho. As I said multiple times I agree that configuring custom parameters in RDMA is a necessity. Junxian's approach of putting such code in the RDMA driver / subsystem is more than reasonable. Even better, it looks like the API is fairly narrowly defined.