Received-SPF: pass (google.com: domain of linux-kernel+bounces-126791-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Zi Yan <ziy@nvidia.com>
To: Barry Song <21cnbao@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, Barry Song <v-songbaohua@oppo.com>,
 Ryan Roberts <ryan.roberts@arm.com>,
 Kefeng Wang <wangkefeng.wang@huawei.com>, John Hubbard <jhubbard@nvidia.com>,
 David Hildenbrand <david@redhat.com>, Alistair Popple <apopple@nvidia.com>,
 Anshuman Khandual <anshuman.khandual@arm.com>,
 Catalin Marinas <catalin.marinas@arm.com>,
 David Rientjes <rientjes@google.com>, "Huang, Ying" <ying.huang@intel.com>,
 Hugh Dickins <hughd@google.com>, Itaru Kitayama <itaru.kitayama@gmail.com>,
 "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
 Luis Chamberlain <mcgrof@kernel.org>, Matthew Wilcox <willy@infradead.org>,
 Vlastimil Babka <vbabka@suse.cz>, Yang Shi <shy828301@gmail.com>,
 Yin Fengwei <fengwei.yin@intel.com>, Yu Zhao <yuzhao@google.com>
Subject: Re: [PATCH] mm: alloc_anon_folio: avoid doing vma_thp_gfp_mask in
 fallback cases
Date: Mon, 01 Apr 2024 11:20:33 -0400
Message-ID: <7E032ECE-7656-4470-8138-249BED7FB631@nvidia.com>
In-Reply-To: <20240329073750.20012-1-21cnbao@gmail.com>
References: <20240329073750.20012-1-21cnbao@gmail.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_268F9331-D064-4604-A70F-AEC44BC84C35_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ivCK3xPLbh3sPZeAhLb95Sc5y06/2IjE/2Xmiwi3xE7ZhAL/os6B+urUOIHr?=
 =?us-ascii?Q?58QQvZiYGmpuNna1rlt0/8SxmpAQMq1CoFr46zPC1hIojCVoD9xc7WhUPW73?=
 =?us-ascii?Q?zatm80y+KHx8VajVntT1IV1MClKbGguyTJf18tucDXqKERkugVqvldSxwTVx?=
 =?us-ascii?Q?7bMjkM7IUWONFEHxfN8XGH2/NUzwNHc+E6cgodZc/Vz4NUkNUHnqeXd0rTlo?=
 =?us-ascii?Q?GBBa9FtVu4Q4iGx+5U04u58O9nzzi6jqZKVdD2/8kxiezhfKDTLuKzJBf6wM?=
 =?us-ascii?Q?IP9rzmjfeC1u4DD7GoczJ2MP1WR+1BlrXGvr4D61O25DZlbHxpuY7BDNDRnR?=
 =?us-ascii?Q?jkT312W7gkvQROrzISRdlItSbGAmqhbeMTfDBoR18xSxGApKHHm0ZI7KGqD6?=
 =?us-ascii?Q?xg6ARVYYjLHKUmCVid3jPm4ZatL4vH6Zi8yH1gytTgxnQqpVj0lNnI+sjRsU?=
 =?us-ascii?Q?lO4DjcNJuaI/BoaNFcybZetWFv/WRRAxNRDDjwd2Letd63GejmQUBObyT7RD?=
 =?us-ascii?Q?dmgpCtaiMPGfFbE8ihYEuu/F3M+Sue4OVABZCZ7Xr14EIv7I/GfAIja3Corw?=
 =?us-ascii?Q?uaJAmPTKSsc2xwoPZoPnqfA0BN2Q9LxC8WQlLOO7gX6ohhAKXv8wYgPfxECh?=
 =?us-ascii?Q?vVrlL6Mn0IsO1MLHdw8RWD4VKkHOBIzkkuDNWwgUYp78TAKtncS01qzI39fU?=
 =?us-ascii?Q?3/mBmcYgebvpsUEuwPD8rdYKqdHzVCQ2yaeFN3XkwYbsspcULHIsRVjqnFFg?=
 =?us-ascii?Q?N45pcsSffDbKhXnWide8hBYKFJ72DCVLFmWW8LnxK4fwuktspQua8wLg4vxk?=
 =?us-ascii?Q?34ZsKhrsN4TEowPGd/KlNjn7DmbqhO1oGCJAewCIMAMmOFOL/SdKV3HThRSq?=
 =?us-ascii?Q?O3z+vVJgXeiocCh7SAhuVeQB7hYl5eMPu9JU07Fc4RcLV2s6//fbO0NhhLYF?=
 =?us-ascii?Q?DsCJfYDBoW/s4Vo7lUbumV3GJBVBMMTgIilExxxV9NZf9SR83WIWH6QZbmWA?=
 =?us-ascii?Q?R6D8h/CEiDQBwJqUU/42gpH25rXFg4OFFmgT2zeSsesigdp6VcD3Qb8N1mOr?=
 =?us-ascii?Q?2CzMtTGkeiCbPjM1ET04g0bIUj7Kt/rI6aNtQHcJdA3R6bjs5BeZjnjx8WwX?=
 =?us-ascii?Q?yGGPEVvD1556zLR5IrR/VCOg3dnv2ffyKfr2PpjV8TvTFm5d1QvNTDBHUsGT?=
 =?us-ascii?Q?lw91Wtj2tJcSpfadKW3PRgheCpK8QD4+rsgkwT6pF/2hjb2B2KsbTYf9aARv?=
 =?us-ascii?Q?czdVx3ZrQcc/GNTLfltiG/175wa0IvZSSFD8cnpCAsBCDonajwMRVbPGO6x4?=
 =?us-ascii?Q?r8sTeJiGaFp+mHiwcr+Q1KvB+PlYy5Bhn3DH7wma7/WQipH/SMTXuKdJdgCO?=
 =?us-ascii?Q?/bInWw3Wzzimlnzgfl4syDl6gifgiRKAocIyxTqMUYwfhkF+YjmEkKWDsaqF?=
 =?us-ascii?Q?TFslZlUF3UDzxcviZPFafvvMfv3NLJNBOkxcNaM5/eZImbITdDRyWPtbyw+V?=
 =?us-ascii?Q?N5nm4IGu/JiTwjUnT6ni4lqA5Qgr+tK/n+E+MRsrfObmjwph3hYKQxVKEMld?=
 =?us-ascii?Q?xHe4XTWKMBK1L5kAHd4=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29643065-680d-4e97-14ac-08dc525f4861
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 15:20:37.1218
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yC8iYG0RZV04KGNu3oqawDgVKbWG+ZsWjqNV7c4lHkZwr/17fKzR5qXv35cNmzYX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7590

--=_MailMate_268F9331-D064-4604-A70F-AEC44BC84C35_=
Content-Type: text/plain

On 29 Mar 2024, at 3:37, Barry Song wrote:

> From: Barry Song <v-songbaohua@oppo.com>
>
> Fallback rates surpassing 90% have been observed on phones utilizing 64KiB
> CONT-PTE mTHP. In these scenarios, when one out of every 16 PTEs fails
> to allocate large folios, the remaining 15 PTEs fallback. Consequently,
> invoking vma_thp_gfp_mask seems redundant in such cases. Furthermore,
> abstaining from its use can also contribute to improved code readability.
>
> Cc: Ryan Roberts <ryan.roberts@arm.com>
> Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
> Cc: John Hubbard <jhubbard@nvidia.com>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Alistair Popple <apopple@nvidia.com>
> Cc: Anshuman Khandual <anshuman.khandual@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: David Rientjes <rientjes@google.com>
> Cc: "Huang, Ying" <ying.huang@intel.com>
> Cc: Hugh Dickins <hughd@google.com>
> Cc: Itaru Kitayama <itaru.kitayama@gmail.com>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Yang Shi <shy828301@gmail.com>
> Cc: Yin Fengwei <fengwei.yin@intel.com>
> Cc: Yu Zhao <yuzhao@google.com>
> Cc: Zi Yan <ziy@nvidia.com>
> Signed-off-by: Barry Song <v-songbaohua@oppo.com>
> ---
>  mm/memory.c | 3 +++
>  1 file changed, 3 insertions(+)

LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>

--
Best Regards,
Yan, Zi

--=_MailMate_268F9331-D064-4604-A70F-AEC44BC84C35_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmYK0MEPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUxtEP/A1uGF+nhEurYFe5ZmhTVbUL9vNED27qMTuX
Prrgz0wp9zIg/2vl/E8njstc7zGA6+obSxfYWUAE5UoRGAF/++MAwt1mf7QJoK3T
xcygJnSnKt0iZ5sjGymkU/l6PsMgDzHkBxy0PSYvWjGNNnFyL0PEXFHQ8MzuBirD
6EWtTMxHzMBSsJ8swIcmq4c9ChtMstP/WS9tf8Y/otk1FQok0KOcbdR4kmTg5gXp
qkjRjb+LoUjohf6CWTJB4RJelbzHsRZzu4igaVGUFS0jkCg0CEEkpaLMudsxVNH9
EIuxmykg00pwsGHWebogTiVXoqocufXbcLdnXMv8cuxvSRQlZGckS+k3kirehYEN
G9tos1Nzw3kZjd9W6uKFpmS7y6XSEQtdXqhBDnFn9+6d+UNSf5KmyUE0r6zo7tQ0
HXYhLfckM+kwv4ffwj47Jp6epdy7auxO1dDO2X7M3BrouDX+DDMX0rULA2J0fx6U
23Pjn7Y7mRw+OMoV0C7eVeLRs++hXhjn6maul1oK2jfufxVk1fxlCZkBGFyH/mSN
ZNLARH8Lw4TWQBIOgt0n2+svW3icThPGYM8zga2BgeJ+V/GDvGDrVzlR1zikdwVX
mJLPoAVAJvMin6OiGnGVbEeH3lRmQ/6pbr3Vz9g3+DuOIblV1UL0EsoVdMWLvu4V
LWlump8w
=4eXq
-----END PGP SIGNATURE-----

--=_MailMate_268F9331-D064-4604-A70F-AEC44BC84C35_=--