Received-SPF: pass (google.com: domain of linux-kernel+bounces-126802-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <2453e7d4-fd50-42ae-a322-490e7e691dc6@cornelisnetworks.com>
Date: Mon, 1 Apr 2024 11:34:23 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4] IB/hfi1: allocate dummy net_device dynamically
To: Jakub Kicinski <kuba@kernel.org>, Leon Romanovsky <leon@kernel.org>
Cc: Breno Leitao <leitao@debian.org>, Jason Gunthorpe <jgg@ziepe.ca>,
 keescook@chromium.org, "open list:HFI1 DRIVER" <linux-rdma@vger.kernel.org>,
 open list <linux-kernel@vger.kernel.org>
References: <20240319090944.2021309-1-leitao@debian.org>
 <20240401115331.GB73174@unreal> <20240401075306.0ce18627@kernel.org>
Content-Language: en-US
From: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
In-Reply-To: <20240401075306.0ce18627@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NmR3aEJBUWNlL3p2c1BpYjMvQ2NFOVdHWU1sYjQyQmhkQ0tSeTVYZmxQVXZ1?=
 =?utf-8?B?bHF0MGpXdHhaUk40ZG12STJGVlp1VThQQVU5cktORk0rOHc1ZzFkRWpZR1Q2?=
 =?utf-8?B?Wmx6cG9LT3lNeVV1NTZhNUZZa24vYUZTeEQwaXRwUDh6TVZVYVVRT1NqbGFv?=
 =?utf-8?B?NlNHbEx4M3JjMUZza2dQUmVtVW9EaGFqaWNYQ0RyTEpGVmVoaEJmM0JBRmlF?=
 =?utf-8?B?UG5jWGZyQWhGMUJFdG1HRm13c21WU1UwZmpGemZjNUNaUTBBWXJMSkxrM3JM?=
 =?utf-8?B?VlAweWw0LzQrejR2MkVZVEwzcU9Ia2t1bDBzOWRDS295RDkvVmVDMmFlN0hY?=
 =?utf-8?B?K01yRnJLQ3hPdnJBWVIyRTFKNFBiT2N5UXdFc3VPN2J1dVJFbHZ0OUJPbk1D?=
 =?utf-8?B?Rm5kbWNySEpLU0lPWjZpNzV6VmczTStoSHNHOG5xMHVQakFrOVIvOCtDYm0w?=
 =?utf-8?B?Vkx4UGoxeHhxekVXeUtWKzI3Qmx3SDFOZkxSQllQbU5TU1ZkdUN1YW5pdUFP?=
 =?utf-8?B?WDN6WTFBbElYUU5Ld2RTSnR4QUZXem41b04wT3dKYnlKanB3ZXRMRGVyMUlK?=
 =?utf-8?B?azlhc2RibG1YWEp4VkJsUnNwZ1JpVnlRZ2FYeURyc1QwU1VuTkdGdzVBMFgr?=
 =?utf-8?B?dFlyaG9zcm9VRWhibTJPVnhyM2cwaWp2TmFhdHFDR0hZdUU2UnlYNWhEZDI4?=
 =?utf-8?B?MGZCeExrTlFyeWY2K3lVbDNuUmpib2lhUy8yaGdxNlVnODllbUpiWHY0VHRV?=
 =?utf-8?B?akd0ZUN1QVNKQWl2OTkyQ084S2QySjd4SUhRV1lROEpBa0d3dkVmTkRRVWdU?=
 =?utf-8?B?dWxpK0p6WHVLb2dXK3IxNE9lcUwzK3pSY0hpMHFuRXRKcHNWdjBCejR0YTF4?=
 =?utf-8?B?dWI2ekJJeXRMNGhGeXhZUWNmUnFzMk8zZkJJbGprSnFEUWovQ091L0tFOGwz?=
 =?utf-8?B?TjZIZExFcmM4UFFzaWkrN0t3QXNjRCtKZU8xemN2d2R4dmdOZklRUU5MQ2Jx?=
 =?utf-8?B?dU44VGJCblJsdXl4eWYwRVk4VWpNOUg5bCtNdlovWHZORnRvSElETXp3c0Nl?=
 =?utf-8?B?YlBxb1lHVkVFUE9jSldya2UvN21Qam1IYWdPaVRINDArajVuUEVhSk51QUJn?=
 =?utf-8?B?YjB4dXl1M0UvS25KZHlQVGs4V3BtTHprNFlpNzNvaTk4OHNYZzRCUzRVVGM5?=
 =?utf-8?B?UncrcXZYUnRVazRua1lOck1yK3hib05QT2JnR3ZYU1pBMnZNWDh5VHRPQjI0?=
 =?utf-8?B?SExGQUYyanhsRGp1enpMaE5YQ0xxUWFEdDd5WFovenluMlVlT1JBc2xKZGx1?=
 =?utf-8?B?ZkFmMkdidXprUEUrdXluVFlUbklEcDVtWms2NkFSQWx0T2JaT2NoSXBYV2xv?=
 =?utf-8?B?cHVGZDJlMlRlUXRleDVpNklySkFYRlpCVXhTM1lDNXF5MFlnbFZaTlAzRDJR?=
 =?utf-8?B?Rkx4Ui9FUzNQVHNPblFNMllnaDZLVHgxWkwvNmRURTBYWHNKdXMvSE1pU3Ur?=
 =?utf-8?B?RGs3cTgweG5NQ0NzWTFKN01saHZvMmZ0ZDRVajI0aHAwOGJZcG1IRnNMQW8r?=
 =?utf-8?B?S2cvaHdOQ2lUK1JqdnFCRjNHZGJscVdCM2RTY0dUNkNMamJjK3BTSHFoTDBn?=
 =?utf-8?B?ZXJGN2hjTThVaVBuQVhUc0tWMGRUOGRNZEJPdlB1amZOSjl6QnJqSlRGT09T?=
 =?utf-8?B?aGNveStZS1R4NjlTUERqMmQ3cW9ET1hmazlGZnd4VWp3b3R2NDROSitST3k0?=
 =?utf-8?B?ZHkya2lmUnNzbXBlZjNYRUJPcmkvSjNBNDh4cGFYenQ0VVI4aUMvZUovNDl1?=
 =?utf-8?B?Lzgza2p3UTNzRlFrRy8rRFdMdWkrV3hZVnlsbTFmNUF2anZFNG9oSTFYc2ZO?=
 =?utf-8?B?OGdNenMzU0R1V2xzNWNvbjJiMVdMekpIWDJrZW51aC84ejVMc1FwSGE5Vnlx?=
 =?utf-8?B?NVgyOExIYmxHNTJhWVhYY0pKYkdzczFzZ3hXOGgxQVdGSGJub3cwOGFXQ0VX?=
 =?utf-8?B?Wk5KbWgrU2wzTmFCZFgvNUVWaGQyeDZvN2tEa2dXMDRDV2xNTnQyK2Q5Z3Ry?=
 =?utf-8?B?MHgzVlNncUJmYTdVQVBlbWVuaE1nZmhBblFHU1hxSGl3QVBHM1dYdzlRdGFK?=
 =?utf-8?B?MFcyTFBwVlphTjVhS04yWVAwL0dGd282Rm12UUVRYURQUEhEOFUvRUR2blov?=
 =?utf-8?Q?ScRB4h1HUMOek8QpuWLLjSY=3D?=
X-OriginatorOrg: cornelisnetworks.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c7533148-aa2b-4e60-25a6-08dc5261372c
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR01MB6158.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 15:34:27.2795
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4dbdb7da-74ee-4b45-8747-ef5ce5ebe68a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PcRbU42ZXTWJSUIZ4MloM7WqljQ9chtbSqchpvxvx6Htg6SyxFjK5tVb2iTixq3KsCXMbxKnYx0e7Bu1NgmuI/YBYcXidzpyIYwayaZUoeYDdIL8uFpxB2qRhO1ZNVP9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR01MB7635

On 4/1/24 10:53 AM, Jakub Kicinski wrote:
> On Mon, 1 Apr 2024 14:53:31 +0300 Leon Romanovsky wrote:
>> On Tue, Mar 19, 2024 at 02:09:43AM -0700, Breno Leitao wrote:
>>> Embedding net_device into structures prohibits the usage of flexible
>>> arrays in the net_device structure. For more details, see the discussion
>>> at [1].
>>>
>>> Un-embed the net_device from struct hfi1_netdev_rx by converting it
>>> into a pointer. Then use the leverage alloc_netdev() to allocate the
>>> net_device object at hfi1_alloc_rx().
>>>
>>> [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/
>>>
>>> Signed-off-by: Breno Leitao <leitao@debian.org>
>>> Acked-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>  
>>
>> Jakub,
>>
>> I create shared branch for you, please pull it from:
>> https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/log/?h=remove-dummy-netdev
> 
> Did you merge it in already?
> Turned out that the use of init_dummy_netdev as a setup function
> is broken, I'm not sure how Dennis tested this :(
> We should have pinged you, sorry.

This is what I tested, Linus 6.8 tag + cherry pick + Breno patch. So if
something went in that broke it I didn't have it in my tree.

commit 311810a6d7e37d8e7537d50e26197b7f5f02f164 (linus-master)
Author: Breno Leitao <leitao@debian.org>
Date:   Wed Mar 13 03:33:10 2024 -0700

    IB/hfi1: allocate dummy net_device dynamically

    struct net_device shouldn't be embedded into any structure, instead,
    the owner should use the priv space to embed their state into net_device.

    Embedding net_device into structures prohibits the usage of flexible
    arrays in the net_device structure. For more details, see the discussion
    at [1].

    Un-embed the net_device from struct hfi1_netdev_rx by converting it
    into a pointer. Then use the leverage alloc_netdev() to allocate the
    net_device object at hfi1_alloc_rx().

    [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/

    Signed-off-by: Breno Leitao <leitao@debian.org>

    ----
    PS: this diff needs d160c66cda0ac8614 ("net: Do not return value from
    init_dummy_netdev()") in order to apply and build cleanly.

commit 1e06cffe69e6519f8ede42c60f13ad3a7ddb09b7
Author: Amit Cohen <amcohen@nvidia.com>
Date:   Mon Feb 5 12:30:22 2024 +0200

    net: Do not return value from init_dummy_netdev()

    init_dummy_netdev() always returns zero and all the callers do not check
    the returned value. Set the function to not return value, as it is not
    really used today.

    Signed-off-by: Amit Cohen <amcohen@nvidia.com>
    Reviewed-by: Ido Schimmel <idosch@nvidia.com>
    Reviewed-by: Jiri Pirko <jiri@nvidia.com>
    Reviewed-by: Simon Horman <horms@kernel.org>
    Link: https://lore.kernel.org/r/20240205103022.440946-1-amcohen@nvidia.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>

commit e8f897f4afef0031fe618a8e94127a0934896aba (tag: v6.8)
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Sun Mar 10 13:38:09 2024 -0700

    Linux 6.8