Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764247AbYASDgn (ORCPT ); Fri, 18 Jan 2008 22:36:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761610AbYASDgf (ORCPT ); Fri, 18 Jan 2008 22:36:35 -0500 Received: from mx1.redhat.com ([66.187.233.31]:57397 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759933AbYASDge (ORCPT ); Fri, 18 Jan 2008 22:36:34 -0500 Date: Fri, 18 Jan 2008 22:32:38 -0500 From: "Frank Ch. Eigler" To: Steven Rostedt Cc: Mathieu Desnoyers , "Frank Ch. Eigler" , LKML , Ingo Molnar , Linus Torvalds , Andrew Morton , Peter Zijlstra , Christoph Hellwig , Gregory Haskins , Arnaldo Carvalho de Melo , Thomas Gleixner , Tim Bird , Sam Ravnborg , Steven Rostedt , Paul Mackerras , Daniel Walker Subject: Re: [RFC PATCH 16/22 -v2] add get_monotonic_cycles Message-ID: <20080119033238.GD27193@redhat.com> References: <20080116152838.GA970@Krystal> <20080116170011.GA3651@Krystal> <20080116201713.GA14336@Krystal> <20080117203740.GA24397@redhat.com> <20080118222637.GA30900@Krystal> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1477 Lines: 39 Hi - On Fri, Jan 18, 2008 at 05:49:19PM -0500, Steven Rostedt wrote: > [...] > > But I have not seen a lot of situations where that kind of glue-code was > > needed, so I think it makes sense to keep markers simple to use and > > efficient for the common case. > > > > Then, in this glue-code, we can put trace_mark() and calls to in-kernel > > tracers. > > I'm almost done with the latency tracer work, and there are only a total > of 6 hooks that I needed. > [...] > With the above, we could have this (if this is what I think you are > recommending). [...] > static inline trace_switch_to(struct task_struct *prev, > struct task_struct *next) > { > trace_mark(kernel_schedudule, > "prev_pid %d next_pid %d prev_state %ld", > prev->pid, next->pid, prev->pid); > > trace_context_switch(prev, next); > } I'm afraid I don't see the point in this. You could use one marker for all that data (and force the more naive tracer callbacks to ignore out some of them). You could even use two markers (and force the more naive tracer to attach to only to its favorite subset). But to use a second, different, less efficient, not more configurable tracing hook mechanism in the same logical spot makes no sense to me. - FChE -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/