Received-SPF: pass (google.com: domain of linux-kernel+bounces-126866-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: linux-kernel@vger.kernel.org
Cc: linux-media@vger.kernel.org,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Ricardo Ribalda <ribalda@chromium.org>,
 Mauro Carvalho Chehab <mchehab@kernel.org>,
 "hn.chen" <hn.chen@sunplusit.com>, Hans Verkuil <hverkuil@xs4all.nl>,
 Sergey Senozhatsky <senozhatsky@chromium.org>
Subject:
 Re: [PATCH] media/uvcvideo: add quirk for invalid dev_sof in Logitech C920
Date: Mon, 01 Apr 2024 18:45:16 +0200
Message-ID: <6046664.lOV4Wx5bFT@natalenko.name>
In-Reply-To: <20240325142611.15550-1-oleksandr@natalenko.name>
References: <20240325142611.15550-1-oleksandr@natalenko.name>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart4923946.31r3eYUQgx";
 micalg="pgp-sha256"; protocol="application/pgp-signature"

--nextPart4923946.31r3eYUQgx
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"; protected-headers="v1"
From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: linux-kernel@vger.kernel.org
Date: Mon, 01 Apr 2024 18:45:16 +0200
Message-ID: <6046664.lOV4Wx5bFT@natalenko.name>
In-Reply-To: <20240325142611.15550-1-oleksandr@natalenko.name>
References: <20240325142611.15550-1-oleksandr@natalenko.name>
MIME-Version: 1.0

On pond=C4=9Bl=C3=AD 25. b=C5=99ezna 2024 15:26:11, CEST Oleksandr Natalenk=
o wrote:
> Similarly to Logitech C922, C920 seems to also suffer from a firmware
> bug that breaks hardware timestamping.
>=20
> Add a quirk for this camera model too.
>=20
> Before applying the quirk:
>=20
> ```
> 100 (4) [-] none 100 200717 B 212.919114 213.079004 33.727 fps ts mono/SoE
> 101 (5) [-] none 101 200889 B 213.003703 213.114996 11.822 fps ts mono/SoE
> 102 (6) [-] none 102 200926 B 213.035571 213.146999 31.379 fps ts mono/SoE
> 103 (7) [-] none 103 200839 B 213.067424 213.179003 31.394 fps ts mono/SoE
> 104 (0) [-] none 104 200692 B 213.293180 213.214991 4.430 fps ts mono/SoE
> 105 (1) [-] none 105 200937 B 213.322374 213.247001 34.254 fps ts mono/SoE
> 106 (2) [-] none 106 201013 B 213.352228 213.279005 33.496 fps ts mono/SoE
> =E2=80=A6
> ```
>=20
> After applying the quirk:
>=20
> ```
> 154 (2) [-] none 154 192417 B 42.199823 42.207788 27.779 fps ts mono/SoE
> 155 (3) [-] none 155 192040 B 42.231834 42.239791 31.239 fps ts mono/SoE
> 156 (4) [-] none 156 192213 B 42.263823 42.271822 31.261 fps ts mono/SoE
> 157 (5) [-] none 157 191981 B 42.299824 42.303827 27.777 fps ts mono/SoE
> 158 (6) [-] none 158 191953 B 42.331835 42.339811 31.239 fps ts mono/SoE
> 159 (7) [-] none 159 191904 B 42.363824 42.371813 31.261 fps ts mono/SoE
> 160 (0) [-] none 160 192210 B 42.399834 42.407801 27.770 fps ts mono/SoE
> ```
>=20
> Link: https://lore.kernel.org/lkml/5764213.DvuYhMxLoT@natalenko.name/
> Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
> Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name>
> ---
>  drivers/media/usb/uvc/uvc_driver.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/u=
vc_driver.c
> index 723e6d5680c2e..444d7089885ea 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2573,7 +2573,8 @@ static const struct usb_device_id uvc_ids[] =3D {
>  	  .bInterfaceClass	=3D USB_CLASS_VIDEO,
>  	  .bInterfaceSubClass	=3D 1,
>  	  .bInterfaceProtocol	=3D 0,
> -	  .driver_info		=3D UVC_INFO_QUIRK(UVC_QUIRK_RESTORE_CTRLS_ON_INIT) },
> +	  .driver_info		=3D UVC_INFO_QUIRK(UVC_QUIRK_RESTORE_CTRLS_ON_INIT
> +					       | UVC_QUIRK_INVALID_DEVICE_SOF) },
>  	/* Logitech HD Pro Webcam C922 */
>  	{ .match_flags		=3D USB_DEVICE_ID_MATCH_DEVICE
>  				| USB_DEVICE_ID_MATCH_INT_INFO,
>=20

Gentle ping on this one.

Also, should I have added:

=46ixes: 5d0fd3c806b9 ("[media] uvcvideo: Disable hardware timestamps by de=
fault")

?

(it's not that this change re-enables HW timestamping, but 5d0fd3c806b9 exp=
licitly mentions C920 as affected)

=2D-=20
Oleksandr Natalenko (post-factum)
--nextPart4923946.31r3eYUQgx
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEZUOOw5ESFLHZZtOKil/iNcg8M0sFAmYK5JwACgkQil/iNcg8
M0vQbw//a6GrNbz1zBqVfcyTN5UhJIxpyiYBs2K8P5tmSMEJZbobZyX5AWZ6stWf
x5v5UTF6GZL2wWjZsr8m7V3TvzFezDS5lB+yGfE2mcoWV7ULGe+Uel9/TxFeMCZH
5Kmpkdxh8GuWXMUCd7roFSfUSLYJfON1i9HjUOInLNzKaTq5B41Gy1V5UaU1fRVN
W5iY1+SuCJjlQmn56uAlSUm+YcWQywIRM4i14W7dFBJKD07zHCJ23YBcFieiK6ql
H/MrF9koSNi1l3iPKyHyhIlvBxP/xFODFH7avR2aEmkiuVZbGD4AhrnBWnLjo0vJ
17UNno+k+/mkHLMIliZjZMA45m35Z3VKW/DqnMsuiiUV6D6EMPoo9PTPlZOf88hZ
atAHIBeCY33xUZYXRz70FiZ5GlcHRqJVMSOu3UBHFQkKsA0vTTZSGjF6mgZyA98i
obytmxaZezJbZcR53zPOKG9ABQ0dw+Ky+lhz6ARzqX8o2RHLEmRV8eyQ3lTfUSwT
9DLminOHNDw9joqL18x5+a0/MgQi5fYlICxEirFp06o/M7BARjYHwmKHXHiz1Fj+
aiptxwb36qHS3KpYqOv1dQCDxctayv+na0vyJX39fBsi+FrcX8ORgW4V/68ySIy/
mGR+mC9OIGtF33W5Mnb79+OlFnAG9TB9T8Nlce5Z8ikjgyCM4cc=
=w7/U
-----END PGP SIGNATURE-----

--nextPart4923946.31r3eYUQgx--