Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp1595631lqz; Mon, 1 Apr 2024 10:51:45 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWR2Xwy5NF8IYmkAlorqgBUktN//0nMg10Nzese8PZME+IWxfLABScnoMEfwTZAiL621gWouhzcAlc5FcjviCzkhOqBRdmJLUVbX3skSA== X-Google-Smtp-Source: AGHT+IEf7f/thOhMHGlQEcxS0KeumXaKkKNEvaA6eD251vaIlwa7IRUtPBhhfrQqcP0Bm7erB1eR X-Received: by 2002:a05:620a:29d4:b0:78b:c6bc:84d0 with SMTP id s20-20020a05620a29d400b0078bc6bc84d0mr14403564qkp.47.1711993905024; Mon, 01 Apr 2024 10:51:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711993905; cv=pass; d=google.com; s=arc-20160816; b=PNLOqDMgF8hAUgBfPYew56UmWf1KSy0dJGidrpuIblgNT0KHZhNSl9G+5quxjZ5x69 J+sQyZgImQ1536ZObKhDuAgZQHInmIie0j7EFthlTTnSwELlxSw58uWahFLjTNdxdWdD dH7jFGm3Z85vXnQvhWnZiRR8FEQrLxfSLJr8ksFfruCO8kQi56hyd2HSE0G4Obr6T+G5 cSaqzXxJSoPSiKzKU4Oe0/dnS95I64tD7sppkKtOKnAS4TqmUZvTUlS1b06lqdFZ0Ij7 JrXrEHjJbdPXxxONTbshvFohKrlT6aumQlMY528ySr74JAcrWIWA6uDKMaZbn3WWN27+ L8Gg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=/OTmkNbmoe0ZoUmaMXMYk1vr09M1+HtSGOgtYQirrCA=; fh=85KWyZCNyLOUxHC2P/HCV8cyKRBghHsSvc3u3ypUFyY=; b=SG1FzuX+v2JA41wk83MTjiybbU/9qLzyL9pIb9p4WdujncV89EkZJ8h6p1NkKiD652 g4Ls0PZYDjCTWRKLWVAv/lik3GJ6VqPa+A1J6VXAqNTyMT7G1ALjrGWDcRe1U64SoyOl 9ASoeOGtfRDHqhJqEl47nRWNXSRp6OGnMegg2luFtoyzkOd5RxfEqB2CqOVb09xAdKCa VoiL5Axmo7aRHlpTZ2oJZ7VjPD3sSchEsbQYlhCFU8aayl0G/TK65lN196QDrWxWNIXy H40ugOtqHG4pTyPasAS0+EtszGev/4p8Ms2Ylji7hlCHZ3QxvktPIkcbGitWaDiD/O1a 642A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@acm.org header.s=mr01 header.b=xaiCOF+z; arc=pass (i=1 spf=pass spfdomain=acm.org dkim=pass dkdomain=acm.org dmarc=pass fromdomain=acm.org); spf=pass (google.com: domain of linux-kernel+bounces-126924-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-126924-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id c29-20020a05620a269d00b0078be9dc787esi1077854qkp.531.2024.04.01.10.51.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 10:51:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-126924-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@acm.org header.s=mr01 header.b=xaiCOF+z; arc=pass (i=1 spf=pass spfdomain=acm.org dkim=pass dkdomain=acm.org dmarc=pass fromdomain=acm.org); spf=pass (google.com: domain of linux-kernel+bounces-126924-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-126924-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id BE72F1C21778 for ; Mon, 1 Apr 2024 17:51:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 529274DA0F; Mon, 1 Apr 2024 17:51:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="xaiCOF+z" Received: from 009.lax.mailroute.net (009.lax.mailroute.net [199.89.1.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 231F91DFE3; Mon, 1 Apr 2024 17:51:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711993895; cv=none; b=AYmaXjYzAbIaovBB7C/e3oifMZFBrLBZIvw2UZHrH7q0rDTJJUakIkM+MZsAfGkkhhY6I7WFRDbwypBJnvFpuLraKVgxz4fZNOoCW0KZcr6EjT7Chj91x7Jg9bgGIZYkJ9vUAQP0AaI8SeWz/IOhZVlwZFGVr9K/XWL4XkSJaAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711993895; c=relaxed/simple; bh=ioSWayF7uY/dgwbMcRfOuGfTwEGp+bs+y0xYOqeJp4E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Kl/UIGAkYT1ZG21nqe1bNupeVNletsERrTWYXII62hYnwl6RIwV3dtxzvZYU1pSTma8r211JFyui4GLTMrVgIlrxhZwEhcVuHkQuz1YQ3jykxA0S1YNhNzD2ihe+yiakFmkCV3tFm+E1e/7tJ2lmL7q78AXLLNtNGOWrFJDqqbg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=xaiCOF+z; arc=none smtp.client-ip=199.89.1.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Received: from localhost (localhost [127.0.0.1]) by 009.lax.mailroute.net (Postfix) with ESMTP id 4V7dqT4KsnzlgTGW; Mon, 1 Apr 2024 17:51:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:references:content-language:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1711993890; x=1714585891; bh=/OTmkNbmoe0ZoUmaMXMYk1vr 09M1+HtSGOgtYQirrCA=; b=xaiCOF+zIKeGRCeztiuU5Du0dElnRxNbejvpi12V JlMYjAZACh01rOHigixprn013YQxppKDobvDIqyrIPZwbi1t/m44wbRJ6vyxCNDD eQ3ItBsBmPWAXN/AnXhhuCsTeHm0TDIQ45zuLZDQUQlxBm2Rup2EPncjNP1bkWvc GhZ6ByJyiuvFgv9R0Ds+xjILlsa3QGXUp1QhUDmvX2uHHBfXwQAblZjlDBmaznOi tY8ePctirmA5ehlOPhCENvflwUdbBhJHfm167aljzO609WhRW2Rb6dU8rBiRLb7b DcskcX9wrNw2H2D8cij/bVFbk8TKBx7CzaJsownc31z/eQ== X-Virus-Scanned: by MailRoute Received: from 009.lax.mailroute.net ([127.0.0.1]) by localhost (009.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id C5w9o98hycQw; Mon, 1 Apr 2024 17:51:30 +0000 (UTC) Received: from [100.96.154.173] (unknown [104.132.1.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 009.lax.mailroute.net (Postfix) with ESMTPSA id 4V7dqN6X14zlgTHp; Mon, 1 Apr 2024 17:51:28 +0000 (UTC) Message-ID: <2af548ae-8877-4e8d-8dc2-541b3d6e6330@acm.org> Date: Mon, 1 Apr 2024 10:51:27 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] scsi: sd: unregister device if device_add_disk() failed in sd_probe() Content-Language: en-US To: Yu Kuai , linan666@huaweicloud.com, jejb@linux.ibm.com, martin.petersen@oracle.com, mcgrof@kernel.org, hch@lst.de, "yukuai (C)" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linan122@huawei.com, yi.zhang@huawei.com, houtao1@huawei.com, yangerkun@huawei.com References: <20231208082335.1754205-1-linan666@huaweicloud.com> <6066205b-bdc8-4434-cc2d-3ce06004ae47@huaweicloud.com> From: Bart Van Assche In-Reply-To: <6066205b-bdc8-4434-cc2d-3ce06004ae47@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/31/24 18:31, Yu Kuai wrote: > I was shocked that this patch is still there. This patch is easy and > straightforward. > > LGTM > Reviewed-by: Yu Kuai > > BTW, Nan, it will be better if you have a reporducer for this. Agreed that a reproducer would help. No information is present in the patch description about how this issue was detected nor about how it was tested. That probably would have encouraged reviewers. Bart.