Received-SPF: pass (google.com: domain of linux-kernel+bounces-126936-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 1 Apr 2024 21:12:04 +0300
From: Leon Romanovsky <leon@kernel.org>
To: Junxian Huang <huangjunxian6@hisilicon.com>
Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org, linuxarm@huawei.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-next] RDMA/hns: Support DSCP
Message-ID: <20240401181204.GC11187@unreal>
References: <20240315093551.1650088-1-huangjunxian6@hisilicon.com>
 <20240401114853.GA73174@unreal>
 <1f786e1b-e8ff-1d6f-7c4d-89724eda6712@hisilicon.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1f786e1b-e8ff-1d6f-7c4d-89724eda6712@hisilicon.com>

On Mon, Apr 01, 2024 at 09:25:39PM +0800, Junxian Huang wrote:
> 
> 
> On 2024/4/1 19:48, Leon Romanovsky wrote:
> > On Fri, Mar 15, 2024 at 05:35:51PM +0800, Junxian Huang wrote:
> >> Add support for DSCP configuration. For DSCP, get dscp-prio mapping
> >> via hns3 nic driver api .get_dscp_prio() and fill the SL (in WQE for
> >> UD or in QPC for RC) with the priority value. The prio-tc mapping is
> >> configured to HW by hns3 nic driver. HW will select a corresponding
> >> TC according to SL and the prio-tc mapping.
> >>
> >> Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com>
> >> ---
> >>  drivers/infiniband/hw/hns/hns_roce_ah.c     | 32 +++++---
> >>  drivers/infiniband/hw/hns/hns_roce_device.h |  6 ++
> >>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c  | 86 ++++++++++++++++-----
> >>  drivers/infiniband/hw/hns/hns_roce_qp.c     | 13 ++++
> >>  include/uapi/rdma/hns-abi.h                 |  9 ++-
> >>  5 files changed, 117 insertions(+), 29 deletions(-)
> > 
> > 1. What is TC mode?
> 
> TC mode indicates whether the HW is configured as DSCP mode or VLAN priority
> mode currently.
> 
> > 2. Did you post rdma-core PR?
> 
> Not yet. I was meant to wait until this patch is applied. Should I post it
> right now?

Yes, for any UAPI changes, we require to have rdma-core PR.

Thanks

> 
> Junxian
> 
> > 
> > Thanks