Received-SPF: pass (google.com: domain of linux-kernel+bounces-126937-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <ea8ef700-daf2-4408-888f-f5c93db82331@intel.com>
Date: Mon, 1 Apr 2024 11:12:23 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86/resctrl: Fix uninitialized memory read when last CPU
 of domain goes offline
To: <babu.moger@amd.com>, <fenghua.yu@intel.com>, <bp@alien8.de>,
	<james.morse@arm.com>, <tony.luck@intel.com>, <peternewman@google.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <dave.hansen@linux.intel.com>,
	<x86@kernel.org>
CC: <hpa@zytor.com>, <james.greenhalgh@arm.com>,
	<linux-kernel@vger.kernel.org>
References: <979cfd9522021aa6001f8995cd36fb56e1c9cd39.1711659804.git.reinette.chatre@intel.com>
 <133312c4-6ddb-4752-a7fa-3e7e526e9335@amd.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <133312c4-6ddb-4752-a7fa-3e7e526e9335@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2w4NzF6cXp0cnFZc3kwVnNYRzhSbTZjZzIwVGJpRjJNZG9za0tkYisyMTFE?=
 =?utf-8?B?bWpDcGdxYktyU2srNDdqek1FeVp0OHZTajVVNWZWY0FoN2dJbzFKclJReGZa?=
 =?utf-8?B?b2ZKTTRPbFJQOFZSMjk2TmVVbDc2K2duTU1oYzNFUFp4aDlMcmhCbERXdnFS?=
 =?utf-8?B?ZXlDTUkvYk56ZGpJaVltc0NUN2ZRbkJvQmorZnFGNGVma1N4N3B2TlV6TlVm?=
 =?utf-8?B?dXIvbzJMR0gzSWQxN3ZKQlY5UzVMTFhuTndPVDNBbDF6Y2RGeHd1L0xwY0o3?=
 =?utf-8?B?Mk9OUWxvaExaK0NFbmtsNithQU5JbnBtNHJhVCtxVmFiOUFQZUNza3poZldJ?=
 =?utf-8?B?bE1JRWEvMTB5Z3Z5NEdPaG81alFPTnpSY2JhTzRaY0tCdTJSMVhGTUdCZHho?=
 =?utf-8?B?OXJDUWZqUkRVd1g5c2djcWhUd29zZnJtSk92bEF1WloxczZ0UkNZMklJSVd5?=
 =?utf-8?B?WmlYenRrT0FJWkxRaTRoRUQ0KzdITTQ5VTBlMFY1bHhMUE9vZ1pVUCtqVTdR?=
 =?utf-8?B?cldVTFMrZHZiZmVLTFZFSnc0d3Yzb1p1N3dFYzJhWm83b0F6Mm1EVFlJZFlV?=
 =?utf-8?B?SWU2aUZNZkFPQ0RmUFdsbStFZVlqbFBtck9lVzJhQ2xMNnNyQVI5bVVwODR1?=
 =?utf-8?B?OXZINmdNMmh4TzNQdHNWcGYyYW5sdXBxVzJJVjRiV080SktzNnpDaTQybVV1?=
 =?utf-8?B?OXJUME1SZXBhK0pWZUJCU3dsc055eG11cGhVRk5yekxZckJxOFRQNmpHVEg3?=
 =?utf-8?B?VEM3ZUFBRUhxdE4xeWxOckV6THhqQ1dJUW5lVk9McTljRENWSnFPU2R2ZUkr?=
 =?utf-8?B?Ti8rZy9LaGVOSG1wR015Z1BiQ2tSemoxTmxobmZhSlBPMStZcDAva1ZtbFV4?=
 =?utf-8?B?WmxVcTY3WFVtQisvTWIyWUFkTzFBa1hoR1A4bW1md0lNMlhWQzdRRVBpcGdW?=
 =?utf-8?B?MlZRMW9CdWhrL3o5aEhGeVpyUUpXQVBJYksydmcrajRPZUFlK2xyajJhbHpM?=
 =?utf-8?B?QUVCNmNhOENJUkVsaHN1Wm5NZmpmcHRudXVYRHBORzFxblJPWUU1SDZxVWJy?=
 =?utf-8?B?UXB2eHFVak00L1pIWnpLTkx3NkcwNE5kSGNzeXNlb09YalF5K0RQM3JEU0JX?=
 =?utf-8?B?NWRkVU5QUjhidVRHSmxvODFvT0NHTm5udW5hVEc4WEw1eWtSTDFHVFlDc0RQ?=
 =?utf-8?B?RXVNMVYyUzVNWXJJUkxUTFZCVmQ5QWRsdWdxK1BCWERlWEhhNUZ0N3FXcmx1?=
 =?utf-8?B?MWNmTmJiMU9zME56NmxQN2dRdU5mQ2RjaCtaZGM3S1ZrM2xuMnF2bGt1Q3Ax?=
 =?utf-8?B?ejVXN05qQmhhR2JBWWFHalNNRHB2cWY0VzFCdWlBQm44OEh5SnNoeFpSS3Z4?=
 =?utf-8?B?U3VmMVZyK3VrcWdsUklNUUdZMXlUclV5czExb2dXOE5sN3hwS2hzSFRPb2Zm?=
 =?utf-8?B?R2pSbVk4ZnRwYXZjQVlTS0xtZG13UU9laFlhK2VQWVlsSXVRMGZvMkpHMHhO?=
 =?utf-8?B?YTkzaHZRTjhLbndDbldkd3M1SVNKYmo0cmtCN1NicTVDcHU3MmwxSndJZWZv?=
 =?utf-8?B?d25iWU9WVzNqRC9BNDdFWDNMdnBTOFBLUTZOQUEwNHVWcXU1d3B3MGhNbVJu?=
 =?utf-8?B?a1N1SE9YbFpoWFovUjJqaHhpZkY4dEZEVnYvWGJoLzNUa2RUdGV1RTlXQ1pQ?=
 =?utf-8?B?ZWR3MUhTdUtzUG1SSkJTb1hPOUZyS3VnRXdXTmdDQ1RCYVM4Sis2V0NpcEs4?=
 =?utf-8?B?Y0pHUjV3SEJQWnlNcFBzeWJlcWhpWU94T3FodWNsL3hBLzNGZGpTUmI5ajE3?=
 =?utf-8?B?RG1DRG1xWVNnWWxMV2o1SXdlZStRZXpDazBvUGhFcUpCODFER3dzS1ZNd0JV?=
 =?utf-8?B?OHdDOXpLRmFTblBRdFJaanBJVi83ekNiYWRpemlZNjZ2dGFpaWFVQWNkRkpp?=
 =?utf-8?B?V0JvaVY1b0thSnVpYWZrVmZ4b3Y3cmRTcHByTjFDbGNBdFJjK3pxQ2hWc212?=
 =?utf-8?B?K3NhUk5kYk5XYVFrekxTWHU1R255YTFOaUJGU1dobHBqRHhYQTFudnIzdW12?=
 =?utf-8?B?T2ZTcUprL01sVENBNHM4YVZTOVM5NEFiVHZPbEhJUjBKNmtNNnFqdXJZWGFE?=
 =?utf-8?B?Q0lJR3FzZVEzYld2QmQxVkt5UXpCbHVweVludytOQkpBVlY4eEdkU2d4UVZH?=
 =?utf-8?B?MXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 78be492e-7536-4a9d-b57e-08dc52774919
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 18:12:26.2464
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Sp8TMJrlujtoG0d4fvTZqwNl7s/ihGLTeEl2nEaPrHVtrqBYFkAn6RrOg32iRc8apWXoFPmAkwrDXvy4kQvTvho/sIkei44AAnlXzMLvNe8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8558
X-OriginatorOrg: intel.com

Hi Babu,

On 4/1/2024 10:57 AM, Moger, Babu wrote:
> On 3/28/24 16:12, Reinette Chatre wrote:

>> --- a/arch/x86/kernel/cpu/resctrl/internal.h
>> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
>> @@ -85,6 +85,10 @@ cpumask_any_housekeeping(const struct cpumask *mask, int exclude_cpu)
>>  	if (cpu < nr_cpu_ids && !tick_nohz_full_cpu(cpu))
>>  		return cpu;
>>  
>> +	/* Only continue if tick_nohz_full_mask has been initialized. */
>> +	if (!tick_nohz_full_enabled())
>> +		return cpu;
>> +
> 
> I am curious why this below check didn't fail?
> 
> if (cpu < nr_cpu_ids && !tick_nohz_full_cpu(cpu))
>   		return cpu;
> 
> The tick_nohz_full_cpu() already checks tick_nohz_full_enabled().
> 
> It should returned 'false' and  returned cpu already.
> 
> Did i miss something?
> 

The scenario occurs when the last CPU of a domain goes offline and the cpu itself
is the cpu to be excluded. In this scenario cpu >= nr_cpu_ids in the check you
quote.

You may, as did I, wonder why continue the check on a smaller set of CPUs
if the first check already failed? James addressed that in:
https://lore.kernel.org/lkml/bd8a64fa-86d3-4417-a570-36469330508f@arm.com/

Reinette