Received-SPF: pass (google.com: domain of linux-kernel+bounces-126982-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <73122f30-44b9-4868-958c-99218e5c1185@amd.com>
Date: Mon, 1 Apr 2024 14:17:18 -0500
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH] x86/resctrl: Fix uninitialized memory read when last CPU
 of domain goes offline
To: Reinette Chatre <reinette.chatre@intel.com>, fenghua.yu@intel.com,
 bp@alien8.de, james.morse@arm.com, tony.luck@intel.com,
 peternewman@google.com, tglx@linutronix.de, mingo@redhat.com,
 dave.hansen@linux.intel.com, x86@kernel.org
Cc: hpa@zytor.com, james.greenhalgh@arm.com, linux-kernel@vger.kernel.org
References: <979cfd9522021aa6001f8995cd36fb56e1c9cd39.1711659804.git.reinette.chatre@intel.com>
 <133312c4-6ddb-4752-a7fa-3e7e526e9335@amd.com>
 <ea8ef700-daf2-4408-888f-f5c93db82331@intel.com>
Content-Language: en-US
From: "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <ea8ef700-daf2-4408-888f-f5c93db82331@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UEFnUncvUi91YUNqREZ4UmRRN2hrbkZxRWVxaTFmM242YzVEZ0ppTGJ4dGRT?=
 =?utf-8?B?ZEpFVmxZc2t3SnhGN25Yd2NmankweURVVjNxeTJqT21WTUxHRERZVitGbG1D?=
 =?utf-8?B?bElvRWtoOS9qTXVqRnpoaXIvZFBuRXd1aEp1Z2hiQTdNRkN2RTBTV1BLZVkr?=
 =?utf-8?B?S2ZVckt3a3ZQL2hCVlBaNUlreDdzWDlXbHo3R0xXVHIxR29kTTlxNlNqbmlI?=
 =?utf-8?B?NU1NTzlBNkI0NURzSEVlZ0lQK2dHM3hQSGlvTzRSN3JLa2xoak9MelVxUU5h?=
 =?utf-8?B?ZEFpaUMyOWhlYVVhZk1WVDltMUZuenk1bXQ4R0pFUXBiOVU2MHFacU5DZlU0?=
 =?utf-8?B?ckFYaEM5TExLWlVhVGxoYlpKT2IvRXVteHc4ajM5UXEwazc0NlBmekplem81?=
 =?utf-8?B?cjJKRmdvZXNMbVVvTFZIZWVsT0ROWEYwd3B5MDRpbmc5ZEVUa1QrdGJJUys0?=
 =?utf-8?B?T1Zydk9qdlgwTnZMK2JFbEowSERXZmhiQWNCRlVUNmN2VGZEbitWbkxWQkxB?=
 =?utf-8?B?SWpiZ2Fxd3cxSC9rVDM2cklHOWpTa2J4eXd2YTgyR2hHcWdUNkQ2UlJuOVFt?=
 =?utf-8?B?dVJxOWRRRjhqRS9wTWR5aG9QM3l1SDRHUHpSYmE2U1ZJaTI4WFZiUElOQXRU?=
 =?utf-8?B?K0kyNW44WTYreHhTanFIMkw1K1hESWYxWGpmYUZCSjQ3TUVZaTZlTmJoZ3ho?=
 =?utf-8?B?eGY3YUdLNVFEVkFMeVdJTm52amhkQ05tMUtlc2tqU0twRUZIME5Sa2FDWktT?=
 =?utf-8?B?N0Q0V2NnMEdvN2N5bEEzaXIxZjExeUYrUFRMWCtTQXdmUXdVd1ViNVFYYWRl?=
 =?utf-8?B?OVZvL2ozVWRWbTFJSlZMZ2VmT2dVcGVrU2FhUDZyRHNabW5NcFYvOW1HUzdD?=
 =?utf-8?B?dnA3bVZuNCtQVjc0R0YxQVNOUWhrNTY1Vi9TNVBvTkpsMkpwRFRiS1RPTUpV?=
 =?utf-8?B?TlBHRjBabEZOcHFnTU5aSXlGSHlvemd2d1IwTXEwU2dGajVwSHlLUHRZSzdo?=
 =?utf-8?B?SUlaNVhWQnB3YTQ5QXlEOHkyZ3pPdzZNWFB6UFJjZjZVcWNMZzNScXY2aktn?=
 =?utf-8?B?dk5NS0VubE5xcVFpTHJ6MythbWVzbWVidnZ1enJ5U1Z2KzcwcVljKy80bkx4?=
 =?utf-8?B?QmtZT2RuQ2JYSW5UekdNWHV1RGw5aVdMQnVSUTU0WG1RNFRTYXJFSWQ1Z2ND?=
 =?utf-8?B?L0hUK2I0QlAzZDAvTkU5S1lKdE9uM2lZMW5MYzFJdzF1K1Q3dkp1MCsvTVZJ?=
 =?utf-8?B?UXNzd1orTlpaWjdHY0VYUnJLbFh3V0M3blZjM2FnZ2NCQzZoSmZLQWhNQWM3?=
 =?utf-8?B?WjIvMUM1L0FvTzZtSUsydklER0o4ZTdlK0MyM1QwVzhpc05wNTQ1ejJYdUZ4?=
 =?utf-8?B?bkxhTEE1eFhDcm5IOENiN3R2SkdLcEFNOUJGeW9WaWZqaVpIS0JqWjUzb3Fh?=
 =?utf-8?B?V3p1bkl5eWRoZmhteHdiOFNHTm55ajgwZjQ4V2ZNOGh4aWtpbkxib2RheGlB?=
 =?utf-8?B?Rm9MdEdldDg3YTRXcmN4OCttdzBaUlB5OVBGZWxrUStVNUtzRGdBRnFMMHNo?=
 =?utf-8?B?OG9JQ29GdjNsczhxTTF3UkdsUlN4YmhKcHBIWjk1azVGQjRZZU4wbnBEYXI5?=
 =?utf-8?B?VGRIWGhrTE81T1VCdnRMNHA5aVlXeittN2tCekxrc0xQcGFpbjRuaE5BVVdu?=
 =?utf-8?B?SXNVWGlPRWVjZmQ5VEpBV2hrVmozUElDVkIyU1BSOEc1RlFiZjlWNnFxTFpl?=
 =?utf-8?B?OVdydEwwS3piUmJna3NMenVldko4TGdCUkJIQkswM2paQ1JudGRMZFVvNXRJ?=
 =?utf-8?B?WnhBRW1WVEF1NFB6eFVMUjdtb041akVmd0t4U1I2c2tGSk42QmJic1lZNFlM?=
 =?utf-8?B?U3REZUEvUmlnRkVrbjlkaGhZRis5ZGtMWVVpcndCT3E1RkhTNmR0M0dCSGlJ?=
 =?utf-8?B?R2tHZUkxR2s0TGhkQkUyTDFGRnFpSWdCUGRLL0tFS1JoMW40RGpTUDd4Njdr?=
 =?utf-8?B?RzE4c1hhNXZ6NjJ1Q3MrR2wwem9idXlQc1VpQWV0TlV4UzZwZzl6bkVGdU8x?=
 =?utf-8?B?VHFiQkV4VFBycXorOEdwUkt5VmNpbDFUWHlWQmNOQVljdWtReVFjcDhDYjdI?=
 =?utf-8?Q?jmfc=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33d050b3-e06a-46d9-6b4c-08dc52805af2
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 19:17:21.6570
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V+QpI+wQ99SkGFFY2AbWWTuZFDAjzolLio8Nt4/jgUy2s3u94RRElGvi2VEJjc+f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7746


On 4/1/24 13:12, Reinette Chatre wrote:
> Hi Babu,
> 
> On 4/1/2024 10:57 AM, Moger, Babu wrote:
>> On 3/28/24 16:12, Reinette Chatre wrote:
> 
>>> --- a/arch/x86/kernel/cpu/resctrl/internal.h
>>> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
>>> @@ -85,6 +85,10 @@ cpumask_any_housekeeping(const struct cpumask *mask, int exclude_cpu)
>>>  	if (cpu < nr_cpu_ids && !tick_nohz_full_cpu(cpu))
>>>  		return cpu;
>>>  
>>> +	/* Only continue if tick_nohz_full_mask has been initialized. */
>>> +	if (!tick_nohz_full_enabled())
>>> +		return cpu;
>>> +
>>
>> I am curious why this below check didn't fail?
>>
>> if (cpu < nr_cpu_ids && !tick_nohz_full_cpu(cpu))
>>   		return cpu;
>>
>> The tick_nohz_full_cpu() already checks tick_nohz_full_enabled().
>>
>> It should returned 'false' and  returned cpu already.
>>
>> Did i miss something?
>>
> 
> The scenario occurs when the last CPU of a domain goes offline and the cpu itself
> is the cpu to be excluded. In this scenario cpu >= nr_cpu_ids in the check you
> quote.
> 
> You may, as did I, wonder why continue the check on a smaller set of CPUs
> if the first check already failed? James addressed that in:
> https://lore.kernel.org/lkml/bd8a64fa-86d3-4417-a570-36469330508f@arm.com/
> 

Got it.
-- 
Thanks
Babu Moger