Received-SPF: pass (google.com: domain of linux-kernel+bounces-127060-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 1 Apr 2024 13:54:54 -0700
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Nikita Kiryushin <kiryushin@ancud.ru>,
	Frederic Weisbecker <frederic@kernel.org>,
	Neeraj Upadhyay <quic_neeraju@quicinc.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	Josh Triplett <josh@joshtriplett.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Zqiang <qiang.zhang1211@gmail.com>, rcu@vger.kernel.org,
	linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH v3] rcu: Fix buffer overlow in print_cpu_stall_info()
Message-ID: <e8d0f4da-d3af-4bf2-9413-ac48bd2661d7@paulmck-laptop>
Reply-To: paulmck@kernel.org
References: <20240401150540.6dab14fc@gandalf.local.home>
 <20240401194315.362090-1-kiryushin@ancud.ru>
 <20240401160312.7b03e568@gandalf.local.home>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240401160312.7b03e568@gandalf.local.home>

On Mon, Apr 01, 2024 at 04:03:12PM -0400, Steven Rostedt wrote:
> On Mon,  1 Apr 2024 22:43:15 +0300
> Nikita Kiryushin <kiryushin@ancud.ru> wrote:
> 
> > rcuc info output in print_cpu_stall_info() contains
> > posiible buffer overflow in the case of huge jiffies
> > difference. The situation seems improbable, but, buffer
> > overflow, still.
> > 
> > Also, unsigned jiffies difference printed as (signed)
> > %ld. This is intentional for debugging purposes, but
> > it is not obvious from the code.
> > 
> > Change sprintf to snprintf and add clarifying comment
> > about intention of %ld format.
> > 
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> > 
> > Fixes: 245a62982502 ("rcu: Dump rcuc kthread status for CPUs not reporting quiescent state")
> > Signed-off-by: Nikita Kiryushin <kiryushin@ancud.ru>
> > ---
> > v3: Change intention comment wording as
> > Steven Rostedt <rostedt@goodmis.org> suggested
> > v2: Remove signed to unsigned print format change as
> > Paul E. McKenney <paulmck@kernel.org> suggested, add format
> > intention clarification comment
> >  kernel/rcu/tree_stall.h | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h
> > index 5d666428546b..320440b8384e 100644
> > --- a/kernel/rcu/tree_stall.h
> > +++ b/kernel/rcu/tree_stall.h
> > @@ -504,7 +504,8 @@ static void print_cpu_stall_info(int cpu)
> >  			rcu_dynticks_in_eqs(rcu_dynticks_snap(cpu));
> >  	rcuc_starved = rcu_is_rcuc_kthread_starving(rdp, &j);
> >  	if (rcuc_starved)
> > -		sprintf(buf, " rcuc=%ld jiffies(starved)", j);
> > +		/* Print signed value, as negative means it is likely a bug */
> > +		snprintf(buf, sizeof(buf), " rcuc=%ld jiffies(starved)", j);
> >  	pr_err("\t%d-%c%c%c%c: (%lu %s) idle=%04x/%ld/%#lx softirq=%u/%u fqs=%ld%s%s\n",
> >  	       cpu,
> >  	       "O."[!!cpu_online(cpu)],
> 
> 
> Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>

Queued for v6.10, thank you both!

							Thanx, Paul