Received-SPF: pass (google.com: domain of linux-kernel+bounces-127126-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Frank Li <Frank.Li@nxp.com>
Date: Mon, 01 Apr 2024 18:25:03 -0400
Subject: [PATCH 1/7] arm64: dts: imx8-ss-lsio: fix pwm lpcg indices
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240401-dts_fix-v1-1-8c51ce52d411@nxp.com>
References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com>
In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com>
To: Rob Herring <robh+dt@kernel.org>, 
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
 Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, 
 Sascha Hauer <s.hauer@pengutronix.de>, 
 Pengutronix Kernel Team <kernel@pengutronix.de>, 
 Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, 
 Marcel Ziswiler <marcel.ziswiler@toradex.com>, 
 Philippe Schenker <philippe.schenker@toradex.com>, 
 Max Krummenacher <max.krummenacher@toradex.com>, 
 Alexander Stein <alexander.stein@ew.tq-group.com>, 
 Joakim Zhang <qiangqing.zhang@nxp.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
 linux-kernel@vger.kernel.org, Frank Li <Frank.Li@nxp.com>, 
 stable@vger.kernel.org
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
 =?utf-8?B?ZXhBc1BqdjBudmhPUUtDbVRyU1BabVhRenJFNlBMN0FvV3YwSEFrR2lFZ0Q1?=
 =?utf-8?B?Zm4rdGRPM1pjVHZnQWg4Z3hjVVNRWDFESHp6VlRldFVxaHNOYXh3ZklaRUtJ?=
 =?utf-8?B?WElJUU00NWEzc1pickdQT0xmWHNvajdic050eDg2Q016VTkvakVhWVNMZU9Y?=
 =?utf-8?B?a3A5aXhTRGxRclFwS3FvdjNHTkgvLzQzTklEK3Nqd3FRcXJXZnM5SEF4Wmh3?=
 =?utf-8?B?MGxpS2FSMlpUT1VEQXNDV0NZbHgyMy8raWlXSjczQUpsRWIzdzVOYWRaV01a?=
 =?utf-8?B?OWVvaDhrb0F0RENLcE5EUXRvM050S1h5Z2NOeUFiRFhCOUI3bmx4aHNHZlht?=
 =?utf-8?B?czREL2lzL0pHTVpLUmNvRlF2Z1lvVHhiaHJFRzhyZlB3NWhYZUovTnoyT1Zl?=
 =?utf-8?B?dVU4WElFalR1WkI0MHZiOVltSWdqSFJQWC9Qc3V6QmRsSTdUREZVMTd5Uks3?=
 =?utf-8?B?VGlVcUpHQVE5WXduWGNEUjhoOTZSU09zbkxhQ3lYSjVrUkJyWGNSYU5JYkV5?=
 =?utf-8?B?SlVBUUFIRHlxZWZNYWVRTFF2VUpOei9EdG1wdjAwVlQ1WklES3BLT3Z0UHE0?=
 =?utf-8?B?S282NncyeFppVi96Wmd2b2VVY2tiZWFWTjVtaEFaUEYwd0owR2ZsQVlpZnRh?=
 =?utf-8?B?NmxIRHI1M0txVXRXOGJtdFRBYXA5U2VHMG9CcVFsQzI3eHMrNFVYTjVveVNS?=
 =?utf-8?B?eko3VURJM0hLMHhRQ3hPWU5FNlFkRkdQODRvMWFpL0JHajZIamVic0JZWEhS?=
 =?utf-8?B?SHZGU1l0ZUpPQSthM1BIMDlZOCtUZ3hXclRMcE5JbG9VUnpsSzNONUphL05E?=
 =?utf-8?B?RzFOdGh0YW1GQzhuQkw4L1ZtL0x6ai9YcFpqcmJhUUdxRW9QVHBpZWJOZU1U?=
 =?utf-8?B?elZSRlpQd3pYdUdlaXB2cU9TeG9RVWtWZmhXZlRhenBkR3JrUFRCdGtKckw1?=
 =?utf-8?B?dmZXeHNUbW8yVUNsUW1KM1M3c2FGVnFORWRlaHEySHgvZGszcE91Y2FoSU8z?=
 =?utf-8?B?aUttekFySHFNNGwzZVJIbkVSSmp0b2V4ZlN4UTUzbkR2dkNmekhGL2JXSEhz?=
 =?utf-8?B?UmhhNm5kT01OY3VveUZGTXo2eUdTZC9xYWU0cWhjcVVzS0g5dmFGOUJ3cSt0?=
 =?utf-8?B?MFdRUHo2anNuRVYvTkhidSs3Z2JmMkNENzZNVE9QWGxoYStMRllOakp6QXFw?=
 =?utf-8?B?ZWdyeENDbE9qRTc3VHh2SjBCbXd4a2lBYURDRTVDTVJzWjg5L2NLZ0UwK2FQ?=
 =?utf-8?B?anBETWdyMXZ5c2h6RVRYd0J1NldNN3pTZ1U3WmZWakFKQlUzZHcxRFVSbFZz?=
 =?utf-8?B?N2V5SHhNSXlYRU1OMFI3aFQydkdqTkVQVkNNT1dzTWJpL25DZWZoS3I3OFVt?=
 =?utf-8?B?Qk40aEN6Z2tvdlg3T3IwYXdXZ1BNZXk3ZWdiTHNwUm44K1h6Rk8xMHVHTENE?=
 =?utf-8?B?MnhmdGcreE52czRMcUpBVW1RZVFoeTQyU1g4WEZzVFRVR0dYaW5pTVFHTEZV?=
 =?utf-8?B?cVhSSmVlcFRMdnE2MlA4TUM0ek55RkYzRDE2dGRyYnlzblFkUTdvcnhYbUdL?=
 =?utf-8?B?NHBDRnp3NGlXTWIzMlN1b1B5bGZEVitDbFBTNk9iUlJsMUJUTDZuUDN6UU1J?=
 =?utf-8?B?bmZkc213YWNrYTRFbkdiNlBoZ2JpUWg2V3V5ZFZzSmdseFlJRXQzSjJJOTZQ?=
 =?utf-8?B?dWF3RXlQdmRTb2VXcWNrSXdWWjVxVWtjaHpBbHpUZFEvSW0wWWIvK1djcGo4?=
 =?utf-8?B?OW5zMkt2UnpSMDZyeENZREt6T2RReWJSWk4vVFhxdUxBNGdMZU9xc082eHBz?=
 =?utf-8?B?azhrWEt0MndGOVc3bHhzNG1Vak5PdHI5WUcrei9jR3lxSldiWmVzc2FpSzkx?=
 =?utf-8?B?d0pxM3puc2FQOW81cWhGVWRpcU1DUFdSOCtiUnNLV3pacFY3Z0NtSkpoZWR2?=
 =?utf-8?B?SGNYdGZqS05nTE1hcithWGVzb3pwWm9tOXNpUUU5NExBNXNqRzN2K3RnUFFj?=
 =?utf-8?B?TU84VTRQY2dIczZqVm9JYkJ6QWlrRmdBMG4ra2F2d1NOc0YvcGdMcGFNMlNK?=
 =?utf-8?B?NW9tRGE1WHdoekhqdE90V0RQVys1REVqZFY4dWJkS0RuZXFwM2VGVXJLaWtK?=
 =?utf-8?Q?o4SA=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea7c370d-2f9c-4679-e919-08dc529aa8e1
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:25:39.2519
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3iEz77DGTp4TIsNJ9TenXo8PBYZXuJDf1aIpALEPTLFd039q8Z5+9NrbBUbKZZWdFwJmnIEb2mcNPOdHrKDFEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976

lpcg's arg0 should use clock indices instead of index.

pwm0_lpcg: clock-controller@5d400000 {
	...                                                // Col1  Col2
	clocks = <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>,  // 0     0
		 <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>,  // 1     1
		 <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>,  // 2     4
		 <&lsio_bus_clk>,                          // 3     5
		 <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>;  // 4     6
	clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_1>,
			<IMX_LPCG_CLK_4>, <IMX_LPCG_CLK_5>,
			<IMX_LPCG_CLK_6>;
};

Col1: index, which exited dts try to get.
Col2: actual index in lpcg driver.

pwm1 {
	....
	clocks = <&pwm1_lpcg 4>, <&pwm1_lpcg 1>;
                             ^^              ^^
should be:

	clocks = <&pwm1_lpcg IMX_LPCG_CLK_6>, <&pwm1_lpcg IMX_LPCG_CLK_1>;
};

Arg0 is divided by 4 in lpcg driver, so index 0 and 1 will be get by pwm
driver, which are same as IMX_LPCG_CLK_6 and IMX_LPCG_CLK_1. Even it can
work, but code logic is wrong. Fixed it by use correct indices.

Cc: stable@vger.kernel.org
Fixes: 23fa99b205ea ("arm64: dts: freescale: imx8-ss-lsio: add support for lsio_pwm0-3")
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi
index 7e510b21bbac5..764c1a08e3b11 100644
--- a/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi
@@ -25,8 +25,8 @@ lsio_pwm0: pwm@5d000000 {
 		compatible = "fsl,imx27-pwm";
 		reg = <0x5d000000 0x10000>;
 		clock-names = "ipg", "per";
-		clocks = <&pwm0_lpcg 4>,
-			 <&pwm0_lpcg 1>;
+		clocks = <&pwm0_lpcg IMX_LPCG_CLK_6>,
+			 <&pwm0_lpcg IMX_LPCG_CLK_1>;
 		assigned-clocks = <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>;
 		assigned-clock-rates = <24000000>;
 		#pwm-cells = <3>;
@@ -38,8 +38,8 @@ lsio_pwm1: pwm@5d010000 {
 		compatible = "fsl,imx27-pwm";
 		reg = <0x5d010000 0x10000>;
 		clock-names = "ipg", "per";
-		clocks = <&pwm1_lpcg 4>,
-			 <&pwm1_lpcg 1>;
+		clocks = <&pwm1_lpcg IMX_LPCG_CLK_6>,
+			 <&pwm1_lpcg IMX_LPCG_CLK_1>;
 		assigned-clocks = <&clk IMX_SC_R_PWM_1 IMX_SC_PM_CLK_PER>;
 		assigned-clock-rates = <24000000>;
 		#pwm-cells = <3>;
@@ -51,8 +51,8 @@ lsio_pwm2: pwm@5d020000 {
 		compatible = "fsl,imx27-pwm";
 		reg = <0x5d020000 0x10000>;
 		clock-names = "ipg", "per";
-		clocks = <&pwm2_lpcg 4>,
-			 <&pwm2_lpcg 1>;
+		clocks = <&pwm2_lpcg IMX_LPCG_CLK_6>,
+			 <&pwm2_lpcg IMX_LPCG_CLK_1>;
 		assigned-clocks = <&clk IMX_SC_R_PWM_2 IMX_SC_PM_CLK_PER>;
 		assigned-clock-rates = <24000000>;
 		#pwm-cells = <3>;
@@ -64,8 +64,8 @@ lsio_pwm3: pwm@5d030000 {
 		compatible = "fsl,imx27-pwm";
 		reg = <0x5d030000 0x10000>;
 		clock-names = "ipg", "per";
-		clocks = <&pwm3_lpcg 4>,
-			 <&pwm3_lpcg 1>;
+		clocks = <&pwm3_lpcg IMX_LPCG_CLK_6>,
+			 <&pwm3_lpcg IMX_LPCG_CLK_1>;
 		assigned-clocks = <&clk IMX_SC_R_PWM_3 IMX_SC_PM_CLK_PER>;
 		assigned-clock-rates = <24000000>;
 		#pwm-cells = <3>;

-- 
2.34.1