Received-SPF: pass (google.com: domain of linux-kernel+bounces-127127-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Frank Li <Frank.Li@nxp.com>
Date: Mon, 01 Apr 2024 18:25:04 -0400
Subject: [PATCH 2/7] arm64: dts: imx8-ss-conn: fix usb lpcg indices
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240401-dts_fix-v1-2-8c51ce52d411@nxp.com>
References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com>
In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com>
To: Rob Herring <robh+dt@kernel.org>, 
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
 Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, 
 Sascha Hauer <s.hauer@pengutronix.de>, 
 Pengutronix Kernel Team <kernel@pengutronix.de>, 
 Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, 
 Marcel Ziswiler <marcel.ziswiler@toradex.com>, 
 Philippe Schenker <philippe.schenker@toradex.com>, 
 Max Krummenacher <max.krummenacher@toradex.com>, 
 Alexander Stein <alexander.stein@ew.tq-group.com>, 
 Joakim Zhang <qiangqing.zhang@nxp.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
 linux-kernel@vger.kernel.org, Frank Li <Frank.Li@nxp.com>, 
 stable@vger.kernel.org
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
 =?utf-8?B?R2p5M2tCVkZZMitiZjNvMXdadFJNR3pySUwwcjNlVnAvZ1puamVFWkdtUXo5?=
 =?utf-8?B?UEUwMGV0ekZMMDlaVlpNQUo3b0NXUUNHYWRoMWtBaXM1UFBDMWdVS1FaYkNE?=
 =?utf-8?B?dnNzaW5XUFNRb09yVjBuRWxCUU1PZzcydytsV0xKMTliNzVORGg4K0h1SmFP?=
 =?utf-8?B?ejZZRTlCcnk0RExYMnJqMGFTZmdrblhxVEd0allQTWx0ckF3N1dwbDVlaHdm?=
 =?utf-8?B?RXpjdFhKei8rL201M3JJdmxYVnFWNlM4OWZaWHEySDZ1bGlIcU9id3ROa1Q5?=
 =?utf-8?B?TzZXNUlGUm51U1ZQZDhYR2RKRk5RQ3pxSTdmb2VEWk56RTE0MWVoNEQ4cTlY?=
 =?utf-8?B?RTlQSExvRUk2a2d6eVF6anIySFl2UUdkZERienRzOExNWDlDVkdTQmhTUGpL?=
 =?utf-8?B?bE1sQkhiREJOcEM3ZDBUbHBwS0huRXVwL3p1S2V2eGgxb2J3U2lsU2N3bVBM?=
 =?utf-8?B?NGdGM1NPQWtjSGY0S25Xdk5MMXBwSHlzOXgrallscklicUo4MmkyQTFzM0hZ?=
 =?utf-8?B?YTdPRStFNmlMa0F1N2JvUGVlVWJ3a1RiUnNyc21xbnptUnpycVJkQWwyd2pK?=
 =?utf-8?B?K1grZTlsUFZqWnJtV3ErTHhJZFBDNEZtQ3FBa2pNN3BnbmpNZW1wTmFBdFZP?=
 =?utf-8?B?QlpEOCtiZ2RkYVE3ZEZRc2hRWkVOTU56VXp0cVdxWHhPTFhzOUFlTlVjZkRp?=
 =?utf-8?B?RjEwalJzVStkZjAzb3lUSUtUZ1ZYQThGaXBjMUV4eENEK2taM1REWXRuNkQz?=
 =?utf-8?B?Vy9vTmhXcnNaM3RnaGE5TEFGWGo3NEo3U3UxTEozODBGR21kenJQNklhN2NL?=
 =?utf-8?B?SUVBTTFpTWREVCtERVVrcDFPVmt0clFMQ1FRSTJGZWZQdzZrZnFiaCt4b2Vy?=
 =?utf-8?B?bmVSa2RTekpkWU5zNUI3N3JMRWRBTmo0aHp3dGJEdWhVZlJEaUpKdkV2R01H?=
 =?utf-8?B?Qk9hcDFLMGJmNENuZzQ5bEFmTXYvSzlUTU5TMWx5L0I4THRiekxwWXNzMHR0?=
 =?utf-8?B?TkJFM2JybzBpVzhJd3JtTTNPTUZkYnJ0TCtCTVUwc1dLS1pwQUp1aVF0SXdF?=
 =?utf-8?B?eXVOSDEzbEtlNFlubFpzdU1kQTNCS3RienA3dDVVbERpMFErck5oZTEvaFd5?=
 =?utf-8?B?SnpJZW1QYkszN0NHYWZ2Smo1NkhyQS9kcU1HcGhGbDN3SmVaVHVmRGMybXly?=
 =?utf-8?B?Q2RqdCs3T3VIY0Jvd1hkRUFsRXVkYlZYdXRCOWRJN3A1YmNjMlpycXdNVitR?=
 =?utf-8?B?Vmc4TVNyZk5pSGtkYXROV2Zob3hFVERZZE1Za1JRd0QvTUk3TkcwME1VK0FH?=
 =?utf-8?B?SjIyZHhLVzFCVzNKT0lad2ZyVFNNdUMrVFp6c2hWaXVIcHNPREJBTm03UFVy?=
 =?utf-8?B?aWRQWElEZFNPVmswU1FGVlNPL2pIMWZhazRQc0FQK1NOcVljQUt6azZXRWRh?=
 =?utf-8?B?Z2phYVMwY3dubFErQWZvZ1NyblRxMnpYalVjQURiOG1taU1qOFJFUmpRdDls?=
 =?utf-8?B?MGtkd2ttQXFpTFJoaFVvV3B0U2lsSE5laEkwN2JCU05GVnBLSDVkNkhka2tw?=
 =?utf-8?B?eHVpWm9PeXgwb05NYUY2SFZKZy96ZjZIei80TDBqRC9wNTZ2SkIwUHhhdVBp?=
 =?utf-8?B?Y2luQ2VxN3JOYWU5MmhSZlZuOEk5SGIyT1VDdnM2bDlSNVQrQ2pXSEp3dDV0?=
 =?utf-8?B?ZzgzaEtWNHlhb1gxeS9tb3lXdVB0aFVGNmRudndhd2dyOXBGcFdRTG9PTUFo?=
 =?utf-8?B?L3V3aVQvbjJDZ3BNTldqbE1peG1zYUp6Q1dRMTZrK3BrdkdLcmNrbGlHeDZP?=
 =?utf-8?B?b3lLU3VHNkdhRXNkQ0tTT0dQdTlxSUlHQnZXYjJ0SC82dnJyMVNjZXJ6VlVw?=
 =?utf-8?B?QXJOUjlTeXQ2L2dwWG1YNUZLMHoyN0pQNThpall2a2pGQitSbkRmdkZueWNF?=
 =?utf-8?B?ZWFrV1ZZR3YwWFRxcldIN3hrK0t1VVM3VzlyTzU4ZnZQbVE0Uk9XYmNoT3k5?=
 =?utf-8?B?VkRWbW01d09rRlpLWHVGUTk1L2h1b0dESVFZQWovNmRLZnBSTkQvcVoxQjE4?=
 =?utf-8?B?TFM3YnhvRnpRRWVWUWd4ekZ2YjBXWkt4RU5CYTNMdkRLVG5SYmhtU0Q3KzRw?=
 =?utf-8?Q?yKZM=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 947c0415-54bc-4302-e2a8-08dc529aab67
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:25:43.4909
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JEO0tk8PdJKL/3zAaBCsbZmukXMvnFvp/utTHmB2XDDrS4TU+sWKFGywzCb2KoMBARVC6tCfnCgeodgiB92opQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976

usb2_lpcg: clock-controller@5b270000 {
	...                                                    Col1  Col2
	clocks = <&conn_ahb_clk>, <&conn_ipg_clk>;           // 0     6
	clock-indices = <IMX_LPCG_CLK_6>, <IMX_LPCG_CLK_7>;  // 0     7
        ...
};

Col1: index, which exited dts try to get.
Col2: actual index in lpcg driver.

usbotg1: usb@5b0d0000 {
	...
	clocks = <&usb2_lpcg 0>;
			     ^^
Should be:
	clocks = <&usb2_lpcg IMX_LPCG_CLK_6>;
};

usbphy1: usbphy@5b100000 {
	clocks = <&usb2_lpcg 1>;
			     ^^
SHould be:
	clocks = <&usb2_lpcg IMX_LPCG_CLK_7>;
};

Arg0 is divided by 4 in lpcg driver. So lpcg will do dummy enable. Fix it
by use correct clock indices.

Cc: stable@vger.kernel.org
Fixes: 8065fc937f0f ("arm64: dts: imx8dxl: add usb1 and usb2 support")
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
index 3c42240e78e24..d862d2285d208 100644
--- a/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
@@ -41,7 +41,7 @@ usbotg1: usb@5b0d0000 {
 		interrupts = <GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>;
 		fsl,usbphy = <&usbphy1>;
 		fsl,usbmisc = <&usbmisc1 0>;
-		clocks = <&usb2_lpcg 0>;
+		clocks = <&usb2_lpcg IMX_LPCG_CLK_6>;
 		ahb-burst-config = <0x0>;
 		tx-burst-size-dword = <0x10>;
 		rx-burst-size-dword = <0x10>;
@@ -58,7 +58,7 @@ usbmisc1: usbmisc@5b0d0200 {
 	usbphy1: usbphy@5b100000 {
 		compatible = "fsl,imx7ulp-usbphy";
 		reg = <0x5b100000 0x1000>;
-		clocks = <&usb2_lpcg 1>;
+		clocks = <&usb2_lpcg IMX_LPCG_CLK_7>;
 		power-domains = <&pd IMX_SC_R_USB_0_PHY>;
 		status = "disabled";
 	};

-- 
2.34.1