Received-SPF: pass (google.com: domain of linux-kernel+bounces-127130-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Frank Li <Frank.Li@nxp.com>
Date: Mon, 01 Apr 2024 18:25:07 -0400
Subject: [PATCH 5/7] arm64: dts: imx8-ss-dma: fix adc lpcg indices
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240401-dts_fix-v1-5-8c51ce52d411@nxp.com>
References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com>
In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com>
To: Rob Herring <robh+dt@kernel.org>, 
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
 Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, 
 Sascha Hauer <s.hauer@pengutronix.de>, 
 Pengutronix Kernel Team <kernel@pengutronix.de>, 
 Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, 
 Marcel Ziswiler <marcel.ziswiler@toradex.com>, 
 Philippe Schenker <philippe.schenker@toradex.com>, 
 Max Krummenacher <max.krummenacher@toradex.com>, 
 Alexander Stein <alexander.stein@ew.tq-group.com>, 
 Joakim Zhang <qiangqing.zhang@nxp.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
 linux-kernel@vger.kernel.org, Frank Li <Frank.Li@nxp.com>, 
 stable@vger.kernel.org
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
 =?utf-8?B?OVE1NWNCZnMzTUJYZlV6bHpieVY1NnV0RjBzUjlqcVdSdVNNcEdHZ090Um1T?=
 =?utf-8?B?MTdXb2YrRlI4UWhOZUFCblJjK2lSSStUaHplWjBwbWZtZU5wVXRXSkJlNkV2?=
 =?utf-8?B?TjRPNkNCRWFQNVRhNGQzOFVudC9OVG5IcnpwdWQvdm8vUkFjSllKTnZISTlV?=
 =?utf-8?B?dXB3MlVCRzdTdEoxbmtjWWpvYll6TitjaXBFdjdublk3UnhjL1ErazJiVS80?=
 =?utf-8?B?OGFncmwzdElPcWF1T24rVVJLQzViL0xzV2xNM0FHajdjdldIUXl0RE1QR1d5?=
 =?utf-8?B?dG1Xc3duS3BYUHh3cEZCZ25JbzJlWGxjd0Jxd2liNU1DWDVsNVpUZE43bk13?=
 =?utf-8?B?WHFLRGZ0ZHVEbWNwdjNYalg2aGZKNGxGL2wxQ2UrajllWEFCcmgwcmc4N0dM?=
 =?utf-8?B?Z1o0MmJHb2FsZU5waXBOU2dOa1lRVXpiVm8xMDBUWnRLMlpHMEJiOUw2ZEUw?=
 =?utf-8?B?N1pveEo5UWNqUEc1c083UVpyMW84YXJnY1Y3L3Y3WnczcTN2QzYwNjdSNitB?=
 =?utf-8?B?RGRUZmZVcnRKTkw2MDFzVW1ndUo0eWVHdjlUb2QzRWlnL1YvTTM2bkUwb2Vj?=
 =?utf-8?B?Rld2YitZN2NUcDBsRE5nUmQ2UWIvMXZyU05hQkw3b2NNZGNnUTlVSkxFYWJ0?=
 =?utf-8?B?K3pwWnVqMk9IeCtHVGZyWDRlc2NKUTJvdE5pZzEzTjgrZm9BOVJNaldENkZI?=
 =?utf-8?B?cW0xcXVMSmV3c3hvdklXTzZBOTAyLzgyeUxvVjBudG51UFl2RFdldW5vQWto?=
 =?utf-8?B?cE9abW0zSHlWcmxIM3Bhblg3VkxIYkV6NWh0VUtnWDdrZVFuWWM1dENYdGp5?=
 =?utf-8?B?dG9weXc2dnZvTTdjM1JqYjdrenlCeXFHS1JMaS9FalJLMTFiMGxMSmVhY0oy?=
 =?utf-8?B?TSs2ZWhMZTdPeVk0bEVicDBaQ2ZoQmFzbUY4aW5oWFBGUlJPMFRHSEhpNEtB?=
 =?utf-8?B?L2I5TDRSd1pFYjhDd0hXMDlKWWUvR0RURXZhQ2RWWTZUbmhJNHg5ek5HMG5W?=
 =?utf-8?B?Z09nTHR3K3BwOEhJYU1vU0YxdHNIRDRXenFhSXlSamlNNlVnTzVmeG1aTXY5?=
 =?utf-8?B?SS9DRTF0UWFPMGI5ZXAyQlRoVDA5M29WZ0tISkpiSkVjM3Vkdk9OUXdJOUJa?=
 =?utf-8?B?RE1oWDhCZWJCOVdjNXpHWmpNNTNZL1FPZWpIaS9BcmpmN01adVRvNGhsaEJ4?=
 =?utf-8?B?Wlo1SGpibDhteC9PQU8rZVJsV1FqbEFRNkkyRFFxTjFWUXpGRk5yMlM0NXFx?=
 =?utf-8?B?UjdJdUpiYS9NQmwvRmE5QTNWbzkvTUNTZ2ZoaVI5UVNsVFBTVVlTSi9ZYWFu?=
 =?utf-8?B?NmNRS1pnMmdoSDZ4ZmVpcEp0ZlVlZW41ZzgwNDJ5T3FCZS9GMXg5SnV3S1JY?=
 =?utf-8?B?YVVjcVphUkoxRFJHai8zMEJlaU5sSVhiWjh1blFZQkEramFwcTNWNUd2d3JU?=
 =?utf-8?B?OWRtMGErUG1WeDllb083OEZjdGZCeVc5RXYwTlNSOVRRVDdxK3N5WThSUW53?=
 =?utf-8?B?WlhkUGNZZXNUcG1iKzhrbVhXN1Q0cnRUQ2NFN00zeW8yUzR1eW41ODk1b3cy?=
 =?utf-8?B?ME56d0srQ0dPRU1haVVmN3ZyTnpWZllBejU0WWRuLy8yR0FRNkVSeWJnYVNr?=
 =?utf-8?B?cE5IS0hDcGRzeXEwVXE0RDIvcnp2QklFWklPb2N1R1RyaG1jOEpxblVDZFJB?=
 =?utf-8?B?d0syOGZoVXdwY3ZXd0dMR25pQzlrMUZWYnRXdDFiYlNOZy94S1RVbDJ3alpi?=
 =?utf-8?B?QjMrc1NXaGpnbC8wTSszU0ZtNjhaLzQ3ZVhOdllibUdEdFNZdk9HRTk1bHBO?=
 =?utf-8?B?WTdDbXp6VTBJN3VHTFpWYkhWWkVPTE1jaEhxbFZSbTJVaFZyZUplRVUxTi9r?=
 =?utf-8?B?c2pEd3YyQXA4QkdrTUJaUzREQUZmeWZEM0NJQXByejVTRHhFV1AzalZFSUtK?=
 =?utf-8?B?OGUxa3c4QUJuMTlucXg4N09NZFA4NVdhYmJYazk0dnFROXlDR1VtU2FrWGxN?=
 =?utf-8?B?YmtjaUJrRm9TQ21DS2tkeXg4QXBOblB3WjlFTy9PMWtVL2lWYjh3SHEybWVJ?=
 =?utf-8?B?MUV6OWtnSUoxWmlPYlJ5UTlaMVdKdHp6K2wwN2pMbjhHVDNpWDU5OVc3eEM5?=
 =?utf-8?Q?LxXE=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d8779785-9b18-4049-331c-08dc529ab302
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:25:56.2297
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bb60hX+l6TU5Ok/39CUa+2ZiRGVNaHdRGjdozkr8NWzivTMQYzQlbgfLmTtXi71mCC+BjmZfwgxhExyH4cKDzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976

adc0_lpcg: clock-controller@5ac80000 {
	...						    Col1   Col2
	clocks = <&clk IMX_SC_R_ADC_0 IMX_SC_PM_CLK_PER>, // 0      0
		 <&dma_ipg_clk>;			  // 1      4
	clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>;
};

Col1: index, which exited dts try to get.
Col2: actual index in lpcg driver.

adc0: adc@5a880000 {
	clocks = <&adc0_lpcg 0>, <&adc0_lpcg 1>;
			     ^^              ^^
	clocks = <&adc0_lpcg IMX_LPCG_CLK_0>, <&adc0_lpcg IMX_LPCG_CLK_4>;

Arg0 is divided by 4 in lpcg driver. So adc get IMX_SC_PM_CLK_PER by
<&adc0_lpcg 0>, <&adc0_lpcg 1>. Although function can work, code logic is
wrong. Fix it by using correct indices.

Cc: stable@vger.kernel.org
Fixes: 1db044b25d2e ("arm64: dts: imx8dxl: add adc0 support")
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
index d4637037ba1b6..77ba2dd6847b4 100644
--- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
@@ -377,8 +377,8 @@ adc0: adc@5a880000 {
 		reg = <0x5a880000 0x10000>;
 		interrupts = <GIC_SPI 240 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-parent = <&gic>;
-		clocks = <&adc0_lpcg 0>,
-			 <&adc0_lpcg 1>;
+		clocks = <&adc0_lpcg IMX_LPCG_CLK_0>,
+			 <&adc0_lpcg IMX_LPCG_CLK_4>;
 		clock-names = "per", "ipg";
 		assigned-clocks = <&clk IMX_SC_R_ADC_0 IMX_SC_PM_CLK_PER>;
 		assigned-clock-rates = <24000000>;
@@ -392,8 +392,8 @@ adc1: adc@5a890000 {
 		reg = <0x5a890000 0x10000>;
 		interrupts = <GIC_SPI 241 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-parent = <&gic>;
-		clocks = <&adc1_lpcg 0>,
-			 <&adc1_lpcg 1>;
+		clocks = <&adc1_lpcg IMX_LPCG_CLK_0>,
+			 <&adc1_lpcg IMX_LPCG_CLK_4>;
 		clock-names = "per", "ipg";
 		assigned-clocks = <&clk IMX_SC_R_ADC_1 IMX_SC_PM_CLK_PER>;
 		assigned-clock-rates = <24000000>;

-- 
2.34.1