Received-SPF: pass (google.com: domain of linux-kernel+bounces-127128-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Frank Li <Frank.Li@nxp.com>
Date: Mon, 01 Apr 2024 18:25:05 -0400
Subject: [PATCH 3/7] arm64: dts: imx8-ss-dma: fix spi lpcg indices
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240401-dts_fix-v1-3-8c51ce52d411@nxp.com>
References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com>
In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com>
To: Rob Herring <robh+dt@kernel.org>, 
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
 Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, 
 Sascha Hauer <s.hauer@pengutronix.de>, 
 Pengutronix Kernel Team <kernel@pengutronix.de>, 
 Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, 
 Marcel Ziswiler <marcel.ziswiler@toradex.com>, 
 Philippe Schenker <philippe.schenker@toradex.com>, 
 Max Krummenacher <max.krummenacher@toradex.com>, 
 Alexander Stein <alexander.stein@ew.tq-group.com>, 
 Joakim Zhang <qiangqing.zhang@nxp.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
 linux-kernel@vger.kernel.org, Frank Li <Frank.Li@nxp.com>, 
 stable@vger.kernel.org
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
 =?utf-8?B?Qkk2M0hKL1I4NDdCQlBVSksyaFBOT29WemlTM0xGdklWdlNqcFlPTFZ5d3Rq?=
 =?utf-8?B?VTV1aDN5ZTBqRHNrSWxXL0J5R01RZ1NmSDFneDQ5bkNyUmR1NlROK3JlV0FL?=
 =?utf-8?B?Vk5KaUZuWjA5WjFSZkw3aEdhMUhNS1pyVzl5WGxnSDU0ZFVwRXZDL1Y3WHVF?=
 =?utf-8?B?UmRxb2dPTVpTeGtkL05HMW4rY2E5bzRWWEFsQUtrc1hpbmJBbXZYbDZENFdS?=
 =?utf-8?B?Mlc1REVPZ2czMVc0TUhWNXRQd0xvVVI4VjRSTjc2ZnV3WnZaSXJSU1FleWJY?=
 =?utf-8?B?NWhObGVQQkcrNGthT0pWVFFBd25OdzZjYjhKMjFDdjdTMDVJU29PNXZ0QXo5?=
 =?utf-8?B?MUtwdU9SR05LRGpvOUkwUVRHN0FjYWI3MS94cjlPUVY4MThzaUo5ckhRN0xU?=
 =?utf-8?B?OXZsT3lmbi9Ycmt2cEVKb2xncEFtNHd0YUNUdXo0dFBzWGtuMGU5L2ZKMTg4?=
 =?utf-8?B?QWhPeUJOMTl1KzEzaC9DYTlvcW5SNHY2Z0htTG5KNGtrL1A4VXNYL2NRZDYz?=
 =?utf-8?B?NDJrQjhEMlVmaHFhNzE3alJmQlV6Zll1SmJEeXlKcE5XSlNhR0tEN2ZpWFZG?=
 =?utf-8?B?Mkp5SGJWQTFRc1RrT2Vjc1hnbk9pYmdKcXFoUzV5L3NhTTljQW9ITmJpZHJh?=
 =?utf-8?B?Z3l1Nm1mOGt0dzFNdUU5TSt6amtORHNXNWxUUDk2c3hXMi8xZGNQaVMvd3cz?=
 =?utf-8?B?TjYrcFRvQWxsSDFNK0dodHptbEtheTZ5dWNUN2llSzdmM05OMmgrOHI1UmFU?=
 =?utf-8?B?U2F3cjl2NE5OaUFWWS9wSjBhODI5ci9oRDBHY1dObVE3MGlkY01hYWFVQ3JV?=
 =?utf-8?B?MnZPa05VSHRSZ2ZwdmNFL2E3T2VjVlROMkVPNUVMdjNXc1hqaGpSYW1LNloz?=
 =?utf-8?B?blQ5K0diNTZHa2tvbnZBTkNyM0dtOE9vNTZqTXdmdzdZZzU1L3dCSlBWL2Fq?=
 =?utf-8?B?TFBMS3V2WGNybnFGbXl5dWI2dmkvQW5ja3BxMGlxZUh5RTM1RTc4SlVPUEsx?=
 =?utf-8?B?VHEyYnIxWTViSVRCNDN6OXBZWDZ0bVdIWFo5R0VSMVJ6OFN2eDR4QjdFQWV5?=
 =?utf-8?B?L1ZKV3FMYUZNVlZyNWdmTzNDTUppSklXZjdJU0hPckg1cmtlL2E2TEVRWjRi?=
 =?utf-8?B?TnR3RUxPSXpYVDBGejR3RytmMHlkY3lacDk1Q3FtSHJIVDNrNjdvTGNSRWVN?=
 =?utf-8?B?MmxMNUZTMG1JbHlQMUkvZWNDOTVtQko1ejZ2VFJmTFBjdDVSeUN0dGpmcHZp?=
 =?utf-8?B?bHRqSjlwaTBuVitDVDFOWmlGWlhYZHBtZXNvcnJweHRjSGNYL2JQQ2FkTTl4?=
 =?utf-8?B?Mjd0MXBHRUVFWGU5Nk83T1RqWnZFSmxtekpXUWhuaFdkQVIvTjZSQS90Ym5T?=
 =?utf-8?B?Rzc1ZEN6bERxeHFZLzlBZHhrZjJ6V3hzNFJqa0pkNkFPSngwRDYxR0F6Z0tC?=
 =?utf-8?B?NzZ3NDhBNHpXRVdIVlo0QzV0M2QrUEYwR1RVYXlPZWV5TlVSZ3ZaOTNyKzgz?=
 =?utf-8?B?STFKM1ZvbXNZYlZmZ0gxZ21TNVlJQUV5SUUwbndSdy81TnBKZk5jVHZKU3R0?=
 =?utf-8?B?SFpMNy85cmFXcU1aQzg4Z21ZSHdUaUltdVZnWVhzV2JvTEVBM0tLeHFtM1pj?=
 =?utf-8?B?UEM4ajJmVmI1MDNvSkk2UW8vclpGM0duTFJyeTd0aW9KeG9DRUFhY0xXS25G?=
 =?utf-8?B?d2ZMaHJqNmgyclhhbmV1V1M1OS9YY0hBSlpGRjdkWXEwK1FRWUhUam9TMWlX?=
 =?utf-8?B?UzlmSVQxRUQ0eG1NaXZsc0ljbDNzc0ttYVhVTCs2R2RLbWpreTBtdnVxcm1U?=
 =?utf-8?B?eDVERUZ2VDRCaE9HbmlTQUVYUlNUMDBWcDFBa2JxZWM0Vy9zSzhyalVFQnVC?=
 =?utf-8?B?NzNJNkhUWkpOclVLQnlldzN1Z2RUWU03MStyODl1cTZhWTBoblhXdnZabG05?=
 =?utf-8?B?YlRPb0U4em5vbzdlMjRLUkp0bno2VkRWektXdkFjaUZOVThZV1NmQURtTEZF?=
 =?utf-8?B?ZURYamd4ajhrS2RnY0xXS1lYUVh0NkF6dWo5L0thRkgvaStxdUhBTVVrZXEr?=
 =?utf-8?B?V3lzbmFyZ3FOaTRyUG91bEZicU1yemFRTkNLdUEwSFdPRkVNakliUnloa1A5?=
 =?utf-8?Q?TiG4=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d5b979a-3e07-4e94-860e-08dc529aadf4
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:25:47.7573
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cxD8Wm8S8mzkrTk4WEuCFKBM2JYkZxmNYDRzAXGkf7mZbzTIUa9PZhOfpobB8/o7BVHIMnnEd63yJC2zS0b5Xw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976

spi0_lpcg: clock-controller@5a400000 {
	...                                                  Col0   Col1
	clocks = <&clk IMX_SC_R_SPI_0 IMX_SC_PM_CLK_PER>,//   0      1
		 <&dma_ipg_clk>;                         //   1      4
	clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>;
};

Col1: index, which exited dts try to get.
Col2: actual index in lpcg driver.

lpspi0: spi@5a000000 {
	...
	clocks = <&spi0_lpcg 0>, <&spi0_lpcg 1>;
			     ^		     ^
Should be:
	clocks = <&spi0_lpcg IMX_LPCG_CLK_0>, <&spi0_lpcg IMX_LPCG_CLK_4>;
};

Arg0 is divided by 4 in lpcg driver. <&spi0_lpcg 0> and <&spi0_lpcg 1> are
IMX_SC_PM_CLK_PER. Although code can work, code logic is wrong. It should
use IMX_LPCG_CLK_0 and IMX_LPCG_CLK_4 for lpcg arg0.

Cc: stable@vger.kernel.org
Fixes: c4098885e790 ("arm64: dts: imx8dxl: add lpspi support")
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
index b0bb77150adcc..a124d6598406d 100644
--- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
@@ -27,8 +27,8 @@ lpspi0: spi@5a000000 {
 		#size-cells = <0>;
 		interrupts = <GIC_SPI 336 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-parent = <&gic>;
-		clocks = <&spi0_lpcg 0>,
-			 <&spi0_lpcg 1>;
+		clocks = <&spi0_lpcg IMX_LPCG_CLK_0>,
+			 <&spi0_lpcg IMX_LPCG_CLK_4>;
 		clock-names = "per", "ipg";
 		assigned-clocks = <&clk IMX_SC_R_SPI_0 IMX_SC_PM_CLK_PER>;
 		assigned-clock-rates = <60000000>;
@@ -43,8 +43,8 @@ lpspi1: spi@5a010000 {
 		#size-cells = <0>;
 		interrupts = <GIC_SPI 337 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-parent = <&gic>;
-		clocks = <&spi1_lpcg 0>,
-			 <&spi1_lpcg 1>;
+		clocks = <&spi1_lpcg IMX_LPCG_CLK_0>,
+			 <&spi1_lpcg IMX_LPCG_CLK_4>;
 		clock-names = "per", "ipg";
 		assigned-clocks = <&clk IMX_SC_R_SPI_1 IMX_SC_PM_CLK_PER>;
 		assigned-clock-rates = <60000000>;
@@ -59,8 +59,8 @@ lpspi2: spi@5a020000 {
 		#size-cells = <0>;
 		interrupts = <GIC_SPI 338 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-parent = <&gic>;
-		clocks = <&spi2_lpcg 0>,
-			 <&spi2_lpcg 1>;
+		clocks = <&spi2_lpcg IMX_LPCG_CLK_0>,
+			 <&spi2_lpcg IMX_LPCG_CLK_4>;
 		clock-names = "per", "ipg";
 		assigned-clocks = <&clk IMX_SC_R_SPI_2 IMX_SC_PM_CLK_PER>;
 		assigned-clock-rates = <60000000>;
@@ -75,8 +75,8 @@ lpspi3: spi@5a030000 {
 		#size-cells = <0>;
 		interrupts = <GIC_SPI 339 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-parent = <&gic>;
-		clocks = <&spi3_lpcg 0>,
-			 <&spi3_lpcg 1>;
+		clocks = <&spi3_lpcg IMX_LPCG_CLK_0>,
+			 <&spi3_lpcg IMX_LPCG_CLK_4>;
 		clock-names = "per", "ipg";
 		assigned-clocks = <&clk IMX_SC_R_SPI_3 IMX_SC_PM_CLK_PER>;
 		assigned-clock-rates = <60000000>;

-- 
2.34.1