Received-SPF: pass (google.com: domain of linux-kernel+bounces-127158-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> <20240401-dts_fix-v1-1-8c51ce52d411@nxp.com>
In-Reply-To: <20240401-dts_fix-v1-1-8c51ce52d411@nxp.com>
From: Fabio Estevam <festevam@gmail.com>
Date: Mon, 1 Apr 2024 20:04:56 -0300
Message-ID: <CAOMZO5AJrQ5jyV4A-tvX93-R0_nEWpEO9YY3f5DpeXaAFO4cSA@mail.gmail.com>
Subject: Re: [PATCH 1/7] arm64: dts: imx8-ss-lsio: fix pwm lpcg indices
To: Frank Li <Frank.Li@nxp.com>
Cc: Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, 
	Pengutronix Kernel Team <kernel@pengutronix.de>, NXP Linux Team <linux-imx@nxp.com>, 
	Marcel Ziswiler <marcel.ziswiler@toradex.com>, 
	Philippe Schenker <philippe.schenker@toradex.com>, 
	Max Krummenacher <max.krummenacher@toradex.com>, 
	Alexander Stein <alexander.stein@ew.tq-group.com>, Joakim Zhang <qiangqing.zhang@nxp.com>, 
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 1, 2024 at 7:25=E2=80=AFPM Frank Li <Frank.Li@nxp.com> wrote:
>
> lpcg's arg0 should use clock indices instead of index.
>
> pwm0_lpcg: clock-controller@5d400000 {
>         ...                                                // Col1  Col2
>         clocks =3D <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>,  // 0     0
>                  <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>,  // 1     1
>                  <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>,  // 2     4
>                  <&lsio_bus_clk>,                          // 3     5
>                  <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>;  // 4     6
>         clock-indices =3D <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_1>,
>                         <IMX_LPCG_CLK_4>, <IMX_LPCG_CLK_5>,
>                         <IMX_LPCG_CLK_6>;
> };
>
> Col1: index, which exited dts try to get.

I cannot understand this sentence, sorry.

> Col2: actual index in lpcg driver.

You should not describe DT in terms of Linux driver.