Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp1769207lqz; Mon, 1 Apr 2024 17:34:24 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU0W+DVFAdcV55kgiDEfZUwFNFz2uFshFXYQCDPOj6skJZ88bno67waxFV0pbLzIy8hfb1owd9Di5q+K2fs4stu9OOg5cQG5IqPmQQbqA== X-Google-Smtp-Source: AGHT+IFZNjEl/PGaSQdtJlCZtNp6KrpnNUwr8dHRhB7wX4tcw51pn4RgDUf459C5qxNIwehpLDQE X-Received: by 2002:a17:90a:fb4e:b0:2a2:53ee:bd08 with SMTP id iq14-20020a17090afb4e00b002a253eebd08mr795191pjb.8.1712018063934; Mon, 01 Apr 2024 17:34:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712018063; cv=pass; d=google.com; s=arc-20160816; b=F+SQlfYt1ax5M+F6wHnYEX72iavd+7O1TPQC/aANP+4qgFvZC8qnv9Y5wq/G43J7uE tcJrSRLhczk4f3+mPMqwgum+3/cEGy9OGVZjZi430stIngY4cPeVcbxfH2uGjySoMMu/ 1NAZhcfuC21frMiU60u2a3iWqwFQgS3/Zfx7sm8mUtaiAxBY5GIir/PnVN1ZqE2WnLQG Viyz8Z2fw44od/9IMcVUd50vA4Fui+4Co/4MNcewWgoCFOEzeyWRbPnXIVZHrwJF66zY 6BnXEQV55otSYt7N6L1FbpDEy/68wlCkkZrCf2Fi7gmIxp2SD3ECtaBsJZ7Q9s8NEYDY uG1A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2VP4oPUjG7+cTRXLUPxAk6kKBT7PPaJfZQ6oyGi5qls=; fh=8VSZBOActgAc9FXh4PcB2Vu6qWYrAObAeTpkmwnjBvk=; b=AOf13lPprg4kLxfDzCo3qVJubP2W9fcrN6xjFGzPn/a0n9XeSraXp7szjYOxPBmN0t 9lTrROMfFATMVRck1NHAv6e7PhLdd/9R3Volilr6ZIdV1hk7VimGPG7kbZ7TNFwTBA1y OTYR1NukB/NCizC2qFyWNbfx/qARqfrXkd1M3t5TNF2gpY17wwPTx/Ct3xhs9b0FXGPI bLbC9+FFUfP3LLIMqEo++bmzV64TmhfOGLZ2LQqx1Y33z0GdITw/ZGhDheBMmB9mW7UJ KEfh+UgWGbrieJYJGXfU4nZ406uS4zG/BrkKthFW4UNSe9oCVqIyUPejxbe3bwFsQNHp /WTQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=enPGhwQb; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-127241-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-127241-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id f2-20020a17090ace0200b002a25dd4a792si75232pju.115.2024.04.01.17.34.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 17:34:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-127241-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=enPGhwQb; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-127241-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-127241-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 476CB283762 for ; Tue, 2 Apr 2024 00:34:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C94C84683; Tue, 2 Apr 2024 00:34:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="enPGhwQb" Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7474610E4 for ; Tue, 2 Apr 2024 00:34:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712018058; cv=none; b=p4r3/4J0p8RWNobWMXyozhn2bPhsA4BEq5PV3+07C7CJNMGFbnX7BzNnjhAhDhPKiAFTotATYJeA0uOgRdhQ0FoneGpS7q1Bm2BusdgyHCSj3d91mmuck151J5b1s6tVWwopGQQExRLFwcHyCFk3ROKVkjiZ19Nkj67J/AyD0YA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712018058; c=relaxed/simple; bh=RCW7qNqU3+fNH7VeWyWc6RMkRuVqMYUD+E+QsNcfcDQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KHBjPNsaH9dB8fsqrh1ix6XlJGuzJs/lQgXPfqBkQPpnASiAep2R2P14uZHldSyvloT1OkjJc6Zl6aWQYjUJSwB3IIcpi+K4ipDTuzWAwlG8naJg+DuiFXJfdfRLhGaJCuB/ErXEqde6i0xoYWxqKGhpY9AeSG++4bdmR1Kp35k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=enPGhwQb; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2VP4oPUjG7+cTRXLUPxAk6kKBT7PPaJfZQ6oyGi5qls=; b=enPGhwQbk1NobKHJ5OrJH/ZeuY vCIcgJe0U0JiI91g+EeRXANEEO5IWX0j8FEELDZqpedtUjX2wL55gDQNiQz8uUaKkUNA2jxxg2DV6 PR7JvfK0wPKH0upfsj9NmAokcEyKAjYOCayfXB8bSPH4rwygODWkchxKJfHu3/LjQmBd7TmaIh9CA 7s+iybS/wOEMSbQIlr/+O6dadY7CW8IRk5k3zEBi5TPfx97qkzqtcz8hzaMxgBIUzW+YrKsBhmjiZ Y4FT707TIcGLlPU8Zs4OCZAawNlhJZqldabxF8MP3d4tb8QJTE2mYI3nqwxQ8OftbtjncQfW9Zmga 9vW0vdYA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrS6I-00000001nlc-3ixt; Tue, 02 Apr 2024 00:34:06 +0000 Date: Tue, 2 Apr 2024 01:34:06 +0100 From: Matthew Wilcox To: "zhaoyang.huang" Cc: Andrew Morton , NeilBrown , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com, Christoph Hellwig Subject: Re: [PATCHv2 1/1] mm: fix unproperly folio_put by changing API in read_pages Message-ID: References: <20240401081734.1433755-1-zhaoyang.huang@unisoc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240401081734.1433755-1-zhaoyang.huang@unisoc.com> On Mon, Apr 01, 2024 at 04:17:34PM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > An VM_BUG_ON in step 9 of [1] could happen as the refcnt is dropped > unproperly during the procedure of read_pages()->readahead_folio->folio_put. > This is introduced by commit 9fd472af84ab ("mm: improve cleanup when > ->readpages doesn't process all pages")'. This patch is no less bullshit than the last time you posted it. I explained why here: https://lore.kernel.org/linux-mm/ZgQRtQ60mrvOUKXo@casper.infradead.org/