Received-SPF: pass (google.com: domain of linux-kernel+bounces-122387-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
CC: <yangyicong@hisilicon.com>, <linux-kernel@vger.kernel.org>,
	<alexei.starovoitov@gmail.com>
Subject: Re: [PATCH -next] tools headers: Make linux/btf_ids.h self-contained
To: Gaosheng Cui <cuigaosheng1@huawei.com>, <ast@kernel.org>, <dxu@dxuuu.xyz>,
	<andrii@kernel.org>, <ndesaulniers@google.com>, <vmalik@redhat.com>
References: <20240325011059.1001518-1-cuigaosheng1@huawei.com>
From: Yicong Yang <yangyicong@huawei.com>
Message-ID: <53c2df6c-0422-732c-02d1-e803889e8781@huawei.com>
Date: Thu, 28 Mar 2024 11:49:37 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.1
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240325011059.1001518-1-cuigaosheng1@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Hi,

On 2024/3/25 9:10, Gaosheng Cui wrote:
> Add the missing #include <linux/types.h>.
> 
> Fix the following compile error:
>   In file included from main.c:73:
>   tools/include/linux/btf_ids.h:7:9: error: unknown type name ‘u32’
>     7 |         u32 cnt;
>       |         ^~~
>   tools/include/linux/btf_ids.h:8:9: error: unknown type name ‘u32’
>     8 |         u32 ids[];
>       |         ^~~
> 

I also met this on 6.9-rc1 and this patch could solve the issue.

I suspect this is introduced by 9707ac4fe2f5 ("tools/resolve_btfids: Refactor set sorting with types from btf_ids.h")?

Since we didn't contain this header before and compiling was fine, could we only include
this header in tools/bpf/resolve_btfids/main.c where error happens (tested fine)?

There's a same fix in [1] and the glibc/compiler version was blamed there. I compiled on
Ubuntu 18.04.1 with gcc 10.2.0 and glibc 2.27.

[1] https://lore.kernel.org/all/20240315091434.10622-1-dmitrii.bundin.a@gmail.com/#t

> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
>  tools/include/linux/btf_ids.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/include/linux/btf_ids.h b/tools/include/linux/btf_ids.h
> index 72535f00572f..7969607efe0d 100644
> --- a/tools/include/linux/btf_ids.h
> +++ b/tools/include/linux/btf_ids.h
> @@ -3,6 +3,8 @@
>  #ifndef _LINUX_BTF_IDS_H
>  #define _LINUX_BTF_IDS_H
>  
> +#include <linux/types.h>
> +
>  struct btf_id_set {
>  	u32 cnt;
>  	u32 ids[];
>