Received-SPF: pass (google.com: domain of linux-kernel+bounces-118295-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240325123603.1bdd6588@canb.auug.org.au>
In-Reply-To: <20240325123603.1bdd6588@canb.auug.org.au>
From: Suren Baghdasaryan <surenb@google.com>
Date: Mon, 25 Mar 2024 19:19:33 -0700
Message-ID: <CAJuCfpH4Ee00hM9+B7=mi5Dwjrhov8vUK-KwPuoO3wsD7iJSAQ@mail.gmail.com>
Subject: Re: linux-next: build warnings after merge of the mm tree
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andrew Morton <akpm@linux-foundation.org>, Kent Overstreet <kent.overstreet@linux.dev>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, 
	Linux Next Mailing List <linux-next@vger.kernel.org>, Randy Dunlap <rdunlap@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 24, 2024 at 6:36=E2=80=AFPM Stephen Rothwell <sfr@canb.auug.org=
au> wrote:
>
> Hi all,
>
> After merging the mm tree, today's linux-next build (htmldocs) produced
> these warnings:
>
> include/linux/slab.h:545: warning: expecting prototype for kmem_cache_all=
oc(). Prototype was for kmem_cache_alloc_noprof() instead
> include/linux/slab.h:652: warning: expecting prototype for kmalloc(). Pro=
totype was for kmalloc_noprof() instead
> include/linux/slab.h:692: warning: expecting prototype for kmalloc_array(=
). Prototype was for kmalloc_array_noprof() instead
> include/linux/slab.h:714: warning: expecting prototype for krealloc_array=
(). Prototype was for krealloc_array_noprof() instead
> include/linux/slab.h:730: warning: Function parameter or struct member '_=
n' not described in 'kcalloc'
> include/linux/slab.h:730: warning: Function parameter or struct member '_=
size' not described in 'kcalloc'
> include/linux/slab.h:730: warning: Function parameter or struct member '_=
flags' not described in 'kcalloc'
> include/linux/slab.h:730: warning: Excess function parameter 'n' descript=
ion in 'kcalloc'
> include/linux/slab.h:730: warning: Excess function parameter 'size' descr=
iption in 'kcalloc'
> include/linux/slab.h:730: warning: Excess function parameter 'flags' desc=
ription in 'kcalloc'
> include/linux/slab.h:774: warning: expecting prototype for kzalloc(). Pro=
totype was for kzalloc_noprof() instead
> mm/slab_common.c:1217: warning: expecting prototype for krealloc(). Proto=
type was for krealloc_noprof() instead
> mm/util.c:751: warning: expecting prototype for __vcalloc(). Prototype wa=
s for __vcalloc_noprof() instead
> mm/vmalloc.c:3897: warning: expecting prototype for vmalloc(). Prototype =
was for vmalloc_noprof() instead
> mm/vmalloc.c:3916: warning: expecting prototype for vmalloc_huge(). Proto=
type was for vmalloc_huge_noprof() instead
> mm/vmalloc.c:3953: warning: expecting prototype for vmalloc_user(). Proto=
type was for vmalloc_user_noprof() instead
> mm/mempool.c:245: warning: expecting prototype for mempool_init(). Protot=
ype was for mempool_init_noprof() instead
> mm/mempool.c:271: warning: Function parameter or struct member 'gfp_mask'=
 not described in 'mempool_create_node_noprof'
> mm/mempool.c:271: warning: Function parameter or struct member 'node_id' =
not described in 'mempool_create_node_noprof'
> mm/mempool.c:271: warning: expecting prototype for mempool_create_node().=
 Prototype was for mempool_create_node_noprof() instead
>
> Introduced by commits
>
>   c64e38ed88d1 ("mm/slab: enable slab allocation tagging for kmalloc and =
friends")
>   ea7b8933f21b ("mempool: hook up to memory allocation profiling")
>   576477564ede ("mm: vmalloc: enable memory allocation profiling")
>
> from the mm-unstable branch of the mm tree.

Thanks for the report, Stephen!
Let us check with Randy Dunlap how we should handle these. I assume we
still want documentation to document kmalloc(), not kmalloc_noprof().
Maybe there is a way to mute these warnings.

>
> --
> Cheers,
> Stephen Rothwell