Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp1790808lqz; Mon, 1 Apr 2024 18:36:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCURpuWyRSH7owkkKqcyJv8jqPzA1P4KYwdnItQ+zBqy3Lg3JZPgIpL1EUU5kbo/RLZn2t24iiC6216uF2tlUeGbLZtKuLYc9FkGXJM3/g== X-Google-Smtp-Source: AGHT+IHRPHJ5h2N4e7Mwh2ZeNsumOgl1YPbX6usme0i8g6+4ZoiaIamrFQ26SnYyNvzyRztuv1OL X-Received: by 2002:a05:6402:34d6:b0:56b:a077:2eee with SMTP id w22-20020a05640234d600b0056ba0772eeemr7678334edc.4.1712021787369; Mon, 01 Apr 2024 18:36:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712021787; cv=pass; d=google.com; s=arc-20160816; b=0KmaU78xZPE7lnzczb2P7cTktHVgTIpnyPOJczXiiNnzJT75CLRY95Y1rb3xaUGFwu +jRLHtJGQ+45IPYYgBdTf3UdYETRRSpJmQEDNLmeCygiGOmk57Ny5RtDnbpY7kWnFJ6M AqFcD7RsEP543pzR0qIoCJATFxIh7h8gv1zUCjhyXeSeIu8SiOvZBioenbcpc+IGmnbm fzJup689eZ6mCYfVwBkYfl63fDDh/qecY3SVSXC9KzrkcxGnja4EhCVSuH5ki9nsmqsu IJUiJFEr9F7mkIDw/oGShCOAUl8/Ep7EjPvLPQzKI6LHybycCZ2BPZRD8KRMB4lNEqum bspA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:feedback-id:dkim-signature:dkim-signature; bh=tXgXU16gHPPexP/een5uEQeJLLKmVvpOpyL4QaBKpWs=; fh=wDrqx0f+299Z9E/ydfQE0sLKgm4EkrYz7I1GVgXm5co=; b=i2CSJYOVEtmATUONAdKppE+035I65M1Qf/NPzsUj/f9w8lOZZzazS3oO87dEilil6r PR3zexEB6THFvozCM2+j3q3TQMe2Oj0E7QLKHvlhmZxXdGTIntmdEe1GkCYDXJqp4ncd 84lzDqLjwO/3Tuhm2PDA+YRSg8dSxAtHqTZAPyK09N2Wy878M0zw71+KYOMsFuF+GxuP Yo7V2WVbB3RUJRP9uDJNnjlavBtfquyyJTy1TB8YQlP0LAfS3wE+stknaA7knupEgCO1 ZWMYF4MYY9VstpwJTxKRLx2Lwi2q1GjuknEe8fYKmKdM8bik1bpudjPzqzujUJ9rJ2uL jHyg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ljones.dev header.s=fm3 header.b=Z3i7c9dm; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=UCdpp33s; arc=pass (i=1 dkim=pass dkdomain=ljones.dev dkim=pass dkdomain=messagingengine.com); spf=pass (google.com: domain of linux-kernel+bounces-127255-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-127255-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id i40-20020a0564020f2800b0056c443b92d7si5118081eda.121.2024.04.01.18.36.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 18:36:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-127255-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@ljones.dev header.s=fm3 header.b=Z3i7c9dm; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=UCdpp33s; arc=pass (i=1 dkim=pass dkdomain=ljones.dev dkim=pass dkdomain=messagingengine.com); spf=pass (google.com: domain of linux-kernel+bounces-127255-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-127255-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E93C91F22F7F for ; Tue, 2 Apr 2024 01:36:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7C40414F64; Tue, 2 Apr 2024 01:35:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ljones.dev header.i=@ljones.dev header.b="Z3i7c9dm"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="UCdpp33s" Received: from wfout3-smtp.messagingengine.com (wfout3-smtp.messagingengine.com [64.147.123.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC25214A99; Tue, 2 Apr 2024 01:35:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.123.146 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712021734; cv=none; b=Wyzo93M+hROhaMA5Yvnd6l3T7PY2oLz/v8hMyWowbVweg/4EldRAxfjwLNJoosDEA9h9RC3dPMMMkODkVeHijgkY55QzLfpjQH1b/EX3Vq91pwBbune89Qa9KS2Q03ihf8hflq3HnFpI33m1pGMsPhfIITBngbf6ynp08qEyxFg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712021734; c=relaxed/simple; bh=YGnLU4DMgKySQEjPe0P6Ui/q2SAR7zugjDjW5DXFI3E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FHaSAD8edWSKc/9o8HQqAl+F5jZodphe0U0V/jptv9rhCr+Ob//X28M0TOIEspeRwf0lJbNPNi8Vfw724YMWmgktu3ioEy65YOkEXIHUkXtniGQLgR7Sx16mkaNasTPYrTxjAJYZx3l2FM+szB38/P3Quw3+bP60k9n4UugeHD0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ljones.dev; spf=none smtp.mailfrom=ljones.dev; dkim=pass (2048-bit key) header.d=ljones.dev header.i=@ljones.dev header.b=Z3i7c9dm; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=UCdpp33s; arc=none smtp.client-ip=64.147.123.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ljones.dev Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ljones.dev Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfout.west.internal (Postfix) with ESMTP id 95EE31C000A0; Mon, 1 Apr 2024 21:35:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 01 Apr 2024 21:35:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1712021731; x= 1712108131; bh=tXgXU16gHPPexP/een5uEQeJLLKmVvpOpyL4QaBKpWs=; b=Z 3i7c9dm6kFDlCJimnST8X5SysefqCCnjrcJ/X32o6LwN3koVyNmvuApcJ3cVGYlP ZOE2iw3EaFP/0BlVdRTaXegKfvR2Y0a0NNYBHWi3OxNRCrzWPstuhxFjf8NRWh6l tnTKSIq1hwD6AqiOL9QRuCpiWWshm+25/PrwanWAWCIyCKRxd4BV6LUGx9xpqiFQ v3TQTyPuIp9zifkNnFcA5G7ynnKaQbwXH8XGBawE81q2UYa4k3lRJc4IW/uHWeQc c5RAYbH9hQRQb8PbsY/7wLi0AG9uI1nzUNg6Jbfa6IDGZBs239l6xVeJ5b5TcvCX gkZFWrkNSmHyI53uteSAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1712021731; x= 1712108131; bh=tXgXU16gHPPexP/een5uEQeJLLKmVvpOpyL4QaBKpWs=; b=U Cdpp33sM5AIWk6Bmp1/qrBdsFhzQFAag0VQ+y0h2mEXhI0+eKW5Y4XfoYcgk1cxJ oNFxpxyx4kPCU2Kff7n0tAPLZEZOXHNvEKncRI2m9/V7nkfSttMurYcn3FX05lQM dxyWubY3szSJOvK1n1ytd+6GiZT9atrNxdLBNiXCamrJxOd2SPw8Vk4lGSSiQdHb ABtqaZDw5VlWRKin+dVZdZ67yjpKCMC35ydCwPX/NrfG5zpHe4uPSF5LXrY0fWwh 1DdO5ahULampn44YU+WX1Rh8heZUrB8pnSI5XZlxlY9pTQNaxieSCGM5+fxV0eeB xO1vkKZZsPPBVCNKBMTDw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudefuddggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpedfnfhukhgvucffrdculfhonhgvshdfuceolhhukhgvsehl jhhonhgvshdruggvvheqnecuggftrfgrthhtvghrnhepgfetfedugfetudeuheetjefhue fggfelleetvdevtefhueeujeefvdegleevhefgnecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomheplhhukhgvsehljhhonhgvshdruggvvh X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 1 Apr 2024 21:35:28 -0400 (EDT) From: "Luke D. Jones" To: hdegoede@redhat.com Cc: corentin.chary@gmail.com, ilpo.jarvinen@linux.intel.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Luke D. Jones" Subject: [PATCH v1 6/9] platform/x86: asus-wmi: adjust formatting of ppt-() functions Date: Tue, 2 Apr 2024 14:34:50 +1300 Message-ID: <20240402013453.18205-7-luke@ljones.dev> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240402013453.18205-1-luke@ljones.dev> References: <20240402013453.18205-1-luke@ljones.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Shift the call to dev_get_drvdata() up to top of the function block in all of the ppt_() functions as part of a minor cleanup. Signed-off-by: Luke D. Jones --- drivers/platform/x86/asus-wmi.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index 0d304a04e7de..2ff78e194801 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -997,11 +997,10 @@ static ssize_t ppt_pl2_sppt_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { + struct asus_wmi *asus = dev_get_drvdata(dev); int result, err; u32 value; - struct asus_wmi *asus = dev_get_drvdata(dev); - result = kstrtou32(buf, 10, &value); if (result) return result; @@ -1041,11 +1040,10 @@ static ssize_t ppt_pl1_spl_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { + struct asus_wmi *asus = dev_get_drvdata(dev); int result, err; u32 value; - struct asus_wmi *asus = dev_get_drvdata(dev); - result = kstrtou32(buf, 10, &value); if (result) return result; @@ -1084,11 +1082,10 @@ static ssize_t ppt_fppt_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { + struct asus_wmi *asus = dev_get_drvdata(dev); int result, err; u32 value; - struct asus_wmi *asus = dev_get_drvdata(dev); - result = kstrtou32(buf, 10, &value); if (result) return result; @@ -1128,11 +1125,10 @@ static ssize_t ppt_apu_sppt_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { + struct asus_wmi *asus = dev_get_drvdata(dev); int result, err; u32 value; - struct asus_wmi *asus = dev_get_drvdata(dev); - result = kstrtou32(buf, 10, &value); if (result) return result; @@ -1172,11 +1168,10 @@ static ssize_t ppt_platform_sppt_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { + struct asus_wmi *asus = dev_get_drvdata(dev); int result, err; u32 value; - struct asus_wmi *asus = dev_get_drvdata(dev); - result = kstrtou32(buf, 10, &value); if (result) return result; @@ -1216,11 +1211,10 @@ static ssize_t nv_dynamic_boost_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { + struct asus_wmi *asus = dev_get_drvdata(dev); int result, err; u32 value; - struct asus_wmi *asus = dev_get_drvdata(dev); - result = kstrtou32(buf, 10, &value); if (result) return result; @@ -1260,11 +1254,10 @@ static ssize_t nv_temp_target_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { + struct asus_wmi *asus = dev_get_drvdata(dev); int result, err; u32 value; - struct asus_wmi *asus = dev_get_drvdata(dev); - result = kstrtou32(buf, 10, &value); if (result) return result; -- 2.44.0