Received-SPF: pass (google.com: domain of linux-kernel+bounces-127364-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 1 Apr 2024 21:17:22 -0700
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com,
	"David S. Miller" <davem@davemloft.net>,
	Andreas Larsson <andreas@gaisler.com>,
	Palmer Dabbelt <palmer@rivosinc.com>, Arnd Bergmann <arnd@arndb.de>,
	Marco Elver <elver@google.com>
Subject: Re: [PATCH RFC cmpxchg 2/8] sparc: Emulate one-byte and two-byte
 cmpxchg
Message-ID: <1d1bc9d7-ff7d-4554-9c07-90d4e210a91d@paulmck-laptop>
Reply-To: paulmck@kernel.org
References: <31c82dcc-e203-48a9-aadd-f2fcd57d94c1@paulmck-laptop>
 <20240401213950.3910531-2-paulmck@kernel.org>
 <20240401223803.GZ538574@ZenIV>
 <114dc62e-e0fb-41c8-bf9c-a9fda8b19eb6@paulmck-laptop>
 <20240402000758.GC538574@ZenIV>
 <20240402033753.GE538574@ZenIV>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240402033753.GE538574@ZenIV>

On Tue, Apr 02, 2024 at 04:37:53AM +0100, Al Viro wrote:
> On Tue, Apr 02, 2024 at 01:07:58AM +0100, Al Viro wrote:
> 
> > It does, IIRC.
> > 
> > > Would you like to do that patch?  If so, I would be happy to drop mine
> > > in favor of yours.  If not, could I please have your Signed-off-by so
> > > I can do the Co-developed-by dance?
> > 
> > Will do once I dig my way from under the pile of mail (sick for a week
> > and subscribed to l-k, among other lists)...
> 
> FWIW, parisc is in the same situation - atomics-by-cached-spinlocks.
> 've a candidate branch, will post if it survives build...

I am sure that it seemed like a good idea at the time.  ;-)

> Re parisc: why does it bother with arch_cmpxchg_local()?  Default is
> 	* save and disable local interrupts
> 	* read the current value, compare to old
> 	* if equal, store new there
> 	* restore local interrupts
> For 32bit case parisc goes for __cmpxchg_u32(), which is
> 	* if (SMP) choose the spinlock (indexed by hash of address)
> 	* save and disable local interrupes
> 	* if (SMP) arch_spin_lock(spinlock)
> 	* read the current value, compare to old
> 	* if equal, store new there
> 	* if (SMP) arch_spin_unlock(spinlock)
> 	* restore local interrupts
> In UP case it's identical to generic; on SMP it's strictly more work.
> Unless I'm very confused about cmpxchg_local() semantics, the
> callers do not expect atomicity wrt other CPUs, so why do we bother?

;-) ;-) ;-)

In any case, happy to replace my patches with yours whenever you have
them ready.

							Thanx, Paul