Received-SPF: pass (google.com: domain of linux-kernel+bounces-127371-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@intel.com>
To: ivecera <ivecera@redhat.com>, "intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Loktionov,
 Aleksandr" <aleksandr.loktionov@intel.com>, "edumazet@google.com"
	<edumazet@google.com>, "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
	"kuba@kernel.org" <kuba@kernel.org>, "pabeni@redhat.com" <pabeni@redhat.com>,
	"davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v2 5/7] i40e: Consolidate
 checks whether given VSI is main
Thread-Topic: [Intel-wired-lan] [PATCH iwl-next v2 5/7] i40e: Consolidate
 checks whether given VSI is main
Thread-Index: AQHagBzQmYRIg+7VaEiEYHXhf3NNArFUaxLQ
Date: Tue, 2 Apr 2024 04:25:44 +0000
Message-ID: <IA0PR11MB84191C97688B67FB04B11BF8BD3E2@IA0PR11MB8419.namprd11.prod.outlook.com>
References: <20240327075733.8967-1-ivecera@redhat.com>
 <20240327075733.8967-6-ivecera@redhat.com>
In-Reply-To: <20240327075733.8967-6-ivecera@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9MfQjtg51T8KhkZIHANit+jm34iLMh/Ba0HPz8jfUrRXDHdDz7NQUUPUezFZ?=
 =?us-ascii?Q?63ln4w8hAGpgJUhnX53HM+8QtBJF6g9ED3VZ0JoZoqp/mb6Lgvq59PpOpVl5?=
 =?us-ascii?Q?TbUpiHRtcyrgS6dt1wcVGbqbCnY9VgNR4bfKyeDen4skcaw3PBLHHSxNW/bQ?=
 =?us-ascii?Q?Ke4Nkwc4VU3pOh5dvMmFqNmA2GkrG6xxeIdEGSkieKffNG1pjOrclxFjMsJs?=
 =?us-ascii?Q?w0JlrqhxNgaTQ5WocH338DMgc8oSo6SNwlroSRNPRmj31QFvUwdlDEWA8vTq?=
 =?us-ascii?Q?Cg7Cgehep5Y0I3mU3q25OdKiV/3abWqhYmpuCN1fE65k+DGuoBn/XnbTwyRq?=
 =?us-ascii?Q?eHi1BVF8UyILCjkSNfp/OcVcInVmszV0SueuL6S74ASLlepeGUby0kGujCph?=
 =?us-ascii?Q?4JVAqB+kmhTJjI7ZxQ9SkdFa9f9ctzR6F+ShCrdXhdGswQGdHG/wFYx/Lh++?=
 =?us-ascii?Q?5/OjxivtXmBRuZiw18nJHX7CTQN5qhvgzjRGdKULQtCPjJZdSq7JL2McCNi9?=
 =?us-ascii?Q?ucTo0Tl80fXd93QrU7JEHX5R1wsKQWNXE2YGygTAmuLAJPKKkj3KVuC60VD3?=
 =?us-ascii?Q?Vv8Cay2qKth7EDf7PGr208JMfmuLQ17WpWaRFVBcWEMzFG7HW8CX9eVROpY4?=
 =?us-ascii?Q?pYnebo/68Jk+w++0nn5JPdGqQ3aoiXt4UMZKrvj5MvTCaRrYpJlOcVWQwMqJ?=
 =?us-ascii?Q?kmbiQlTBi7GT4Yi2AAfZ430H2uHyZP3/yFaFq+iCrTsGw+4MX2Q5rBHMMUOn?=
 =?us-ascii?Q?M8O3fqV/V4zQxETuWzlveMASKypa+ABpRfz7igP0VwMEqG9gElxU6Co87PTf?=
 =?us-ascii?Q?TO5DyheL0UACBxqjjjWqASpiLoFjLBdpKvK/ESqE9QeVakGkgYkWfU2csuM1?=
 =?us-ascii?Q?IerEmTq9GM0qq4gvz0YDMdc3IZWVv5QZgX2VkoAEnBQTquOadxPkzBG6rw0U?=
 =?us-ascii?Q?tlXjLKiZbFqFyapmX6DsI8ZUXVlRKEiap7DydadVSwQclGIJLmFG8QjGsqrW?=
 =?us-ascii?Q?0RtU5gor9Sg1bn6fD6BqxqLbmGe4gg9+mslhEz0mJchADUVExec0GZJ+Hwlw?=
 =?us-ascii?Q?4QYSFnOZT9uLfiv4BZa2jH0RoX+cV4huzZIglh+fWU4yZilrjyGn1nG5DIqZ?=
 =?us-ascii?Q?E1PRwsZY7t4PZrPJ7cT0UcgTezJLg8vBW97kt+E9U1Qa0UFkq9KCxxREDQzt?=
 =?us-ascii?Q?oS8QDUwJ++bOfFbmHePTsGKUcBS4RR7JQcCV0Un3OxC1846s/dIPFtd3BHZw?=
 =?us-ascii?Q?SoUmBOGNcT3Uxocph/CN9ihwzIOd6FPNwr7y9OCSFbAR1Y0D4KPoy2jhiE9/?=
 =?us-ascii?Q?lEmxoYjHmdLkIP8aT48hcD7lICPvMyapiY4bIUkNQUoaYzNYWL8gQZ49xG3B?=
 =?us-ascii?Q?HzM6zYSvJgDge1SiDeNDdFMx5Qd1jvJmft6SZkoAcQu0+De85KtS15qptTYS?=
 =?us-ascii?Q?NLhLosy5TdBMWlSiW9ff9x0AACuWRrMDT/q4iNAjgM9I4uOkDPx3bOlDNF9B?=
 =?us-ascii?Q?XKtiv+fAF1xaexSocThzzkq25MRerHEMfKdA6iVa+HMCM2KemYoc60ogk9ja?=
 =?us-ascii?Q?R1Y+B4QS/PcsN15bF9NUM4b5IwbtQmm9iOlmC/F/N9Xw+BJVhUtDyQ65KSoR?=
 =?us-ascii?Q?Vg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA0PR11MB8419.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65dea7ef-e296-476b-e245-08dc52ccf682
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2024 04:25:44.1724
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 57vHtwn+tq67QT31SulgyDQ6T0Px6JwweNvvRKLmcowQnT+HMbvCupTaHqNPsULHuRfs8Jdl/1F3l7G2mhioXl+0ua7PvJsRuMPAIoH15zkG9f55LZ0JkU1eUjYYUdF8
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8455
X-OriginatorOrg: intel.com

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of I=
van Vecera
> Sent: Wednesday, March 27, 2024 1:28 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Loktionov, Alek=
sandr <aleksandr.loktionov@intel.com>; edumazet@google.com; Nguyen, Anthony=
 L <anthony.l.nguyen@intel.com>; kuba@kernel.org; pabeni@redhat.com; davem@=
davemloft.net
> Subject: [Intel-wired-lan] [PATCH iwl-next v2 5/7] i40e: Consolidate chec=
ks whether given VSI is main
>
> In the driver code there are 3 types of checks whether given VSI is main =
or not:
> 1. vsi->type =3D=3D/!=3D I40E_VSI_MAIN
> 2. vsi =3D=3D/!=3D pf->vsi[pf->lan_vsi]
> 3. vsi->seid =3D=3D/!=3D pf->vsi[pf->lan_vsi]->seid
>
> All of them are equivalent and can be consolidated. Convert cases
> 2 and 3 to case 1.
>
> Reviewed-by: Michal Schmidt <mschmidt@redhat.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
>  .../net/ethernet/intel/i40e/i40e_debugfs.c    |  2 +-
>  .../net/ethernet/intel/i40e/i40e_ethtool.c    | 12 ++++++------
>  drivers/net/ethernet/intel/i40e/i40e_main.c   | 19 +++++++++----------
>  3 files changed, 16 insertions(+), 17 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Co=
ntingent worker at Intel)