Received-SPF: pass (google.com: domain of linux-kernel+bounces-127406-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <71ab04b76d23497ff63e36dcc05f6580223d22a2.camel@xry111.site>
Subject: Re: [PATCH v7 3/7] LoongArch: KVM: Add cpucfg area for kvm
 hypervisor
From: Xi Ruoyao <xry111@xry111.site>
To: maobibo <maobibo@loongson.cn>, WANG Xuerui <kernel@xen0n.name>, Huacai
 Chen <chenhuacai@kernel.org>, Tianrui Zhao <zhaotianrui@loongson.cn>,
 Juergen Gross <jgross@suse.com>, Paolo Bonzini <pbonzini@redhat.com>,
 Jonathan Corbet <corbet@lwn.net>
Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, 
	virtualization@lists.linux.dev, kvm@vger.kernel.org
Date: Tue, 02 Apr 2024 13:34:21 +0800
In-Reply-To: <d42c7783-3d0a-57fd-fcbe-a1a657255ae4@loongson.cn>
References: <20240315080710.2812974-1-maobibo@loongson.cn>
	 <20240315080710.2812974-4-maobibo@loongson.cn>
	 <4668e606-a7b5-49b7-a68d-1c2af86f7d76@xen0n.name>
	 <57e66ff5-1cb6-06bd-ee6f-a3c3dadd6aef@loongson.cn>
	 <b7d91c1a42470821983a811a16f9fc1c55cfe699.camel@xry111.site>
	 <d42c7783-3d0a-57fd-fcbe-a1a657255ae4@loongson.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.0 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-04-02 at 11:34 +0800, maobibo wrote:


> Are you sure that it's impossible to read some data used by the kernel
> internally?

Yes.

> There is another issue, since kernel restore T0-T7 registers and user
> space save T0-T7. Why T0-T7 is scratch registers rather than preserve
> registers like other architecture? What is the advantage if it is
> scratch registers?

I'd say "MIPS legacy."  Note that MIPS also does not preserve temp
registers, and MIPS does not have the "info leak" issue as well (or it
should have been assigned a CVE, in all these years).

I do agree maybe it's the time to move away from MIPS legacy and be more
similar to RISC-V etc now...

In Glibc we can condition __SYSCALL_CLOBBERS with #if
__LINUX_KERNEL_VERSION > xxxxxxx to take the advantage.

Huacai, Xuerui, how do you think?

--=20
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University