Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756638AbYASNRs (ORCPT ); Sat, 19 Jan 2008 08:17:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752284AbYASNRk (ORCPT ); Sat, 19 Jan 2008 08:17:40 -0500 Received: from pasmtpa.tele.dk ([80.160.77.114]:42213 "EHLO pasmtpA.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751898AbYASNRj (ORCPT ); Sat, 19 Jan 2008 08:17:39 -0500 Date: Sat, 19 Jan 2008 14:17:43 +0100 From: Sam Ravnborg To: Jeremy Fitzhardinge , Chris Wright Cc: Toralf =?iso-8859-1?Q?F=F6rster?= , linux-kernel@vger.kernel.org, rusty@rustcorp.com.au, WANG Cong Subject: [PATCH] xen: fix section usage in xen-head.S Message-ID: <20080119131743.GA26615@uranus.ravnborg.org> References: <200801181318.30009.toralf.foerster@gmx.de> <20080118122917.GH2559@hacking> <20080118124627.GA17918@uranus.ravnborg.org> <20080118125144.GI2559@hacking> <20080118132242.GA18183@uranus.ravnborg.org> <20080118161452.GJ2559@hacking> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20080118161452.GJ2559@hacking> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1380 Lines: 38 Failing to specify "ax" in the pushsection caused ld to generate an additional section for .init.text appending a number. A side effect of this was a section mismatch warning because modpost did not recognize a .init.text section named .init.text.1: WARNING: vmlinux.o(.text.head+0x247): Section mismatch: reference to .init.text.1:start_kernel (between 'is386' and 'check_x87') Fix this by hardcoding the "ax" in the pushsection. Thanks to Torlaf for reporting this. Alan Modra @ binutils provided the hint that made me able to locate the root cause of this warning. Signed-off-by: Sam Ravnborg Cc: Jeremy Fitzhardinge Cc: Chris Wright Cc: WANG Cong Cc: Toralf F?rster --- diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S index f8d6937..b05e85d 100644 --- a/arch/x86/xen/xen-head.S +++ b/arch/x86/xen/xen-head.S @@ -7,7 +7,7 @@ #include #include -.pushsection .init.text +.pushsection .init.text, "ax" ENTRY(startup_xen) movl %esi,xen_start_info cld -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/