Received-SPF: pass (google.com: domain of linux-kernel+bounces-127464-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 2 Apr 2024 14:52:48 +0800
From: Xu Yilun <yilun.xu@linux.intel.com>
To: Russ Weight <russ.weight@linux.dev>
Cc: Peter Colberg <peter.colberg@intel.com>,
	Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
	Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
	Lee Jones <lee@kernel.org>, linux-fpga@vger.kernel.org,
	linux-kernel@vger.kernel.org, Marco Pagani <marpagan@redhat.com>,
	Matthew Gerlach <matthew.gerlach@linux.intel.com>,
	Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>,
	Russ Weight <russell.h.weight@intel.com>
Subject: Re: [PATCH] mfd: intel-m10-bmc: Change staging size to a variable
Message-ID: <ZgurQETbga0Q/PVE@yilunxu-OptiPlex-7050>
References: <20240328233559.6949-1-peter.colberg@intel.com>
 <ZgqCdfCSatazEkIj@yilunxu-OptiPlex-7050>
 <20240401170905.v2xin3fzoe3m3tmz@4VRSMR2-DT.corp.robot.car>
 <20240401171947.dncdvc3gxna33nxq@4VRSMR2-DT.corp.robot.car>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240401171947.dncdvc3gxna33nxq@4VRSMR2-DT.corp.robot.car>

On Mon, Apr 01, 2024 at 10:19:47AM -0700, Russ Weight wrote:
> 
> On Mon, Apr 01, 2024 at 10:09:05AM -0700, Russ Weight wrote:
> > On Mon, Apr 01, 2024 at 05:46:29PM +0800, Xu Yilun wrote:
> > > On Thu, Mar 28, 2024 at 07:35:59PM -0400, Peter Colberg wrote:
> > > > From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > > > 
> > > > The size of the staging area in FLASH for FPGA updates is dependent on the
> > > > size of the FPGA. Currently, the staging size is defined as a constant.
> > > > Larger FPGAs are coming soon and it will soon be necessary to support
> > > 
> > > Soon? When? You cannot add some feature without a user case. If you do
> > > have a use case, put the patch in the same patchset.
> > 
> > There may never be an up-streamed use-case. This is a very small
> > change intended to make it easier for a third-party vendor to
> > build a card that requires a larger staging area in FLASH. They
> > would have to add a new "struct m10bmc_csr_map", but they
> > wouldn't have to refactor this code as part of the change

I'm OK with this description.

Peter, is that what you mean? Or you do have a board type to follow, in
which case you need to submit the new board type as well.

> > 
> > This change does not introduce an unused function or variable.
> > It is more of a clean-up, making the code more flexible.
> > 
> > Can it not be taken as is?
> 
> Would it be acceptable to just change the commit message to something
> like:
> 
> Do not hardwire the staging size in the secure update driver. Move
> the staging size to the m10bmc_csr_map structure to make the size
> assignment more flexible.

That would be much better.

Thanks,
Yilun