Received-SPF: pass (google.com: domain of linux-kernel+bounces-127473-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240402001500.53533-1-pcc@google.com> <b939165e-a227-4b96-bdc8-12afba801c03@suse.cz>
 <CAG_fn=XL7tSuCuBXKf1YDiETkFMte7JyLrSE+saDthtJj==hUQ@mail.gmail.com>
In-Reply-To: <CAG_fn=XL7tSuCuBXKf1YDiETkFMte7JyLrSE+saDthtJj==hUQ@mail.gmail.com>
From: Marco Elver <elver@google.com>
Date: Tue, 2 Apr 2024 09:08:29 +0200
Message-ID: <CANpmjNOonPXC9JzMJ2spmTU+80pYJJzW90omy2pvF7=0qNJU3Q@mail.gmail.com>
Subject: Re: [PATCH] stackdepot: Rename pool_index to pool_index_plus_1
To: Alexander Potapenko <glider@google.com>
Cc: Vlastimil Babka <vbabka@suse.cz>, Peter Collingbourne <pcc@google.com>, 
	Andrey Konovalov <andreyknvl@gmail.com>, Oscar Salvador <osalvador@suse.de>, 
	Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, 
	linux-mm@kvack.org, Michal Hocko <mhocko@suse.com>, Omar Sandoval <osandov@fb.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2 Apr 2024 at 09:04, Alexander Potapenko <glider@google.com> wrote:
>
> On Tue, Apr 2, 2024 at 8:54=E2=80=AFAM Vlastimil Babka <vbabka@suse.cz> w=
rote:
> >
> > On 4/2/24 2:14 AM, Peter Collingbourne wrote:
> > > Commit 3ee34eabac2a ("lib/stackdepot: fix first entry having a
> > > 0-handle") changed the meaning of the pool_index field to mean "the
> > > pool index plus 1". This made the code accessing this field less
> > > self-documenting, as well as causing debuggers such as drgn to not
> > > be able to easily remain compatible with both old and new kernels,
> > > because they typically do that by testing for presence of the new
> > > field. Because stackdepot is a debugging tool, we should make sure
> > > that it is debugger friendly. Therefore, give the field a different
> > > name to improve readability as well as enabling debugger backwards
> > > compatibility.
> > >
> > > Signed-off-by: Peter Collingbourne <pcc@google.com>
> > > Link: https://linux-review.googlesource.com/id/Ib3e70c36c1d230dd0a118=
dc22649b33e768b9f88
> >
> > Acked-by: Vlastimil Babka <vbabka@suse.cz>
> Reviewed-by: Alexander Potapenko <glider@google.com>

Acked-by: Marco Elver <elver@google.com>