Received-SPF: pass (google.com: domain of linux-kernel+bounces-127492-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <137c184267faacdc3024f0b88e53889571165a84.1711715780.git.geert+renesas@glider.be>
 <4ef1eb4e-b1f8-4b5c-9280-5834f946fcde@linaro.org>
In-Reply-To: <4ef1eb4e-b1f8-4b5c-9280-5834f946fcde@linaro.org>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 2 Apr 2024 09:14:32 +0200
Message-ID: <CAMuHMdW7HNsHqoE5eNyXcc6JJ6MxcpRFXQ6z4ECd-ANEY8xrgQ@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: timer: renesas,tmu: Make interrupt-names required
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>, Thomas Gleixner <tglx@linutronix.de>, 
	Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
	Conor Dooley <conor+dt@kernel.org>, 
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, 
	linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Krzysztof,

On Fri, Mar 29, 2024 at 6:42=E2=80=AFPM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> On 29/03/2024 13:37, Geert Uytterhoeven wrote:
> > Now all in-tree users have been updated with interrupt-names properties
> > according to commit 0076a37a426b6c85 ("dt-bindings: timer: renesas,tmu:
> > Document input capture interrupt"), make interrupt-names required.
>
> Would be nice to see here *why* they should be required, e.g. "Linux
> driver needs them since commit foobar").

The driver doesn't use the names, nor the optional input capture
interrupt yet.

This is just part of the continuous improvement of Very Old and Immature
DT Bindings, dating back to the days when most animals could still talk,
and before DT became self-aware.

I could add that (or something simpler ;-) for v2, but as the reason
is basically the "for clarity" in the linked commit....

> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >  Documentation/devicetree/bindings/timer/renesas,tmu.yaml | 1 +
> >  1 file changed, 1 insertion(+)
>
> Anyway:
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks!

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds