Received-SPF: pass (google.com: domain of linux-kernel+bounces-127497-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 2 Apr 2024 09:17:23 +0200
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Michael Walle
 <mwalle@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] nvmem: layouts: sl28vpd: drop driver owner
 initialization
Message-ID: <20240402091723.1923c13c@xps-13>
In-Reply-To: <20240329-module-owner-nvmem-v1-3-d700685f08e1@linaro.org>
References: <20240329-module-owner-nvmem-v1-0-d700685f08e1@linaro.org>
	<20240329-module-owner-nvmem-v1-3-d700685f08e1@linaro.org>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Krzysztof,

krzysztof.kozlowski@linaro.org wrote on Fri, 29 Mar 2024 17:13:37 +0100:

> Core in nvmem_layout_driver_register() already sets the .owner, so
> driver does not need to.
>=20

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/nvmem/layouts/sl28vpd.c | 1 -
>  1 file changed, 1 deletion(-)
>=20
> diff --git a/drivers/nvmem/layouts/sl28vpd.c b/drivers/nvmem/layouts/sl28=
vpd.c
> index 53fa50f17dca..e93b020b0836 100644
> --- a/drivers/nvmem/layouts/sl28vpd.c
> +++ b/drivers/nvmem/layouts/sl28vpd.c
> @@ -156,7 +156,6 @@ MODULE_DEVICE_TABLE(of, sl28vpd_of_match_table);
> =20
>  static struct nvmem_layout_driver sl28vpd_layout =3D {
>  	.driver =3D {
> -		.owner =3D THIS_MODULE,
>  		.name =3D "kontron-sl28vpd-layout",
>  		.of_match_table =3D sl28vpd_of_match_$

Thanks,
Miqu=C3=A8l